[NP] Get rid of usage redirectWhenMissing service by sulemanof · Pull Request #59777 · elastic/kibana

sulemanof · 2020-03-10T15:54:51Z

Summary

A part of #58999.

This cutover redirectWhenMissing to kibana_utils.
Affects shimmed plugins: dashboard, visualize, discover.
Removes the reference in x-pack/legacy/plugins/monitoring since unused.

This contains couple of fixes:

fix all redirects which check error instance of SavedObjectNotFound, look at this comment for details;
fix redirection when trying to load a visualization with an invalid type, added a proper warning message, redirect to the listing page;
fix broken redirection in scope of the same plugin, e.x. opening visualization with non-exists id ->

open any saved visualiztion
change the id in the url and press enter (or copy the url with wrong id and open in a new browser tab)
a toast appears, but redirection is not happening

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

…n_missing # Conflicts: # src/legacy/core_plugins/kibana/public/discover/np_ready/angular/discover.js # src/legacy/core_plugins/kibana/public/visualize/np_ready/legacy_app.js

src/legacy/core_plugins/kibana/public/dashboard/np_ready/legacy_app.js

elasticmachine · 2020-03-11T10:43:25Z

Pinging @elastic/kibana-app (Team:KibanaApp)

sulemanof · 2020-03-11T16:21:03Z

@elasticmachine merge upstream

igoristic

Looks good from Stack Monitoring 👍 Thanks for doing this, was already going to do it eventually: #59673

src/plugins/kibana_utils/public/history/redirect_when_missing.tsx

…n_missing

…ana into shim/redirect_when_missing

sulemanof · 2020-03-12T13:37:22Z

@elasticmachine merge upstream

…ana into shim/redirect_when_missing

src/legacy/core_plugins/kibana/public/dashboard/np_ready/legacy_app.js

src/legacy/core_plugins/kibana/public/discover/np_ready/angular/discover.js

src/legacy/core_plugins/kibana/public/visualize/np_ready/editor/editor.js

src/legacy/core_plugins/kibana/public/visualize/np_ready/legacy_app.js

…n_missing # Conflicts: # src/legacy/core_plugins/kibana/public/discover/kibana_services.ts # src/legacy/core_plugins/kibana/public/visualize/np_ready/editor/editor.js

…n_missing

kertal

Code LGTM, tested locally in Chrome, works, the management redirection issue is no regression, I'll create an issue for that. Many thanks for taking care of ancient 🐛

kibanamachine · 2020-03-17T09:37:41Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b2bff24

History

💚 Build #33373 succeeded b51e97e
💚 Build #33355 succeeded d261a0b
💚 Build #32822 succeeded 1280ec0
💔 Build #32766 failed 064b36e
💔 Build #32484 failed dd752ce

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Changes was addressed , reviewer in his well deserved holidays

ppisljar

code LGTM

* Move redirect_when_missing to kibana utils * Replace redirectWhenMissing in dashboard * Replace redirectWhenMissing in discover * Remove redirect in monitoring * Remove extra import * Move invalid vistype check into editor.js * Mock the history folder * Fix redirect when missing index or saved object * Move history to discover services * Use redirect to listing page Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (30 commits) [TSVB] fix text color when using custom background color (elastic#60261) Fix import to timefilter from in TSVB (elastic#60296) [NP] Get rid of usage redirectWhenMissing service (elastic#59777) [SIEM] Fix Timeline footer styling (elastic#59587) [ML] Fixes to error handling for analytics jobs and file data viz (elastic#60249) Give better stack traces for Unhandled Promise Rejection warnings (elastic#60235) resolves elastic#58905 (elastic#60120) Added variables button for text fields in Pagerduty component. (elastic#60189) adds test that action vars are rendered for alert action parms (elastic#60310) Closes 59786 by removing the update toast (elastic#60172) [EPM] Packages list tabs (elastic#60167) Added message variables button for Webhook body form field (elastic#60174) Revert "adds new test (elastic#60064)" [Maps] move MapSavedObject type out of telemetry (elastic#60127) [Reporting] Fix error handling for job handler in route (elastic#60161) [Endpoint] TEST: verify alerts page header says 'Alerts' (elastic#60206) EMT-248: implement ack resource to accept event payload to acknowledge agent actions (elastic#60218) Migrate dual validated range (elastic#59689) Embeddable triggers (elastic#58440) [Endpoint] Sample data generator CLI script (elastic#59952) ...

* Move redirect_when_missing to kibana utils * Replace redirectWhenMissing in dashboard * Replace redirectWhenMissing in discover * Remove redirect in monitoring * Remove extra import * Move invalid vistype check into editor.js * Mock the history folder * Fix redirect when missing index or saved object * Move history to discover services * Use redirect to listing page Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (51 commits) do not update cell background if is label cell (elastic#60308) FTR configurable test users (elastic#52431) [Reporting] Wholesale moves client to newest-platform (elastic#58945) [Ingest] Support `show_user` package registry flag (elastic#60338) [SIEM] Adds 'Closes one signal when more than one opened signals are selected' test again (elastic#60380) [SIEM][Detections Engine] - Add rule markdown field to rule create, detail, and edit flows (elastic#60108) [Fleet] Add config revision to fleet agents (elastic#60292) Allow kbn-config-schema to ignore unknown keys (elastic#59560) [ML] Functional tests - disable df analytics clone tests skip flaky suite (elastic#58643) (elastic#58991) [FTR] Add support for --include and --exclude files via tags (elastic#60123) [SIEM] Fix link on overview page (elastic#60348) skip flaky test (elastic#60369) [Endpoint] Adds take action dropdown and tests to alert details flyout (elastic#59242) [Lens] Simplify state management from visualization (elastic#58279) Changing default type to start and allowing it to be configured by the event category (elastic#60323) [ML] Adds the class_assignment_objective to classification (elastic#60358) [TSVB] fix text color when using custom background color (elastic#60261) Fix import to timefilter from in TSVB (elastic#60296) [NP] Get rid of usage redirectWhenMissing service (elastic#59777) ...

sulemanof added 5 commits March 10, 2020 18:19

Move redirect_when_missing to kibana utils

ea33af6

Replace redirectWhenMissing in dashboard

ad3590a

Replace redirectWhenMissing in discover

d8ff50c

Merge remote-tracking branch 'upstream/master' into shim/redirect_whe…

80177fc

…n_missing # Conflicts: # src/legacy/core_plugins/kibana/public/discover/np_ready/angular/discover.js # src/legacy/core_plugins/kibana/public/visualize/np_ready/legacy_app.js

Remove redirect in monitoring

0bdeb07

sulemanof requested review from flash1293 and kertal March 11, 2020 10:01

Remove extra import

1082371

sulemanof marked this pull request as ready for review March 11, 2020 10:39

sulemanof requested a review from a team March 11, 2020 10:39

sulemanof requested a review from a team as a code owner March 11, 2020 10:39

sulemanof requested a review from a team March 11, 2020 10:39

sulemanof commented Mar 11, 2020

View reviewed changes

src/legacy/core_plugins/kibana/public/dashboard/np_ready/legacy_app.js Show resolved Hide resolved

sulemanof added Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.7.0 v8.0.0 labels Mar 11, 2020

sulemanof mentioned this pull request Mar 11, 2020

[NP] Cutover ensureDefaultIndexPattern to kibana_utils #59895

Merged

7 tasks

Merge branch 'master' into shim/redirect_when_missing

dd752ce

igoristic approved these changes Mar 11, 2020

View reviewed changes

flash1293 reviewed Mar 11, 2020

View reviewed changes

src/plugins/kibana_utils/public/history/redirect_when_missing.tsx Outdated Show resolved Hide resolved

sulemanof added 3 commits March 12, 2020 10:41

Merge remote-tracking branch 'upstream/master' into shim/redirect_whe…

b46a44c

…n_missing

Move invalid vistype check into editor.js

2f8afe6

Merge branch 'shim/redirect_when_missing' of github.com:sulemanof/kib…

feb5af9

…ana into shim/redirect_when_missing

elasticmachine and others added 2 commits March 12, 2020 09:37

Merge branch 'master' into shim/redirect_when_missing

064b36e

Mock the history folder

e8f5cb4

Merge branch 'shim/redirect_when_missing' of github.com:sulemanof/kib…

1280ec0

…ana into shim/redirect_when_missing

flash1293 previously requested changes Mar 13, 2020

View reviewed changes

sulemanof added 5 commits March 16, 2020 10:05

Merge remote-tracking branch 'upstream/master' into shim/redirect_whe…

3c0bc16

…n_missing # Conflicts: # src/legacy/core_plugins/kibana/public/discover/kibana_services.ts # src/legacy/core_plugins/kibana/public/visualize/np_ready/editor/editor.js

Fix redirect when missing index or saved object

d261a0b

Move history to discover services

b51e97e

Use redirect to listing page

9b63f56

Merge remote-tracking branch 'upstream/master' into shim/redirect_whe…

b2bff24

…n_missing

kertal approved these changes Mar 17, 2020

View reviewed changes

kertal requested a review from flash1293 March 17, 2020 08:59

kertal mentioned this pull request Mar 17, 2020

Redirect to management on missing index pattern does not go away #59999

Closed

ppisljar approved these changes Mar 17, 2020

View reviewed changes

sulemanof merged commit eddbdc8 into elastic:master Mar 17, 2020

sulemanof deleted the shim/redirect_when_missing branch March 17, 2020 11:02

sulemanof mentioned this pull request Mar 17, 2020

[7.x] [NP] Get rid of usage redirectWhenMissing service (#59777) #60360

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NP] Get rid of usage redirectWhenMissing service#59777

[NP] Get rid of usage redirectWhenMissing service#59777
sulemanof merged 18 commits intoelastic:masterfrom
sulemanof:shim/redirect_when_missing

sulemanof commented Mar 10, 2020 •

edited

Loading

Uh oh!

Uh oh!

elasticmachine commented Mar 11, 2020

Uh oh!

sulemanof commented Mar 11, 2020

Uh oh!

igoristic left a comment

Uh oh!

Uh oh!

sulemanof commented Mar 12, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kertal left a comment

Uh oh!

kibanamachine commented Mar 17, 2020

Uh oh!

ppisljar left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

sulemanof commented Mar 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

Uh oh!

elasticmachine commented Mar 11, 2020

Uh oh!

sulemanof commented Mar 11, 2020

Uh oh!

igoristic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sulemanof commented Mar 12, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kertal left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Mar 17, 2020

💚 Build Succeeded

History

Uh oh!

ppisljar left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

sulemanof commented Mar 10, 2020 •

edited

Loading