Migrate dual validated range by kindsun · Pull Request #59689 · elastic/kibana

kindsun · 2020-03-09T18:07:58Z

Summary

Migrates dual validated range to NP and updates to TypeScript. Blocker for #59585

elasticmachine · 2020-03-09T18:08:05Z

Pinging @elastic/kibana-gis (Team:Geo)

kindsun · 2020-03-09T21:47:51Z

@elasticmachine merge upstream

…was missing

…alidated-range

kindsun · 2020-03-11T18:28:03Z

@elasticmachine merge upstream

src/plugins/kibana_react/public/validated_range/validated_dual_range.tsx

…alidated-range

…ldwell/kibana into np-migrate-dual-validated-range

src/plugins/kibana_react/public/validated_range/validated_dual_range.tsx

…alidated-range

nreese

Thanks for moving and migrating this component to TS.

lgtm with green CI
code review

streamich

AppArch changes LGTM, except the @ts-ignores.

src/plugins/kibana_react/public/validated_range/validated_dual_range.tsx

…alidated-range

…e on EuiDualRange & No good alternatives for spread syntax in TS components

kindsun · 2020-03-13T22:38:44Z

retest

kindsun · 2020-03-16T13:11:12Z

@elasticmachine merge upstream

…iggers a react browser warning and complicates using 'prevState' in getDerivedStateFromProps

kibanamachine · 2020-03-16T20:32:58Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 2e92b23

History

💔 Build #33411 failed 85b1887
💔 Build #33217 failed dabe3b9
💔 Build #33199 failed dabe3b9
💔 Build #33104 failed a51fc45
💚 Build #33065 succeeded 13f4d45

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Move validated range files to new NP location * Update refs in code * Clean up old validated range files * Change relative paths to 'kibana-react'. Some clean up * Change to relative paths * Fix i18n errors * i18n clean up. Export module explicitly * Change files over to TS to prevent build issue where validated range was missing * Clean up TS conversion * More clean up. Extend EuiRangeProps * Remove unneeded ts-ignore * Review feedback and test fixes * Change double to single quotes * min and max aren't always passed, make optional * Type updates * Review feedback. Set state to empty on init and add ignore comment * Review feedback * Add back in last 2 ts-ignores. Build fails without focusable attribute on EuiDualRange & No good alternatives for spread syntax in TS components * Rollback change to state init. Initializing state to null actually triggers a react browser warning and complicates using 'prevState' in getDerivedStateFromProps Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* Move validated range files to new NP location * Update refs in code * Clean up old validated range files * Change relative paths to 'kibana-react'. Some clean up * Change to relative paths * Fix i18n errors * i18n clean up. Export module explicitly * Change files over to TS to prevent build issue where validated range was missing * Clean up TS conversion * More clean up. Extend EuiRangeProps * Remove unneeded ts-ignore * Review feedback and test fixes * Change double to single quotes * min and max aren't always passed, make optional * Type updates * Review feedback. Set state to empty on init and add ignore comment * Review feedback * Add back in last 2 ts-ignores. Build fails without focusable attribute on EuiDualRange & No good alternatives for spread syntax in TS components * Rollback change to state init. Initializing state to null actually triggers a react browser warning and complicates using 'prevState' in getDerivedStateFromProps Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (30 commits) [TSVB] fix text color when using custom background color (elastic#60261) Fix import to timefilter from in TSVB (elastic#60296) [NP] Get rid of usage redirectWhenMissing service (elastic#59777) [SIEM] Fix Timeline footer styling (elastic#59587) [ML] Fixes to error handling for analytics jobs and file data viz (elastic#60249) Give better stack traces for Unhandled Promise Rejection warnings (elastic#60235) resolves elastic#58905 (elastic#60120) Added variables button for text fields in Pagerduty component. (elastic#60189) adds test that action vars are rendered for alert action parms (elastic#60310) Closes 59786 by removing the update toast (elastic#60172) [EPM] Packages list tabs (elastic#60167) Added message variables button for Webhook body form field (elastic#60174) Revert "adds new test (elastic#60064)" [Maps] move MapSavedObject type out of telemetry (elastic#60127) [Reporting] Fix error handling for job handler in route (elastic#60161) [Endpoint] TEST: verify alerts page header says 'Alerts' (elastic#60206) EMT-248: implement ack resource to accept event payload to acknowledge agent actions (elastic#60218) Migrate dual validated range (elastic#59689) Embeddable triggers (elastic#58440) [Endpoint] Sample data generator CLI script (elastic#59952) ...

Aaron Caldwell added 3 commits March 9, 2020 11:58

Move validated range files to new NP location

9713e71

Update refs in code

c53f20d

Clean up old validated range files

1cc4646

kindsun added blocker Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 Feature:NP Migration v7.7.0 labels Mar 9, 2020

Aaron Caldwell added 2 commits March 9, 2020 12:41

Change relative paths to 'kibana-react'. Some clean up

c4daf99

Change to relative paths

48d0eaa

elasticmachine and others added 8 commits March 9, 2020 17:47

Merge branch 'master' into np-migrate-dual-validated-range

14728d9

Fix i18n errors

6a5f8a9

i18n clean up. Export module explicitly

3c0cac4

Change files over to TS to prevent build issue where validated range …

8a5dd9d

…was missing

Merge remote-tracking branch 'upstream/master' into np-migrate-dual-v…

61d2c7d

…alidated-range

Clean up TS conversion

4c6f1b5

More clean up. Extend EuiRangeProps

90550b8

Merge remote-tracking branch 'upstream/master' into np-migrate-dual-v…

a761969

…alidated-range

kindsun marked this pull request as ready for review March 11, 2020 15:29

kindsun requested review from a team as code owners March 11, 2020 15:29

kindsun requested a review from nreese March 11, 2020 15:29

kindsun added the release_note:skip Skip the PR/issue when compiling release notes label Mar 11, 2020

Remove unneeded ts-ignore

18e05ae

Merge branch 'master' into np-migrate-dual-validated-range

c4961c2

kindsun mentioned this pull request Mar 11, 2020

[Maps][File upload] Migrate Maps embeddables to NP #58178

Closed

11 tasks

nreese reviewed Mar 11, 2020

View reviewed changes

Aaron Caldwell added 4 commits March 12, 2020 10:46

Merge remote-tracking branch 'upstream/master' into np-migrate-dual-v…

787d93a

…alidated-range

Merge branch 'np-migrate-dual-validated-range' of github.com:aaronjca…

f51f1d5

…ldwell/kibana into np-migrate-dual-validated-range

Change double to single quotes

66ab9d1

min and max aren't always passed, make optional

96ab294

kindsun requested a review from nreese March 12, 2020 19:53

nreese reviewed Mar 12, 2020

View reviewed changes

Aaron Caldwell added 2 commits March 12, 2020 15:53

Type updates

daa1361

Merge remote-tracking branch 'upstream/master' into np-migrate-dual-v…

2324691

…alidated-range

flash1293 mentioned this pull request Mar 13, 2020

Meta: Kibana app NP cutover #60097

Closed

69 tasks

Aaron Caldwell added 2 commits March 13, 2020 08:25

Merge remote-tracking branch 'upstream/master' into np-migrate-dual-v…

eafe4b9

…alidated-range

Review feedback. Set state to empty on init and add ignore comment

13f4d45

kindsun requested a review from nreese March 13, 2020 14:31

nreese approved these changes Mar 13, 2020

View reviewed changes

streamich approved these changes Mar 13, 2020

View reviewed changes

Review feedback

a51fc45

nreese reviewed Mar 13, 2020

View reviewed changes

src/plugins/kibana_react/public/validated_range/validated_dual_range.tsx Show resolved Hide resolved

Aaron Caldwell added 2 commits March 13, 2020 15:11

Merge remote-tracking branch 'upstream/master' into np-migrate-dual-v…

c5acf30

…alidated-range

Add back in last 2 ts-ignores. Build fails without focusable attribut…

dabe3b9

…e on EuiDualRange & No good alternatives for spread syntax in TS components

elasticmachine and others added 2 commits March 16, 2020 09:11

Merge branch 'master' into np-migrate-dual-validated-range

85b1887

Rollback change to state init. Initializing state to null actually tr…

2e92b23

…iggers a react browser warning and complicates using 'prevState' in getDerivedStateFromProps

kindsun merged commit c898e79 into elastic:master Mar 16, 2020

kindsun mentioned this pull request Mar 16, 2020

[7.x] Migrate dual validated range (#59689) #60312

Merged

Dosant mentioned this pull request Mar 17, 2020

Storybook breaks when importing from kibana-react #60356

Closed

thomasneirynck mentioned this pull request May 29, 2020

[Maps][File upload] Migrate Maps team apps to new platform #33514

Closed

26 tasks

Conversation

kindsun commented Mar 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

elasticmachine commented Mar 9, 2020

Uh oh!

kindsun commented Mar 9, 2020

Uh oh!

kindsun commented Mar 11, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nreese left a comment

Choose a reason for hiding this comment

Uh oh!

streamich left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kindsun commented Mar 13, 2020

Uh oh!

kindsun commented Mar 16, 2020

Uh oh!

kibanamachine commented Mar 16, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kindsun commented Mar 9, 2020 •

edited

Loading