Added variables button for text fields in Pagerduty component.#60189
Merged
YulNaumenko merged 6 commits intoelastic:masterfrom Mar 17, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
pmuellr
approved these changes
Mar 14, 2020
Contributor
pmuellr
left a comment
There was a problem hiding this comment.
code LGTM; ui works as expected
...plugins/triggers_actions_ui/public/application/components/builtin_action_types/pagerduty.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
I tried this out with the index threshold alert, and there just happened to be interesting variables you could imagine using for all the pagerduty fields! :-)
|
…duty-fields-variables # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
mikecote
reviewed
Mar 16, 2020
Contributor
mikecote
left a comment
There was a problem hiding this comment.
Good progress! Just one bug and an unrelated question.
...plugins/triggers_actions_ui/public/application/components/builtin_action_types/pagerduty.tsx
Outdated
Show resolved
Hide resolved
...plugins/triggers_actions_ui/public/application/components/builtin_action_types/pagerduty.tsx
Outdated
Show resolved
Hide resolved
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
Mar 17, 2020
…ic#60189) * Added variables button for text fields in Pagerduty component. Fixed bugs mentioned in elastic#60067 * Fixed due to comments * fixed language check issue * Fixed tests * Fixed due to comments
YulNaumenko
added a commit
that referenced
this pull request
Mar 17, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 17, 2020
* master: (30 commits) [TSVB] fix text color when using custom background color (elastic#60261) Fix import to timefilter from in TSVB (elastic#60296) [NP] Get rid of usage redirectWhenMissing service (elastic#59777) [SIEM] Fix Timeline footer styling (elastic#59587) [ML] Fixes to error handling for analytics jobs and file data viz (elastic#60249) Give better stack traces for Unhandled Promise Rejection warnings (elastic#60235) resolves elastic#58905 (elastic#60120) Added variables button for text fields in Pagerduty component. (elastic#60189) adds test that action vars are rendered for alert action parms (elastic#60310) Closes 59786 by removing the update toast (elastic#60172) [EPM] Packages list tabs (elastic#60167) Added message variables button for Webhook body form field (elastic#60174) Revert "adds new test (elastic#60064)" [Maps] move MapSavedObject type out of telemetry (elastic#60127) [Reporting] Fix error handling for job handler in route (elastic#60161) [Endpoint] TEST: verify alerts page header says 'Alerts' (elastic#60206) EMT-248: implement ack resource to accept event payload to acknowledge agent actions (elastic#60218) Migrate dual validated range (elastic#59689) Embeddable triggers (elastic#58440) [Endpoint] Sample data generator CLI script (elastic#59952) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed bugs from #60067
Resolve #60067 and #58895
Delete any items that are not applicable to this PR.