[Reporting] Wholesale moves client to newest-platform by joelgriffith · Pull Request #58945 · elastic/kibana

joelgriffith · 2020-02-28T21:33:55Z

Summary

Moves all of our UI-facing architecture to newest platform.

TODO

Remove client code in legacy space
Remove injectedVars and other artifacts in the legacy server
Update Panel Actions to be new-platform
Fix and update any tests
Final smoke test (license changes, rejection messages, and any other regressions).

QA List

Biggest thing to check is license handling since all logic got ported to the client.
Want to ensure that all the prior functionality was there:
- Gold licenses should have PNG/PDF reporting working.
- Basic licenses should have just CSV exporting from Discover and Saved Searches.
- Open should have none of the above options.

…np-migration

x-pack/legacy/plugins/reporting/index.ts

x-pack/plugins/reporting/index.d.ts

joelgriffith · 2020-02-28T21:36:27Z

x-pack/plugins/reporting/public/components/report_listing.tsx

+  max_attempts: number;
+  csv_contains_formulas: boolean;
+}
+


The signature for this component has changed pretty drastically, as we now pass down license-observables, and other clients, through props.

joelgriffith · 2020-02-28T21:37:33Z

x-pack/plugins/reporting/public/plugin.tsx

  constructor(initializerContext: PluginInitializerContext) {}

-  public setup(core: CoreSetup) {}
+  public setup(


Core setup is here.

…np-migration

…me what you were meant to be.

tsullivan · 2020-03-06T19:23:10Z

x-pack/plugins/reporting/public/components/report_listing.tsx

-import { downloadReport } from '../lib/download_report';
-import { jobQueueClient, JobQueueEntry } from '../lib/job_queue_client';
+
+import { ToastsSetup, ApplicationStart } from '../../';


Is it still the case that we can't import these from src/core/public? IIRC that limitation was going on because this code was in legacy earlier

Yeah, this was to get around not being able to import in sub-modules. I'm not sure that restriction is lifted now, but I'll check.

I believe this can switch to import { ToastsSetup, ApplicationStart } from 'src/core/public';

x-pack/plugins/reporting/public/components/report_info_button.tsx

x-pack/plugins/reporting/public/components/report_listing.tsx

x-pack/plugins/reporting/kibana.json

…np-migration

joelgriffith · 2020-03-13T18:25:37Z

x-pack/legacy/plugins/reporting/types.d.ts

  };
 };

-export interface ReportingConfigOptions {


No longer needed since we don't export these to the client (and it's not used anywhere according to TS)

tsullivan

I found that a lot of the relative imports can be simplified if we import from another UI NP plugin.

tsullivan · 2020-03-13T20:04:23Z

x-pack/plugins/reporting/index.d.ts

  NotificationsStart,
 } from '../../../src/core/public';

+export { ToastsSetup, HttpSetup, ApplicationStart, IUiSettingsClient } from 'src/core/public';


Let's try to keep this file super lean, and have server things in reporting/server/types.d.ts and UI stuff in reporting/public/types.d.ts. But I don't think we need this export here anyway, because our UI libs are in NP and they can import from src/core/public

tsullivan · 2020-03-13T20:05:18Z

x-pack/plugins/reporting/public/components/report_listing.tsx

-import { downloadReport } from '../lib/download_report';
-import { jobQueueClient, JobQueueEntry } from '../lib/job_queue_client';
+
+import { ToastsSetup, ApplicationStart } from '../../';


I believe this can switch to import { ToastsSetup, ApplicationStart } from 'src/core/public';

tsullivan · 2020-03-13T20:05:36Z

x-pack/plugins/reporting/public/components/reporting_panel_content.tsx

-import * as reportingClient from '../lib/reporting_client';
+import { ReportingAPIClient } from '../lib/reporting_api_client';
+import { toMountPoint } from '../../../../../src/plugins/kibana_react/public';
+import { ToastsSetup } from '../../';


import { ToastsSetup } from 'src/core/public';

tsullivan · 2020-03-13T20:05:48Z

x-pack/plugins/reporting/public/components/screen_capture_panel_content.tsx

 import React, { Component, Fragment } from 'react';
 import { ReportingPanelContent } from './reporting_panel_content';
+import { ReportingAPIClient } from '../lib/reporting_api_client';
+import { ToastsSetup } from '../../';


import { ToastsSetup, ApplicationStart } from 'src/core/public';

tsullivan · 2020-03-13T20:06:03Z

x-pack/plugins/reporting/public/share_context_menu/register_csv_reporting.tsx

+import { checkLicense } from '../lib/license_check';
+import { LicensingPluginSetup } from '../../../licensing/public';
+import { ShareContext } from '../../../../../src/plugins/share/public';
+import { ToastsSetup } from '../..';


import { ToastsSetup, ApplicationStart } from 'src/core/public';

tsullivan · 2020-03-13T20:06:25Z

x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx

-import { ShareContext } from '../../../../../../src/plugins/share/public';
+import { LicensingPluginSetup } from '../../../licensing/public';
+import { ShareContext } from '../../../../../src/plugins/share/public';
+import { ToastsSetup, IUiSettingsClient } from '../../';


import { ToastsSetup, IUiSettingsClient } from 'src/core/public';

x-pack/plugins/reporting/public/lib/reporting_api_client.ts

tsullivan · 2020-03-13T20:20:46Z

x-pack/plugins/reporting/public/lib/stream_handler.test.ts

-import { HttpSetup, NotificationsStart } from '../../../../../src/core/public';
-import { SourceJob, JobSummary, HttpService } from '../../index.d';
-import { JobQueue } from './job_queue';
+import { NotificationsStart } from '../../../../../src/core/public';


I think import { NotificationsStart } from 'src/core/public'; would work.

tsullivan · 2020-03-13T20:21:44Z

x-pack/plugins/reporting/public/panel_actions/get_csv_panel_action.tsx

-  IncompatibleActionError,
-} from '../../../../../../src/plugins/ui_actions/public';
+import { CoreSetup } from '../../../../../src/core/public';
+import { Action, IncompatibleActionError } from '../../../../../src/plugins/ui_actions/public';


import { CoreSetup } from 'src/core/public'; import { Action, IncompatibleActionError } from 'src/plugins/ui_actions/public';

joelgriffith · 2020-03-13T21:36:23Z

Imports have been fixed, carry on

tsullivan

I'm afraid to say, it looks like the "Copy POST URL" buttons are not working. I tested in Discover and PDF / PNG for Visualize and Dashboard.

pgayvallet

LGTM

…np-migration

tsullivan

LGTM!
reviewed the code, tested all the licenses + expired trial license.

joelgriffith · 2020-03-17T15:41:50Z

@elasticmachine merge upstream

poffdeluxe

Looks a-ok from a Canvas perspective. That one jobCompletionNotification issue is something we'll have to look into but I don't think affects anything at the moment.

joelgriffith · 2020-03-17T16:08:50Z

GREEN BUILD, GREEN BUILD!

kibanamachine · 2020-03-17T17:32:06Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: a603278

History

💚 Build #33554 succeeded 9c2ecb7
💔 Build #33512 failed 210d627
💛 Build #33192 was flaky ce27fa1
💚 Build #33141 succeeded f20576f
💔 Build #33098 failed 61e86ab

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: (51 commits) do not update cell background if is label cell (elastic#60308) FTR configurable test users (elastic#52431) [Reporting] Wholesale moves client to newest-platform (elastic#58945) [Ingest] Support `show_user` package registry flag (elastic#60338) [SIEM] Adds 'Closes one signal when more than one opened signals are selected' test again (elastic#60380) [SIEM][Detections Engine] - Add rule markdown field to rule create, detail, and edit flows (elastic#60108) [Fleet] Add config revision to fleet agents (elastic#60292) Allow kbn-config-schema to ignore unknown keys (elastic#59560) [ML] Functional tests - disable df analytics clone tests skip flaky suite (elastic#58643) (elastic#58991) [FTR] Add support for --include and --exclude files via tags (elastic#60123) [SIEM] Fix link on overview page (elastic#60348) skip flaky test (elastic#60369) [Endpoint] Adds take action dropdown and tests to alert details flyout (elastic#59242) [Lens] Simplify state management from visualization (elastic#58279) Changing default type to start and allowing it to be configured by the event category (elastic#60323) [ML] Adds the class_assignment_objective to classification (elastic#60358) [TSVB] fix text color when using custom background color (elastic#60261) Fix import to timefilter from in TSVB (elastic#60296) [NP] Get rid of usage redirectWhenMissing service (elastic#59777) ...

* alerting/view-in-app: (53 commits) fixed typo handle optional alerting plugin do not update cell background if is label cell (elastic#60308) FTR configurable test users (elastic#52431) [Reporting] Wholesale moves client to newest-platform (elastic#58945) [Ingest] Support `show_user` package registry flag (elastic#60338) [SIEM] Adds 'Closes one signal when more than one opened signals are selected' test again (elastic#60380) [SIEM][Detections Engine] - Add rule markdown field to rule create, detail, and edit flows (elastic#60108) [Fleet] Add config revision to fleet agents (elastic#60292) Allow kbn-config-schema to ignore unknown keys (elastic#59560) [ML] Functional tests - disable df analytics clone tests skip flaky suite (elastic#58643) (elastic#58991) [FTR] Add support for --include and --exclude files via tags (elastic#60123) [SIEM] Fix link on overview page (elastic#60348) skip flaky test (elastic#60369) [Endpoint] Adds take action dropdown and tests to alert details flyout (elastic#59242) [Lens] Simplify state management from visualization (elastic#58279) Changing default type to start and allowing it to be configured by the event category (elastic#60323) [ML] Adds the class_assignment_objective to classification (elastic#60358) [TSVB] fix text color when using custom background color (elastic#60261) ...

joelgriffith · 2020-03-17T19:51:01Z

7.x PR: #60437

kibanamachine · 2020-03-18T17:48:44Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

* Move over to new plugin space, working implementation * Fixing tests for report_listing snapshots * WIP: Fixing react-component tests * Fixing report_info_button tests * Fixing download linksies * WIP: Final working implementation * Fixing attachAction API + API URLs * Let the past die. Kill it if you have to. That’s the only way to become what you were meant to be. * Fixing stream-client for new platform APIs * Fixing types and tests * Fix broken mock * Adds back in warnings to report info button * kibana.json line-breaks on required plugins * Fixing broked snapshots * Fix license checks in client-side components * Adding back in warnings to report_listing component * Fix danglig unused import * Adds license checks for basic to our csv panel action * Fixes issues from prior fork * Move relative pathing to absolute * Fix POST URL copying as we've moved from static methods * Fix layoutId props * Fixes types for layoutId Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Joel Griffith added 7 commits February 27, 2020 10:39

Move over to new plugin space, working implementation

ea2d736

Fixing tests for report_listing snapshots

83b2b96

WIP: Fixing react-component tests

5fd3a22

Merge remote-tracking branch 'upstream/master' into reporting/client-…

af0f877

…np-migration

Merge remote-tracking branch 'upstream/master' into reporting/client-…

fe429b9

…np-migration

Fixing report_info_button tests

c02b023

Fixing download linksies

ede19d4

joelgriffith commented Feb 28, 2020

View reviewed changes

x-pack/legacy/plugins/reporting/index.ts Show resolved Hide resolved

joelgriffith commented Feb 28, 2020

View reviewed changes

x-pack/plugins/reporting/index.d.ts Outdated Show resolved Hide resolved

joelgriffith commented Feb 28, 2020

View reviewed changes

tsullivan self-requested a review February 28, 2020 21:59

Joel Griffith added 3 commits March 2, 2020 09:59

Merge remote-tracking branch 'upstream/master' into reporting/client-…

1a9d6b1

…np-migration

WIP: Final working implementation

e1f4a31

Merge remote-tracking branch 'upstream/master' into reporting/client-…

0799652

…np-migration

tsullivan mentioned this pull request Mar 6, 2020

[Reporting] New Platform Migration #53898

Closed

19 tasks

Joel Griffith added 3 commits March 6, 2020 08:48

Merge remote-tracking branch 'upstream/master' into reporting/client-…

bae7445

…np-migration

Fixing attachAction API + API URLs

6322228

Let the past die. Kill it if you have to. That’s the only way to beco…

ca80be2

…me what you were meant to be.

tsullivan reviewed Mar 6, 2020

View reviewed changes

x-pack/plugins/reporting/public/components/report_info_button.tsx Show resolved Hide resolved

tsullivan reviewed Mar 6, 2020

View reviewed changes

x-pack/plugins/reporting/public/components/report_listing.tsx Show resolved Hide resolved

tsullivan reviewed Mar 6, 2020

View reviewed changes

x-pack/plugins/reporting/kibana.json Outdated Show resolved Hide resolved

Joel Griffith added 7 commits March 9, 2020 10:05

Merge remote-tracking branch 'upstream/master' into reporting/client-…

e4d4be7

…np-migration

Fixing stream-client for new platform APIs

ed82044

Fixing types and tests

de45fd9

Fix broken mock

257d9c6

Merge remote-tracking branch 'upstream/master' into reporting/client-…

9c96e79

…np-migration

Adds back in warnings to report info button

7dee2d0

kibana.json line-breaks on required plugins

a03734e

Joel Griffith added 2 commits March 13, 2020 11:22

Fixes issues from prior fork

a10e111

Merge remote-tracking branch 'upstream/master' into reporting/client-…

f20576f

…np-migration

joelgriffith commented Mar 13, 2020

View reviewed changes

joelgriffith requested a review from a team March 13, 2020 18:44

tsullivan requested changes Mar 13, 2020

View reviewed changes

Move relative pathing to absolute

ce27fa1

tsullivan requested changes Mar 14, 2020

View reviewed changes

pgayvallet approved these changes Mar 16, 2020

View reviewed changes

Joel Griffith added 4 commits March 16, 2020 09:26

Merge remote-tracking branch 'upstream/master' into reporting/client-…

6ad3dac

…np-migration

Fix POST URL copying as we've moved from static methods

210d627

Fix layoutId props

b002fd5

Fixes types for layoutId

9c2ecb7

tsullivan added the RFC/final-comment-period If no concerns are raised in 3 business days this RFC will be accepted label Mar 16, 2020

tsullivan approved these changes Mar 16, 2020

View reviewed changes

Merge branch 'master' into reporting/client-np-migration

a603278

poffdeluxe approved these changes Mar 17, 2020

View reviewed changes

joelgriffith merged commit 6b7731b into elastic:master Mar 17, 2020

joelgriffith mentioned this pull request Mar 17, 2020

[7.x] [Reporting] Wholesale moves client to newest-platform (#58945) #60437

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 18, 2020

joelgriffith removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 18, 2020

tsullivan mentioned this pull request May 26, 2020

[Reporting/UI] Remove Legacy Deps from Reporting Mgmt Views #52526

Closed

Conversation

joelgriffith commented Feb 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

TODO

QA List

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joelgriffith Mar 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tsullivan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joelgriffith commented Mar 13, 2020

Uh oh!

tsullivan left a comment

Choose a reason for hiding this comment

Uh oh!

pgayvallet left a comment

Choose a reason for hiding this comment

Uh oh!

tsullivan left a comment

Choose a reason for hiding this comment

Uh oh!

joelgriffith commented Mar 17, 2020

Uh oh!

poffdeluxe left a comment

Choose a reason for hiding this comment

Uh oh!

joelgriffith commented Mar 17, 2020

Uh oh!

kibanamachine commented Mar 17, 2020

💚 Build Succeeded

History

Uh oh!

joelgriffith commented Mar 17, 2020

Uh oh!

kibanamachine commented Mar 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

joelgriffith commented Feb 28, 2020 •

edited

Loading

joelgriffith Mar 13, 2020 •

edited

Loading