[Data Plugin]: Remove export * for common code from public/server index files#52821
Merged
lukeelmers merged 3 commits intoelastic:masterfrom Dec 12, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
e67a0c8 to
88f1543
Compare
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
lukeelmers
added a commit
that referenced
this pull request
Dec 12, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Dec 30, 2019
…aved-objects * upstream/master: (134 commits) [Dashboard] Add visualization from dasbhoard empty screen (elastic#52670) Print out agent debugging links during CI (elastic#52812) Add babel-plugin-styled-components to webpack config (elastic#52862) [Console] Fix load from remote (elastic#52814) Ensure APM agent config file path respects CWD (elastic#52880) [Watcher] Removed overwritten property (elastic#49998) [Data Plugin]: Remove `export *` for common code from public/server index files (elastic#52821) Hide stderr git output during APM agent configuration (elastic#52878) Polish migration.md (elastic#52764) Change ajax_stream to use new-line delimited JSON (elastic#52797) Stabilize dashboard save modal functional test (elastic#52761) [Discover] Place tooltip at bottom of filter button (elastic#52720) Disable/enable filter with click+shift on a filter badge (elastic#52751) [APM] Make client-side routes static (elastic#52574) [Maps] Get basic structure of NP client shim in place (elastic#52551) update chromedriver to 79 (elastic#52784) [DOCS] Adds example of assigning roles in Reporting (elastic#52757) Add instructions for setting up remote clusters needed for CCS and CCR (elastic#52796) [docs] max-old-space-size (elastic#52310) [Monitoring] Fix 7.5 cloud test issues (elastic#51781) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After multiple discussions, including a recent mention in #52374, we determined that as an app architecture team convention, we should be explicitly exporting static code & types from the
data/public/index.tsanddata/server/index.ts.This is important for two main reasons:
export *in the rest of the plugin with confidence that we won't be messing with the public API.This PR takes a first step toward achieving these goals in the
dataplugin by doing the following:export * from '../common', which is one area where we had a lot of mixed internal/public code, some of which was accidentally leaking into the public contract.commonwhich are used outside of the data plugin.utilsnamespace inside ofcommon/es_querywhich was introduced in Move @kbn/es-query into data plugin - es-query folder #50182. These could lead to confusion since the utils are specifically related toes_queryand are mostly internal, yet were being exported from the top-leveldata/publicanddata/index.esQuerynamespace which were only used internallyEventually the remaining
dataexports should also be cleaned up, as well as other plugins managed by the app arch team.