Skip to content

[Dashboard] Add visualization from dasbhoard empty screen#52670

Merged
majagrubic merged 5 commits intoelastic:masterfrom
majagrubic:switch-to-visualize-2
Dec 12, 2019
Merged

[Dashboard] Add visualization from dasbhoard empty screen#52670
majagrubic merged 5 commits intoelastic:masterfrom
majagrubic:switch-to-visualize-2

Conversation

@majagrubic
Copy link
Copy Markdown
Contributor

@majagrubic majagrubic commented Dec 10, 2019

Summary

Continuation of: #51939

add_vis

Includes the part of actually adding visualization from an empty dashboard screen. In case of Lens/Maps, it will navigate away from the dashboard - confirmed with Alona, we want to leave this behavior for now.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@majagrubic majagrubic requested a review from a team as a code owner December 10, 2019 19:16
@majagrubic majagrubic closed this Dec 10, 2019
@majagrubic majagrubic reopened this Dec 10, 2019
@majagrubic majagrubic added v7.6.0 Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// labels Dec 10, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Copy link
Copy Markdown
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's a start on what we need and even if we change the style or content of this panel, this 'Create new' button will be needed.

@majagrubic
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@majagrubic majagrubic merged commit c5bf708 into elastic:master Dec 12, 2019
@majagrubic majagrubic deleted the switch-to-visualize-2 branch December 12, 2019 16:07
majagrubic pushed a commit to majagrubic/kibana that referenced this pull request Dec 12, 2019
)

* [Dashboard] Add visualization from dasbhoard empty screen

* Fixing linting errors

* Fixing i18n error

* Fixing unit test that was causing typecheck failure
majagrubic pushed a commit that referenced this pull request Dec 16, 2019
…) (#52906)

* [Dashboard] Add visualization from dasbhoard empty screen (#52670)

* [Dashboard] Add visualization from dasbhoard empty screen

* Fixing linting errors

* Fixing i18n error

* Fixing unit test that was causing typecheck failure

* Fix linting error

* Fix linting error

* Removing Lens part
jloleysens added a commit to jloleysens/kibana that referenced this pull request Dec 30, 2019
…aved-objects

* upstream/master: (134 commits)
  [Dashboard] Add visualization from dasbhoard empty screen (elastic#52670)
  Print out agent debugging links during CI (elastic#52812)
  Add babel-plugin-styled-components to webpack config (elastic#52862)
  [Console] Fix load from remote (elastic#52814)
  Ensure APM agent config file path respects CWD (elastic#52880)
  [Watcher] Removed overwritten property (elastic#49998)
  [Data Plugin]: Remove `export *` for common code from public/server index files (elastic#52821)
  Hide stderr git output during APM agent configuration (elastic#52878)
  Polish migration.md (elastic#52764)
  Change ajax_stream to use new-line delimited JSON (elastic#52797)
  Stabilize dashboard save modal functional test (elastic#52761)
  [Discover] Place tooltip at bottom of filter button (elastic#52720)
  Disable/enable filter with click+shift on a filter badge (elastic#52751)
  [APM] Make client-side routes static (elastic#52574)
  [Maps] Get basic structure of NP client shim in place (elastic#52551)
  update chromedriver to 79 (elastic#52784)
  [DOCS] Adds example of assigning roles in Reporting (elastic#52757)
  Add instructions for setting up remote clusters needed for CCS and CCR (elastic#52796)
  [docs] max-old-space-size (elastic#52310)
  [Monitoring] Fix 7.5 cloud test issues (elastic#51781)
  ...
@KOTungseth KOTungseth mentioned this pull request Jan 23, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Dashboard Dashboard related features Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.6.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants