[Interpreter] Change ajax_stream to use new-line delimited JSON#52797
Merged
chrisdavies merged 1 commit intoelastic:masterfrom Dec 12, 2019
Merged
[Interpreter] Change ajax_stream to use new-line delimited JSON#52797chrisdavies merged 1 commit intoelastic:masterfrom
chrisdavies merged 1 commit intoelastic:masterfrom
Conversation
kobelb
approved these changes
Dec 11, 2019
Contributor
|
I'll take a look tomorrow. |
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
streamich
approved these changes
Dec 12, 2019
chrisdavies
added a commit
that referenced
this pull request
Dec 12, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Dec 30, 2019
…aved-objects * upstream/master: (134 commits) [Dashboard] Add visualization from dasbhoard empty screen (elastic#52670) Print out agent debugging links during CI (elastic#52812) Add babel-plugin-styled-components to webpack config (elastic#52862) [Console] Fix load from remote (elastic#52814) Ensure APM agent config file path respects CWD (elastic#52880) [Watcher] Removed overwritten property (elastic#49998) [Data Plugin]: Remove `export *` for common code from public/server index files (elastic#52821) Hide stderr git output during APM agent configuration (elastic#52878) Polish migration.md (elastic#52764) Change ajax_stream to use new-line delimited JSON (elastic#52797) Stabilize dashboard save modal functional test (elastic#52761) [Discover] Place tooltip at bottom of filter button (elastic#52720) Disable/enable filter with click+shift on a filter badge (elastic#52751) [APM] Make client-side routes static (elastic#52574) [Maps] Get basic structure of NP client shim in place (elastic#52551) update chromedriver to 79 (elastic#52784) [DOCS] Adds example of assigning roles in Reporting (elastic#52757) Add instructions for setting up remote clusters needed for CCS and CCR (elastic#52796) [docs] max-old-space-size (elastic#52310) [Monitoring] Fix 7.5 cloud test issues (elastic#51781) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interpreter was using a payload-length packing scheme for streaming responses. This was being returned as
text/plainwhich was causing some security flag to go off. @kobelb knows the details of that. But he also rightly pointed out that this would be simpler and more standards-compliant if we just used new-line delimited JSON.