[docs] max-old-space-size by jbudz · Pull Request #52310 · elastic/kibana

jbudz · 2019-12-05T16:26:02Z

Adds a memory configuration section to production docs.

Closes #9006

[skip ci]

elasticmachine · 2019-12-05T16:26:05Z

Pinging @elastic/kibana-docs (Team:Docs)

elasticmachine · 2019-12-05T16:26:06Z

Pinging @elastic/kibana-operations (Team:Operations)

docs/setup/production.asciidoc

elasticmachine · 2019-12-05T18:26:34Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 0364059

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

gchaps

LGTM

elasticmachine · 2019-12-05T19:49:37Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 0bb7782

elasticmachine · 2019-12-05T19:53:48Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: eafa6fb

spalger · 2019-12-05T20:13:17Z

@elasticmachine merge upstream

spalger · 2019-12-05T20:13:43Z

(added [skip ci] to the pr description and merged master to get rid of the CI errors)

tylersmalley · 2019-12-06T16:16:50Z

docs/setup/production.asciidoc

+[float]
+[[memory]]
+=== Memory
+Kibana has a default memory limit of 1.4 GB, and in most cases, we recommend leaving this unconfigured.  In some scenarios, such as running on containers with limited


While the max old space is generally 1.4GB, it is based on system information, like memory available. @mistic did a deep dive into this a while back and can comment.

ah right, good catch

@tylersmalley exactly. Nodejs calculates the default allocated heap according multiple variables, processor architecture, total available physical memory etc (the logic can be found here https://github.com/v8/v8/blob/master/src/heap/heap.cc#L227)

So in order to be able to specify what is our minimum required memory we need to proceed what we have been discussing of distribute kibana with an override NODE_OPTIONS for heap. So, at least for now, we should not specify that information on the docs

I added a clarifier, `default maximum memory limit. it's not very specific but I'm hoping it's good enough

docs/setup/production.asciidoc

tylersmalley · 2019-12-09T16:24:51Z

Also worth mentioning that in addition to the docs being built by CI, they also make a preview available which helps with reviewing http://kibana_52310.docs-preview.app.elstc.co/guide/en/kibana/master/production.html#memory

Co-Authored-By: Tyler Smalley <tylersmalley@me.com>

tylersmalley · 2019-12-10T21:44:53Z

docs/setup/production.asciidoc

+[[memory]]
+=== Memory
+Kibana has a default maximum memory limit of 1.4 GB, and in most cases, we recommend leaving this unconfigured.  In some scenarios, such large reporting jobs
+, it may make sense to tweak limits to meet more specific requirements.


If you could move the comment to the previous line it will remove the space before the comma.

tylersmalley

One small change, then LGTM

* [docs] max-old-space-size * Update docs/setup/production.asciidoc Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/setup/production.asciidoc Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com> * _max_ * Update docs/setup/production.asciidoc Co-Authored-By: Tyler Smalley <tylersmalley@me.com> * max example * move comma * Update production.asciidoc

…aved-objects * upstream/master: (134 commits) [Dashboard] Add visualization from dasbhoard empty screen (elastic#52670) Print out agent debugging links during CI (elastic#52812) Add babel-plugin-styled-components to webpack config (elastic#52862) [Console] Fix load from remote (elastic#52814) Ensure APM agent config file path respects CWD (elastic#52880) [Watcher] Removed overwritten property (elastic#49998) [Data Plugin]: Remove `export *` for common code from public/server index files (elastic#52821) Hide stderr git output during APM agent configuration (elastic#52878) Polish migration.md (elastic#52764) Change ajax_stream to use new-line delimited JSON (elastic#52797) Stabilize dashboard save modal functional test (elastic#52761) [Discover] Place tooltip at bottom of filter button (elastic#52720) Disable/enable filter with click+shift on a filter badge (elastic#52751) [APM] Make client-side routes static (elastic#52574) [Maps] Get basic structure of NP client shim in place (elastic#52551) update chromedriver to 79 (elastic#52784) [DOCS] Adds example of assigning roles in Reporting (elastic#52757) Add instructions for setting up remote clusters needed for CCS and CCR (elastic#52796) [docs] max-old-space-size (elastic#52310) [Monitoring] Fix 7.5 cloud test issues (elastic#51781) ...

[docs] max-old-space-size

0364059

jbudz added review Team:Docs Team:Operations Kibana-Operations Team labels Dec 5, 2019

jbudz added release_note:skip Skip the PR/issue when compiling release notes v7.0.2 v7.1.2 v7.2.2 v7.3.3 v7.4.3 v7.5.1 v7.6.0 v8.0.0 labels Dec 5, 2019

gchaps reviewed Dec 5, 2019

View reviewed changes

docs/setup/production.asciidoc Outdated Show resolved Hide resolved

docs/setup/production.asciidoc Outdated Show resolved Hide resolved

jbudz and others added 2 commits December 5, 2019 12:35

Update docs/setup/production.asciidoc

0bb7782

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

Update docs/setup/production.asciidoc

eafa6fb

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

gchaps approved these changes Dec 5, 2019

View reviewed changes

Merge branch 'master' into docs/mem

d4338d3

tylersmalley reviewed Dec 6, 2019

View reviewed changes

jbudz added 3 commits December 9, 2019 10:06

_max_

7865a44

Merge branch 'docs/mem' of github.com:jbudz/kibana into docs/mem

706723d

Merge branch 'master' into docs/mem

06abde1

tylersmalley requested changes Dec 9, 2019

View reviewed changes

docs/setup/production.asciidoc Outdated Show resolved Hide resolved

jbudz and others added 4 commits December 9, 2019 10:26

Update docs/setup/production.asciidoc

df5d91d

Co-Authored-By: Tyler Smalley <tylersmalley@me.com>

max example

8f60b6e

Merge branch 'docs/mem' of github.com:jbudz/kibana into docs/mem

3c6351d

Merge branch 'master' into docs/mem

2187c82

tylersmalley reviewed Dec 10, 2019

View reviewed changes

tylersmalley approved these changes Dec 10, 2019

View reviewed changes

jbudz added 2 commits December 11, 2019 10:17

move comma

d89e409

Merge branch 'master' into docs/mem

08e7d45

tylersmalley approved these changes Dec 11, 2019

View reviewed changes

Update production.asciidoc

027bad1

jbudz merged commit 6187643 into elastic:master Dec 11, 2019

Conversation

jbudz commented Dec 5, 2019 • edited by spalger Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Dec 5, 2019

Uh oh!

elasticmachine commented Dec 5, 2019

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Dec 5, 2019

💔 Build Failed

Uh oh!

gchaps left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Dec 5, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Dec 5, 2019

💔 Build Failed

Uh oh!

spalger commented Dec 5, 2019

Uh oh!

spalger commented Dec 5, 2019

Uh oh!

tylersmalley Dec 6, 2019

Choose a reason for hiding this comment

Uh oh!

jbudz Dec 6, 2019

Choose a reason for hiding this comment

Uh oh!

mistic Dec 7, 2019

Choose a reason for hiding this comment

Uh oh!

jbudz Dec 9, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tylersmalley commented Dec 9, 2019

Uh oh!

tylersmalley Dec 10, 2019

Choose a reason for hiding this comment

Uh oh!

tylersmalley left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jbudz commented Dec 5, 2019 •

edited by spalger

Loading