Skip to content

Removed overwritten property#49998

Merged
alisonelizabeth merged 6 commits intoelastic:masterfrom
pedroprado010:patch-3
Dec 12, 2019
Merged

Removed overwritten property#49998
alisonelizabeth merged 6 commits intoelastic:masterfrom
pedroprado010:patch-3

Conversation

@pedroprado010
Copy link
Copy Markdown
Contributor

Summary

First declaration of property index was overwritten.

Checklist

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

First declaration of property index was overwritten
@elasticmachine
Copy link
Copy Markdown
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Copy Markdown
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@legrego legrego added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// label Nov 21, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@alisonelizabeth
Copy link
Copy Markdown
Contributor

Hi @pedroprado010! Thanks for the contribution. Is there an existing issue open that's related to this change?

@pedroprado010
Copy link
Copy Markdown
Contributor Author

Hi @alisonelizabeth! I believe there's not.

@alisonelizabeth
Copy link
Copy Markdown
Contributor

@elasticmachine merge upstream

@alisonelizabeth
Copy link
Copy Markdown
Contributor

jenkins test this

@alisonelizabeth alisonelizabeth added release_note:skip Skip the PR/issue when compiling release notes Feature:Watcher v7.6.0 v8.0.0 labels Dec 9, 2019
@alisonelizabeth alisonelizabeth self-requested a review December 9, 2019 21:38
Copy link
Copy Markdown
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. Change LGTM. Thanks for the contribution @pedroprado010!

I will handle merging and backporting the PR once CI is green.

@alisonelizabeth
Copy link
Copy Markdown
Contributor

@elasticmachine merge upstream

@alisonelizabeth
Copy link
Copy Markdown
Contributor

@elasticmachine merge upstream

@mistic
Copy link
Copy Markdown
Contributor

mistic commented Dec 12, 2019

@elasticmachine merge upstream

@mistic
Copy link
Copy Markdown
Contributor

mistic commented Dec 12, 2019

jenkins test this

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alisonelizabeth
Copy link
Copy Markdown
Contributor

@pedroprado010 this PR has been merged and backported. Thanks again for your help on this!

jloleysens added a commit to jloleysens/kibana that referenced this pull request Dec 30, 2019
…aved-objects

* upstream/master: (134 commits)
  [Dashboard] Add visualization from dasbhoard empty screen (elastic#52670)
  Print out agent debugging links during CI (elastic#52812)
  Add babel-plugin-styled-components to webpack config (elastic#52862)
  [Console] Fix load from remote (elastic#52814)
  Ensure APM agent config file path respects CWD (elastic#52880)
  [Watcher] Removed overwritten property (elastic#49998)
  [Data Plugin]: Remove `export *` for common code from public/server index files (elastic#52821)
  Hide stderr git output during APM agent configuration (elastic#52878)
  Polish migration.md (elastic#52764)
  Change ajax_stream to use new-line delimited JSON (elastic#52797)
  Stabilize dashboard save modal functional test (elastic#52761)
  [Discover] Place tooltip at bottom of filter button (elastic#52720)
  Disable/enable filter with click+shift on a filter badge (elastic#52751)
  [APM] Make client-side routes static (elastic#52574)
  [Maps] Get basic structure of NP client shim in place (elastic#52551)
  update chromedriver to 79 (elastic#52784)
  [DOCS] Adds example of assigning roles in Reporting (elastic#52757)
  Add instructions for setting up remote clusters needed for CCS and CCR (elastic#52796)
  [docs] max-old-space-size (elastic#52310)
  [Monitoring] Fix 7.5 cloud test issues (elastic#51781)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Watcher release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.6.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants