Skip to content

[Fleet] Fix get one agent when feature flag disabled#188953

Merged
nchaulet merged 1 commit intoelastic:mainfrom
nchaulet:fix-get-agent-non-space-aware
Jul 23, 2024
Merged

[Fleet] Fix get one agent when feature flag disabled#188953
nchaulet merged 1 commit intoelastic:mainfrom
nchaulet:fix-get-agent-non-space-aware

Conversation

@nchaulet
Copy link
Copy Markdown
Member

@nchaulet nchaulet commented Jul 23, 2024 •
edited by kibanamachine
Loading

Summary

@jillguyonnet found an issue here

We should not check agent namespaces when the useSpaceAwareness feature flag is not enabled, that PR address that.

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team backport:prev-minor labels Jul 23, 2024
@nchaulet nchaulet self-assigned this Jul 23, 2024
@nchaulet nchaulet requested a review from a team as a code owner July 23, 2024 14:44
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 23, 2024

Pinging @elastic/fleet (Team:Fleet)

@obltmachine
Copy link
Copy Markdown

obltmachine commented Jul 23, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@nchaulet nchaulet enabled auto-merge (squash) July 23, 2024 14:58
@nchaulet nchaulet merged commit ebdc6be into elastic:main Jul 23, 2024
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jul 23, 2024

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 23, 2024
@nchaulet
[Fleet] Fix get one agent when feature flag disabled (elastic#188953)
7df9d43 
(cherry picked from commit ebdc6be)
@kibanamachine kibanamachine mentioned this pull request Jul 23, 2024
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 23, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 23, 2024
@kibanamachine @nchaulet
[8.15] [Fleet] Fix get one agent when feature flag disabled (#188953) (…
ab83a81 
…#188981)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Fleet] Fix get one agent when feature flag disabled
(#188953)](#188953)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nicolas
Chaulet","email":"nicolas.chaulet@elastic.co"},"sourceCommit":{"committedDate":"2024-07-23T16:15:31Z","message":"[Fleet]
Fix get one agent when feature flag disabled
(#188953)","sha":"ebdc6be5d2e42b4bb66dcedaaa22a7642c9edd9d","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","v8.16.0"],"title":"[Fleet]
Fix get one agent when feature flag
disabled","number":188953,"url":"https://github.com/elastic/kibana/pull/188953","mergeCommit":{"message":"[Fleet]
Fix get one agent when feature flag disabled
(#188953)","sha":"ebdc6be5d2e42b4bb66dcedaaa22a7642c9edd9d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188953","number":188953,"mergeCommit":{"message":"[Fleet]
Fix get one agent when feature flag disabled
(#188953)","sha":"ebdc6be5d2e42b4bb66dcedaaa22a7642c9edd9d"}}]}]
BACKPORT-->

Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
TinLe added a commit to TinLe/kibana that referenced this pull request Jul 30, 2024
@TinLe
Merge branch 'master' into dependabot/npm_and_yarn/express-4.19.2
df656a6 
* master: (3487 commits)
  `BedrockChat` & `GeminiChat` (elastic#186809)
  [ResponseOps] log error when ES Query rules find docs out of time range (elastic#186332)
  skip flaky suite (elastic#188997)
  [Security solution][Alert Details] Enable preview feature flag and cypress tests (elastic#188580)
  [EuiProviders] Warn Developer if EuiProvider is missing (elastic#184608)
  [Security Solution ] Fixes Timeline infinite loading bug (elastic#188943)
  Improve SearchSource SearchRequest type (elastic#186862)
  Deprecate Search Sessions config (elastic#188037)
  [Synthetics] Add missing monitorType and tag info in cards !! (elastic#188824)
  [Console Monaco] Resolve uncaught error from tokenizer (elastic#188746)
  [Data Forge] Add `service.logs` dataset as a  data stream (elastic#188786)
  [Console] Fix failing bulk requests (elastic#188552)
  Update dependency terser to ^5.31.2 (main) (elastic#188528)
  [APM][ECO] Telemetry (elastic#188627)
  [Fleet] Fix uninstall package validation accross space (elastic#188749)
  Update warning on `xpack.fleet.enableExperimental` (elastic#188917)
  [DOCS][Cases] Automate more screenshots for cases (elastic#188697)
  [Fleet] Fix get one agent when feature flag disabled (elastic#188953)
  chore(investigate): Add investigate-app plugin from poc (elastic#188122)
  [Monaco Editor] Add Search functionality (elastic#188337)
  ...
TinLe added a commit to TinLe/kibana that referenced this pull request Jul 30, 2024
@TinLe
Merge branch 'master' into dependabot/npm_and_yarn/pdfjs-dist-4.2.67
8bec40b 
* master: (2400 commits)
  `BedrockChat` & `GeminiChat` (elastic#186809)
  [ResponseOps] log error when ES Query rules find docs out of time range (elastic#186332)
  skip flaky suite (elastic#188997)
  [Security solution][Alert Details] Enable preview feature flag and cypress tests (elastic#188580)
  [EuiProviders] Warn Developer if EuiProvider is missing (elastic#184608)
  [Security Solution ] Fixes Timeline infinite loading bug (elastic#188943)
  Improve SearchSource SearchRequest type (elastic#186862)
  Deprecate Search Sessions config (elastic#188037)
  [Synthetics] Add missing monitorType and tag info in cards !! (elastic#188824)
  [Console Monaco] Resolve uncaught error from tokenizer (elastic#188746)
  [Data Forge] Add `service.logs` dataset as a  data stream (elastic#188786)
  [Console] Fix failing bulk requests (elastic#188552)
  Update dependency terser to ^5.31.2 (main) (elastic#188528)
  [APM][ECO] Telemetry (elastic#188627)
  [Fleet] Fix uninstall package validation accross space (elastic#188749)
  Update warning on `xpack.fleet.enableExperimental` (elastic#188917)
  [DOCS][Cases] Automate more screenshots for cases (elastic#188697)
  [Fleet] Fix get one agent when feature flag disabled (elastic#188953)
  chore(investigate): Add investigate-app plugin from poc (elastic#188122)
  [Monaco Editor] Add Search functionality (elastic#188337)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jillguyonnet jillguyonnet jillguyonnet approved these changes

@juliaElastic juliaElastic juliaElastic approved these changes

Assignees

@nchaulet nchaulet

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.15.0 v8.16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nchaulet @elasticmachine @obltmachine @kibana-ci @kibanamachine @jillguyonnet @juliaElastic