[Security Solution ] Fixes Timeline infinite loading bug#188943
Merged
logeekal merged 3 commits intoelastic:mainfrom Jul 23, 2024
Merged
[Security Solution ] Fixes Timeline infinite loading bug#188943logeekal merged 3 commits intoelastic:mainfrom
logeekal merged 3 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
kqualters-elastic
approved these changes
Jul 23, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 23, 2024
) ## Summary handles elastic#188942 There was a hook which was causing additionall re-renders. Removed that. Timeline should be working fine. Below you can see that timeline works fine with multiple time-ranges. The original issue did not always occur consistently, only when there was a change in events fetched. https://github.com/user-attachments/assets/861e5501-f857-40bc-989e-a5a0e565585b (cherry picked from commit b098522)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 23, 2024
) (#188996) # Backport This will backport the following commits from `main` to `8.15`: - [[Security Solution ] Fixes Timeline infinite loading bug (#188943)](#188943) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2024-07-23T18:31:09Z","message":"[Security Solution ] Fixes Timeline infinite loading bug (#188943)\n\n## Summary\r\n\r\nhandles https://github.com/elastic/kibana/issues/188942\r\n\r\nThere was a hook which was causing additionall re-renders. Removed that.\r\nTimeline should be working fine. Below you can see that timeline works\r\nfine with multiple time-ranges. The original issue did not always occur\r\nconsistently, only when there was a change in events fetched.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/861e5501-f857-40bc-989e-a5a0e565585b","sha":"b0985227bab9b9345d5ac217a89ac659f30d4865","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting:Investigations","backport:prev-minor","v8.16.0"],"title":"[Security Solution ] Fixes Timeline infinite loading bug","number":188943,"url":"https://github.com/elastic/kibana/pull/188943","mergeCommit":{"message":"[Security Solution ] Fixes Timeline infinite loading bug (#188943)\n\n## Summary\r\n\r\nhandles https://github.com/elastic/kibana/issues/188942\r\n\r\nThere was a hook which was causing additionall re-renders. Removed that.\r\nTimeline should be working fine. Below you can see that timeline works\r\nfine with multiple time-ranges. The original issue did not always occur\r\nconsistently, only when there was a change in events fetched.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/861e5501-f857-40bc-989e-a5a0e565585b","sha":"b0985227bab9b9345d5ac217a89ac659f30d4865"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188943","number":188943,"mergeCommit":{"message":"[Security Solution ] Fixes Timeline infinite loading bug (#188943)\n\n## Summary\r\n\r\nhandles https://github.com/elastic/kibana/issues/188942\r\n\r\nThere was a hook which was causing additionall re-renders. Removed that.\r\nTimeline should be working fine. Below you can see that timeline works\r\nfine with multiple time-ranges. The original issue did not always occur\r\nconsistently, only when there was a change in events fetched.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/861e5501-f857-40bc-989e-a5a0e565585b","sha":"b0985227bab9b9345d5ac217a89ac659f30d4865"}}]}] BACKPORT--> Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
TinLe
added a commit
to TinLe/kibana
that referenced
this pull request
Jul 30, 2024
* master: (3487 commits) `BedrockChat` & `GeminiChat` (elastic#186809) [ResponseOps] log error when ES Query rules find docs out of time range (elastic#186332) skip flaky suite (elastic#188997) [Security solution][Alert Details] Enable preview feature flag and cypress tests (elastic#188580) [EuiProviders] Warn Developer if EuiProvider is missing (elastic#184608) [Security Solution ] Fixes Timeline infinite loading bug (elastic#188943) Improve SearchSource SearchRequest type (elastic#186862) Deprecate Search Sessions config (elastic#188037) [Synthetics] Add missing monitorType and tag info in cards !! (elastic#188824) [Console Monaco] Resolve uncaught error from tokenizer (elastic#188746) [Data Forge] Add `service.logs` dataset as a data stream (elastic#188786) [Console] Fix failing bulk requests (elastic#188552) Update dependency terser to ^5.31.2 (main) (elastic#188528) [APM][ECO] Telemetry (elastic#188627) [Fleet] Fix uninstall package validation accross space (elastic#188749) Update warning on `xpack.fleet.enableExperimental` (elastic#188917) [DOCS][Cases] Automate more screenshots for cases (elastic#188697) [Fleet] Fix get one agent when feature flag disabled (elastic#188953) chore(investigate): Add investigate-app plugin from poc (elastic#188122) [Monaco Editor] Add Search functionality (elastic#188337) ...
TinLe
added a commit
to TinLe/kibana
that referenced
this pull request
Jul 30, 2024
* master: (2400 commits) `BedrockChat` & `GeminiChat` (elastic#186809) [ResponseOps] log error when ES Query rules find docs out of time range (elastic#186332) skip flaky suite (elastic#188997) [Security solution][Alert Details] Enable preview feature flag and cypress tests (elastic#188580) [EuiProviders] Warn Developer if EuiProvider is missing (elastic#184608) [Security Solution ] Fixes Timeline infinite loading bug (elastic#188943) Improve SearchSource SearchRequest type (elastic#186862) Deprecate Search Sessions config (elastic#188037) [Synthetics] Add missing monitorType and tag info in cards !! (elastic#188824) [Console Monaco] Resolve uncaught error from tokenizer (elastic#188746) [Data Forge] Add `service.logs` dataset as a data stream (elastic#188786) [Console] Fix failing bulk requests (elastic#188552) Update dependency terser to ^5.31.2 (main) (elastic#188528) [APM][ECO] Telemetry (elastic#188627) [Fleet] Fix uninstall package validation accross space (elastic#188749) Update warning on `xpack.fleet.enableExperimental` (elastic#188917) [DOCS][Cases] Automate more screenshots for cases (elastic#188697) [Fleet] Fix get one agent when feature flag disabled (elastic#188953) chore(investigate): Add investigate-app plugin from poc (elastic#188122) [Monaco Editor] Add Search functionality (elastic#188337) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handles #188942
There was a hook which was causing additionall re-renders. Removed that. Timeline should be working fine. Below you can see that timeline works fine with multiple time-ranges. The original issue did not always occur consistently, only when there was a change in events fetched.
timeline_inifinite_loading_bug_solution.mp4