Skip to content

[Security Solution ] Fixes Timeline infinite loading bug#188943

Merged
logeekal merged 3 commits intoelastic:mainfrom
logeekal:fix/timeline_notes_infinite_loop
Jul 23, 2024
Merged

[Security Solution ] Fixes Timeline infinite loading bug#188943
logeekal merged 3 commits intoelastic:mainfrom
logeekal:fix/timeline_notes_infinite_loop

Conversation

@logeekal
Copy link
Copy Markdown
Contributor

@logeekal logeekal commented Jul 23, 2024

Summary

handles #188942

There was a hook which was causing additionall re-renders. Removed that. Timeline should be working fine. Below you can see that timeline works fine with multiple time-ranges. The original issue did not always occur consistently, only when there was a change in events fetched.

timeline_inifinite_loading_bug_solution.mp4

@logeekal logeekal added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team backport:prev-minor labels Jul 23, 2024
@logeekal logeekal requested a review from a team as a code owner July 23, 2024 13:21
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@logeekal logeekal enabled auto-merge (squash) July 23, 2024 18:05
@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #97 / Screenshots - serverless security UI response ops docs security cases security case settings case settings screenshot

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 17.3MB 17.3MB +130.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@logeekal logeekal merged commit b098522 into elastic:main Jul 23, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 23, 2024
)

## Summary

handles elastic#188942

There was a hook which was causing additionall re-renders. Removed that.
Timeline should be working fine. Below you can see that timeline works
fine with multiple time-ranges. The original issue did not always occur
consistently, only when there was a change in events fetched.

https://github.com/user-attachments/assets/861e5501-f857-40bc-989e-a5a0e565585b
(cherry picked from commit b098522)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 23, 2024
) (#188996)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Security Solution ] Fixes Timeline infinite loading bug
(#188943)](#188943)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jatin
Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2024-07-23T18:31:09Z","message":"[Security
Solution ] Fixes Timeline infinite loading bug (#188943)\n\n##
Summary\r\n\r\nhandles
https://github.com/elastic/kibana/issues/188942\r\n\r\nThere was a hook
which was causing additionall re-renders. Removed that.\r\nTimeline
should be working fine. Below you can see that timeline works\r\nfine
with multiple time-ranges. The original issue did not always
occur\r\nconsistently, only when there was a change in events
fetched.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/861e5501-f857-40bc-989e-a5a0e565585b","sha":"b0985227bab9b9345d5ac217a89ac659f30d4865","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting:Investigations","backport:prev-minor","v8.16.0"],"title":"[Security
Solution ] Fixes Timeline infinite loading
bug","number":188943,"url":"https://github.com/elastic/kibana/pull/188943","mergeCommit":{"message":"[Security
Solution ] Fixes Timeline infinite loading bug (#188943)\n\n##
Summary\r\n\r\nhandles
https://github.com/elastic/kibana/issues/188942\r\n\r\nThere was a hook
which was causing additionall re-renders. Removed that.\r\nTimeline
should be working fine. Below you can see that timeline works\r\nfine
with multiple time-ranges. The original issue did not always
occur\r\nconsistently, only when there was a change in events
fetched.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/861e5501-f857-40bc-989e-a5a0e565585b","sha":"b0985227bab9b9345d5ac217a89ac659f30d4865"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188943","number":188943,"mergeCommit":{"message":"[Security
Solution ] Fixes Timeline infinite loading bug (#188943)\n\n##
Summary\r\n\r\nhandles
https://github.com/elastic/kibana/issues/188942\r\n\r\nThere was a hook
which was causing additionall re-renders. Removed that.\r\nTimeline
should be working fine. Below you can see that timeline works\r\nfine
with multiple time-ranges. The original issue did not always
occur\r\nconsistently, only when there was a change in events
fetched.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/861e5501-f857-40bc-989e-a5a0e565585b","sha":"b0985227bab9b9345d5ac217a89ac659f30d4865"}}]}]
BACKPORT-->

Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
TinLe added a commit to TinLe/kibana that referenced this pull request Jul 30, 2024
* master: (3487 commits)
  `BedrockChat` & `GeminiChat` (elastic#186809)
  [ResponseOps] log error when ES Query rules find docs out of time range (elastic#186332)
  skip flaky suite (elastic#188997)
  [Security solution][Alert Details] Enable preview feature flag and cypress tests (elastic#188580)
  [EuiProviders] Warn Developer if EuiProvider is missing (elastic#184608)
  [Security Solution ] Fixes Timeline infinite loading bug (elastic#188943)
  Improve SearchSource SearchRequest type (elastic#186862)
  Deprecate Search Sessions config (elastic#188037)
  [Synthetics] Add missing monitorType and tag info in cards !! (elastic#188824)
  [Console Monaco] Resolve uncaught error from tokenizer (elastic#188746)
  [Data Forge] Add `service.logs` dataset as a  data stream (elastic#188786)
  [Console] Fix failing bulk requests (elastic#188552)
  Update dependency terser to ^5.31.2 (main) (elastic#188528)
  [APM][ECO] Telemetry (elastic#188627)
  [Fleet] Fix uninstall package validation accross space (elastic#188749)
  Update warning on `xpack.fleet.enableExperimental` (elastic#188917)
  [DOCS][Cases] Automate more screenshots for cases (elastic#188697)
  [Fleet] Fix get one agent when feature flag disabled (elastic#188953)
  chore(investigate): Add investigate-app plugin from poc (elastic#188122)
  [Monaco Editor] Add Search functionality (elastic#188337)
  ...
TinLe added a commit to TinLe/kibana that referenced this pull request Jul 30, 2024
* master: (2400 commits)
  `BedrockChat` & `GeminiChat` (elastic#186809)
  [ResponseOps] log error when ES Query rules find docs out of time range (elastic#186332)
  skip flaky suite (elastic#188997)
  [Security solution][Alert Details] Enable preview feature flag and cypress tests (elastic#188580)
  [EuiProviders] Warn Developer if EuiProvider is missing (elastic#184608)
  [Security Solution ] Fixes Timeline infinite loading bug (elastic#188943)
  Improve SearchSource SearchRequest type (elastic#186862)
  Deprecate Search Sessions config (elastic#188037)
  [Synthetics] Add missing monitorType and tag info in cards !! (elastic#188824)
  [Console Monaco] Resolve uncaught error from tokenizer (elastic#188746)
  [Data Forge] Add `service.logs` dataset as a  data stream (elastic#188786)
  [Console] Fix failing bulk requests (elastic#188552)
  Update dependency terser to ^5.31.2 (main) (elastic#188528)
  [APM][ECO] Telemetry (elastic#188627)
  [Fleet] Fix uninstall package validation accross space (elastic#188749)
  Update warning on `xpack.fleet.enableExperimental` (elastic#188917)
  [DOCS][Cases] Automate more screenshots for cases (elastic#188697)
  [Fleet] Fix get one agent when feature flag disabled (elastic#188953)
  chore(investigate): Add investigate-app plugin from poc (elastic#188122)
  [Monaco Editor] Add Search functionality (elastic#188337)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v8.15.0 v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants