Skip to content

[Console] Fix failing bulk requests#188552

Merged
ElenaStoeva merged 3 commits intoelastic:mainfrom
ElenaStoeva:console/fix-failing-bulk-requests
Jul 23, 2024
Merged

[Console] Fix failing bulk requests#188552
ElenaStoeva merged 3 commits intoelastic:mainfrom
ElenaStoeva:console/fix-failing-bulk-requests

Conversation

@ElenaStoeva
Copy link
Copy Markdown
Contributor

@ElenaStoeva ElenaStoeva commented Jul 17, 2024 •
edited
Loading

Fixes #186633

Summary

This PR fixes the failing Bulk requests in Console Monaco and in Console Ace when they are indented. The reason for the failures is that, when the request body contains multiple data objects, ES accepts it only if each data object is in a single line.

How to test:
Test in both Console with Monaco and old Console (by using the console.dev.enableMonaco: false setting in config/kibana.dev.yml) by sending bulk requests as well as regular requests. Try with formatted and unformatted requests. Also try sending multiple requests at once.

Screen.Recording.2024-07-17.at.16.46.31.mov

Some bulk requests to test with:

PUT /library/_bulk?refresh
{"index":{"_id":"Leviathan Wakes"}}
{"name":"Leviathan Wakes","author":"James S.A. Corey","release_date":"2011-06-02","page_count":561}
{"index":{"_id":"Hyperion"}}
{"name":"Hyperion","author":"Dan Simmons","release_date":"1989-05-26","page_count":482}
{"index":{"_id":"Dune"}}
{"name":"Dune","author":"Frank Herbert","release_date":"1965-06-01","page_count":604}

POST _bulk
{ "index" : { "_index" : "test", "_id" : "1" } }
{ "field1" : "value1" }
{ "delete" : { "_index" : "test", "_id" : "2" } }
{ "create" : { "_index" : "test", "_id" : "3" } }
{ "field1" : "value3" }
{ "update" : {"_id" : "1", "_index" : "test"} }
{ "doc" : {"field2" : "value2"} }

@ElenaStoeva ElenaStoeva added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes labels Jul 17, 2024
@ElenaStoeva ElenaStoeva self-assigned this Jul 17, 2024
@ElenaStoeva
Copy link
Copy Markdown
Contributor Author

ElenaStoeva commented Jul 17, 2024

/ci

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 17, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
console 457.0KB 457.1KB +36.0B

cc @ElenaStoeva

@ElenaStoeva ElenaStoeva marked this pull request as ready for review July 18, 2024 09:09
@ElenaStoeva ElenaStoeva requested a review from a team as a code owner July 18, 2024 09:09
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 18, 2024

Pinging @elastic/kibana-management (Team:Kibana Management)

yuliacech
yuliacech approved these changes Jul 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing the bulk requests, @ElenaStoeva!

@ElenaStoeva ElenaStoeva enabled auto-merge (squash) July 23, 2024 15:42
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jul 23, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
console 457.2KB 457.2KB +36.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ElenaStoeva

@ElenaStoeva ElenaStoeva merged commit 6203f9b into elastic:main Jul 23, 2024
@kibanamachine kibanamachine added v8.16.0 backport:skip This PR does not require backporting labels Jul 23, 2024
@ElenaStoeva ElenaStoeva mentioned this pull request Jul 26, 2024
Merged
TinLe added a commit to TinLe/kibana that referenced this pull request Jul 30, 2024
@TinLe
Merge branch 'master' into dependabot/npm_and_yarn/express-4.19.2
df656a6 
* master: (3487 commits)
  `BedrockChat` & `GeminiChat` (elastic#186809)
  [ResponseOps] log error when ES Query rules find docs out of time range (elastic#186332)
  skip flaky suite (elastic#188997)
  [Security solution][Alert Details] Enable preview feature flag and cypress tests (elastic#188580)
  [EuiProviders] Warn Developer if EuiProvider is missing (elastic#184608)
  [Security Solution ] Fixes Timeline infinite loading bug (elastic#188943)
  Improve SearchSource SearchRequest type (elastic#186862)
  Deprecate Search Sessions config (elastic#188037)
  [Synthetics] Add missing monitorType and tag info in cards !! (elastic#188824)
  [Console Monaco] Resolve uncaught error from tokenizer (elastic#188746)
  [Data Forge] Add `service.logs` dataset as a  data stream (elastic#188786)
  [Console] Fix failing bulk requests (elastic#188552)
  Update dependency terser to ^5.31.2 (main) (elastic#188528)
  [APM][ECO] Telemetry (elastic#188627)
  [Fleet] Fix uninstall package validation accross space (elastic#188749)
  Update warning on `xpack.fleet.enableExperimental` (elastic#188917)
  [DOCS][Cases] Automate more screenshots for cases (elastic#188697)
  [Fleet] Fix get one agent when feature flag disabled (elastic#188953)
  chore(investigate): Add investigate-app plugin from poc (elastic#188122)
  [Monaco Editor] Add Search functionality (elastic#188337)
  ...
TinLe added a commit to TinLe/kibana that referenced this pull request Jul 30, 2024
@TinLe
Merge branch 'master' into dependabot/npm_and_yarn/pdfjs-dist-4.2.67
8bec40b 
* master: (2400 commits)
  `BedrockChat` & `GeminiChat` (elastic#186809)
  [ResponseOps] log error when ES Query rules find docs out of time range (elastic#186332)
  skip flaky suite (elastic#188997)
  [Security solution][Alert Details] Enable preview feature flag and cypress tests (elastic#188580)
  [EuiProviders] Warn Developer if EuiProvider is missing (elastic#184608)
  [Security Solution ] Fixes Timeline infinite loading bug (elastic#188943)
  Improve SearchSource SearchRequest type (elastic#186862)
  Deprecate Search Sessions config (elastic#188037)
  [Synthetics] Add missing monitorType and tag info in cards !! (elastic#188824)
  [Console Monaco] Resolve uncaught error from tokenizer (elastic#188746)
  [Data Forge] Add `service.logs` dataset as a  data stream (elastic#188786)
  [Console] Fix failing bulk requests (elastic#188552)
  Update dependency terser to ^5.31.2 (main) (elastic#188528)
  [APM][ECO] Telemetry (elastic#188627)
  [Fleet] Fix uninstall package validation accross space (elastic#188749)
  Update warning on `xpack.fleet.enableExperimental` (elastic#188917)
  [DOCS][Cases] Automate more screenshots for cases (elastic#188697)
  [Fleet] Fix get one agent when feature flag disabled (elastic#188953)
  chore(investigate): Add investigate-app plugin from poc (elastic#188122)
  [Monaco Editor] Add Search functionality (elastic#188337)
  ...
ElenaStoeva added a commit that referenced this pull request Aug 2, 2024
@ElenaStoeva
[Console Monaco] Improve highlighting for status codes in multiple re…
495bb30 
…sponses (#189210)

Closes #184010

## Summary

This PR adds color badges for the status codes in the output panel when
there are multiple responses.


https://github.com/user-attachments/assets/be07b34d-7d04-4448-bf5d-b0d6fa36f2d7

**How to test:**
Send the following requests at once (try arranging them in different
orders):

Success badge 🟢 : `GET _search`

Client error (warning) badge 🟡 : `GET _test`

Server error (danger) badge 🔴 : 
```
PUT /library/_bulk?refresh
{"index":{"_id":"Leviathan Wakes"}}
{"name":"Leviathan Wakes","author":"James S.A. Corey","release_date":"2011-06-02","page_count":561}
```
^ This request should usually succeed and it was fixed in
#188552, but these changes aren't
in this branch yet so the request still fails. I couldn't find another
example that returns a 5** status code.


Note: AFAIK Es currently only uses 2**, 4**, and 5** status codes (200
OK, 201 Created, 202 Accepted, 204 No Content, 400 Bad Request, 401
Unauthorized, 403 Forbidden, 404 Not Found, 409 Conflict, 429 Too Many
Requests, 500 Internal Server Error, 503 Service Unavailable).
Practically only the success, warning, and danger badges will be used,
but added badges for the rest status codes in case they are added in Es.
@ElenaStoeva ElenaStoeva deleted the console/fix-failing-bulk-requests branch January 31, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yuliacech yuliacech yuliacech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ElenaStoeva ElenaStoeva

Labels

backport:skip This PR does not require backporting Feature:Console Dev Tools Console Feature release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v8.16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Console] Bulk request fails after indentations are applied

5 participants

@ElenaStoeva @elasticmachine @kibana-ci @yuliacech @kibanamachine