chore(investigate): Add investigate-app plugin from poc by kdelemme · Pull Request #188122 · elastic/kibana

kdelemme · 2024-07-11T15:23:52Z

Summary

Second PR that copy POC code from https://github.com/elastic/observability-dev/issues/3811

What's included:

investigate UI is hidden but accessible from URL
Notes, ESQL and Embeddables

What's removed:

AI assistant widget & plugin start dependencies not needed (ai, slo, apm)

…fix'

github-actions · 2024-07-11T15:24:09Z

A documentation preview will be available soon.

🔨 Buildkite builds
📚 HTML diff
📙 Preview page

Request a new doc build by commenting

Rebuild this PR: run docs-build
Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

obltmachine · 2024-07-11T15:24:10Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

dgieselaar · 2024-07-17T07:44:22Z

...s/observability_solution/investigate_app/public/components/add_from_library_button/index.tsx

+          savedObjectId: explicitInput.savedObjectId,
+          attributes,
+        });
+        return undefined as any; // { id: undefined };


I did this to hide the toast from the embeddable API, but it causes an error - we should talk to the Presentation team about this

ElenaStoeva · 2024-07-18T10:29:10Z

I think @elastic/kibana-management's review was requested by mistake (probably because of 88590b9) so I'm removing the review request.

dominiqueclarke · 2024-07-18T15:55:12Z

...vability_solution/investigate_app/public/components/investigate_search_bar/index.stories.tsx

+  ...defaultStory,
+  args: {
+    ...defaultStory.args,
+  },


Suggested change

...defaultStory,

args: {

...defaultStory.args,

},

...defaultStory,

mgiota · 2024-07-19T15:07:04Z

.../plugins/observability_solution/investigate_app/public/components/investigate_view/index.tsx

+      <EuiFlexItem grow={false} className={sideBarClassName}>
+        <EuiFlexGroup direction="column" gutterSize="m">
+          <EuiFlexItem className={gridContainerClassName} grow={false}>
+            <InvestigateWidgetGrid


I moved the InvestigateWidgetGrid to the sidebar, so that added notes appear on the sidebar.

TODO: Once we add the other widgets (ESQL, embeddable) in the UI, we need to rethink the InvestigateWidgetGrid, because now all widgets (included notes) appear in one common timeline. That's not what we want based on the mock up design. We will have one timeline on the left side of the page including ES|QL and embeddable widgets, and one on the right side including the notes

elasticmachine · 2024-07-19T15:11:49Z

💔 Build Failed

Buildkite Build
Commit: ca44b5d

Failed CI Steps

Quick Checks

History

💛 Build #222387 was flaky 0a45dc9
💔 Build #222374 failed d871bd0431c022527c413a529aa7c478aba9a63e
💔 Build #222323 failed a0b57272d822420e2e208b9791d9760c7a6e4d43
💔 Build #222210 failed 734af53

…fix'

mgiota · 2024-07-22T11:08:33Z

@elasticmachine merge upstream

TinaHeiligers

config and telemetry mappings LGTM

kibana-ci · 2024-07-22T19:02:20Z

💚 Build Succeeded

Buildkite Build
Commit: 485c695
Storybooks Preview
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-188122-485c69539463
Observability Deployment

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`investigateApp`	-	338	+338

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`investigateApp`	-	5	+5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.5MB	3.5MB	+121.0B
`investigateApp`	-	436.2KB	⚠️ +436.2KB
`observability`	420.1KB	420.2KB	+125.0B
`slo`	877.9KB	878.1KB	+125.0B
total			+436.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`investigateApp`	-	12.9KB	+12.9KB

Unknown metric groups

API count

id	before	after	diff
`investigateApp`	-	5	+5

async chunk count

id	before	after	diff
`investigateApp`	-	5	+5

ESLint disabled in files

id	before	after	diff
`investigateApp`	-	2	+2

ESLint disabled line counts

id	before	after	diff
`investigateApp`	-	2	+2

References to deprecated APIs

id	before	after	diff
`investigateApp`	-	1	+1

Total ESLint disabled count

id	before	after	diff
`investigateApp`	-	4	+4

History

💛 Build #222985 was flaky dfc8dfa
💔 Build #222947 failed ddda57b
💔 Build #222900 failed fa90ef82ad52381212441f002a5a5a493912dc3d
💔 Build #222878 failed ddda57b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

tonyghiani

deeplinks changes LGTM

* master: (3487 commits) `BedrockChat` & `GeminiChat` (elastic#186809) [ResponseOps] log error when ES Query rules find docs out of time range (elastic#186332) skip flaky suite (elastic#188997) [Security solution][Alert Details] Enable preview feature flag and cypress tests (elastic#188580) [EuiProviders] Warn Developer if EuiProvider is missing (elastic#184608) [Security Solution ] Fixes Timeline infinite loading bug (elastic#188943) Improve SearchSource SearchRequest type (elastic#186862) Deprecate Search Sessions config (elastic#188037) [Synthetics] Add missing monitorType and tag info in cards !! (elastic#188824) [Console Monaco] Resolve uncaught error from tokenizer (elastic#188746) [Data Forge] Add `service.logs` dataset as a data stream (elastic#188786) [Console] Fix failing bulk requests (elastic#188552) Update dependency terser to ^5.31.2 (main) (elastic#188528) [APM][ECO] Telemetry (elastic#188627) [Fleet] Fix uninstall package validation accross space (elastic#188749) Update warning on `xpack.fleet.enableExperimental` (elastic#188917) [DOCS][Cases] Automate more screenshots for cases (elastic#188697) [Fleet] Fix get one agent when feature flag disabled (elastic#188953) chore(investigate): Add investigate-app plugin from poc (elastic#188122) [Monaco Editor] Add Search functionality (elastic#188337) ...

* master: (2400 commits) `BedrockChat` & `GeminiChat` (elastic#186809) [ResponseOps] log error when ES Query rules find docs out of time range (elastic#186332) skip flaky suite (elastic#188997) [Security solution][Alert Details] Enable preview feature flag and cypress tests (elastic#188580) [EuiProviders] Warn Developer if EuiProvider is missing (elastic#184608) [Security Solution ] Fixes Timeline infinite loading bug (elastic#188943) Improve SearchSource SearchRequest type (elastic#186862) Deprecate Search Sessions config (elastic#188037) [Synthetics] Add missing monitorType and tag info in cards !! (elastic#188824) [Console Monaco] Resolve uncaught error from tokenizer (elastic#188746) [Data Forge] Add `service.logs` dataset as a data stream (elastic#188786) [Console] Fix failing bulk requests (elastic#188552) Update dependency terser to ^5.31.2 (main) (elastic#188528) [APM][ECO] Telemetry (elastic#188627) [Fleet] Fix uninstall package validation accross space (elastic#188749) Update warning on `xpack.fleet.enableExperimental` (elastic#188917) [DOCS][Cases] Automate more screenshots for cases (elastic#188697) [Fleet] Fix get one agent when feature flag disabled (elastic#188953) chore(investigate): Add investigate-app plugin from poc (elastic#188122) [Monaco Editor] Add Search functionality (elastic#188337) ...

kdelemme and others added 7 commits July 10, 2024 09:49

Copy investigate plugin changes from poc PR

3f92198

Change codeowner

d628ee4

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

37022d8

…fix'

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

3eaf5d7

Change codeowner

fe0ae81

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

d50432d

Merge branch 'main' into investigate-ui

229b616

mgiota self-requested a review July 15, 2024 09:39

kdelemme added 5 commits July 16, 2024 15:17

Merge branch 'main' into investigate-ui

5333a8c

cherry pick investigate_app changes from poc PR

992d2df

Apply change from latest commit in poc pr

b0ce435

Remove widgets from other plugins

1ae879a

remove observability dep

a58450e

kdelemme force-pushed the investigate-ui-2 branch from 4f3b528 to a58450e Compare July 16, 2024 14:03

kdelemme added 4 commits July 16, 2024 11:19

Remove ai assistant and unused dependencies

ba3e4a4

Merge branch 'main' into investigate-ui-2

0683d1b

Clean up sotrybook config

ea0a73a

use required bundle

03291a0

dgieselaar reviewed Jul 17, 2024

View reviewed changes

kdelemme marked this pull request as ready for review July 17, 2024 12:46

kdelemme requested review from a team as code owners July 17, 2024 12:46

kdelemme requested a review from a team July 17, 2024 12:46

kdelemme requested a review from a team as a code owner July 17, 2024 12:46

jbudz approved these changes Jul 17, 2024

View reviewed changes

botelastic bot added the ci:project-deploy-observability Create an Observability project label Jul 17, 2024

kdelemme added the release_note:skip Skip the PR/issue when compiling release notes label Jul 17, 2024

ElenaStoeva removed the request for review from a team July 18, 2024 10:29

mgiota mentioned this pull request Jul 18, 2024

Investigate UI cleanup #188639

Closed

kdelemme force-pushed the investigate-ui-2 branch from a0b5727 to d871bd0 Compare July 18, 2024 14:43

Fix ftr

0a45dc9

kdelemme force-pushed the investigate-ui-2 branch from d871bd0 to 0a45dc9 Compare July 18, 2024 15:04

kdelemme requested a review from a team as a code owner July 18, 2024 15:04

dominiqueclarke reviewed Jul 18, 2024

View reviewed changes

dominiqueclarke self-requested a review July 18, 2024 19:07

clean up the UI

ca44b5d

mgiota reviewed Jul 19, 2024

View reviewed changes

temp move notes widget on the left

9ae91bf

mgiota force-pushed the investigate-ui-2 branch from 8d67004 to 9ae91bf Compare July 19, 2024 19:53

kibanamachine and others added 2 commits July 19, 2024 20:05

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

9b04c3f

…fix'

fix types

66c6f55

Merge branch 'main' into investigate-ui-2

ddda57b

mgiota force-pushed the investigate-ui-2 branch from fa90ef8 to ddda57b Compare July 22, 2024 14:07

Fix type

dfc8dfa

TinaHeiligers approved these changes Jul 22, 2024

View reviewed changes

Merge branch 'main' into investigate-ui-2

485c695

tonyghiani approved these changes Jul 23, 2024

View reviewed changes

ryankeairns approved these changes Jul 23, 2024

View reviewed changes

neptunian approved these changes Jul 23, 2024

View reviewed changes

kdelemme merged commit aa67c80 into elastic:main Jul 23, 2024

kibanamachine added the backport:skip This PR does not require backporting label Jul 23, 2024

Conversation

kdelemme commented Jul 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

github-actions bot commented Jul 11, 2024

Uh oh!

obltmachine commented Jul 11, 2024

🤖 GitHub comments

Uh oh!

dgieselaar Jul 17, 2024

Choose a reason for hiding this comment

Uh oh!

ElenaStoeva commented Jul 18, 2024

Uh oh!

dominiqueclarke Jul 18, 2024

Choose a reason for hiding this comment

Uh oh!

mgiota Jul 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jul 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

History

Uh oh!

mgiota commented Jul 22, 2024

Uh oh!

TinaHeiligers left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Jul 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

async chunk count

ESLint disabled in files

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

History

Uh oh!

tonyghiani left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

kdelemme commented Jul 11, 2024 •

edited

Loading

mgiota Jul 19, 2024 •

edited

Loading

elasticmachine commented Jul 19, 2024 •

edited

Loading

kibana-ci commented Jul 22, 2024 •

edited

Loading