Skip to content

[Fleet] Fix uninstall package validation accross space#188749

Merged
nchaulet merged 8 commits intoelastic:mainfrom
nchaulet:fix-uninstall-accros-space
Jul 23, 2024
Merged

[Fleet] Fix uninstall package validation accross space#188749
nchaulet merged 8 commits intoelastic:mainfrom
nchaulet:fix-uninstall-accros-space

Conversation

@nchaulet
Copy link
Copy Markdown
Member

@nchaulet nchaulet commented Jul 19, 2024 •
edited
Loading

Summary

Resolve #187632

That PR fix the logic to disable the uninstall button to work with the space awareness initiative.

Move the logic to disable the uninstall package button server side has the client may not have the permissions to query package policies across all spaces.

GET /.../nginx/{version}?withMetadata=true
{
 "item": {},
 "metadata": {
    "has_policies": true
  }
}

Fix the server side validation to query package policies across all spaces.

How to test

Create multiple space, add a package policy and agents only in one, and try to uninstall a used package from a space where there is no package policy or agents => the UI should be disabled and the API should reject the request.

Work in progress

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 19, 2024
@nchaulet nchaulet self-assigned this Jul 19, 2024
@obltmachine
Copy link
Copy Markdown

obltmachine commented Jul 19, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@nchaulet
Copy link
Copy Markdown
Member Author

nchaulet commented Jul 19, 2024

/ci

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 19, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Fleet Cypress Tests #5 / Add Integration - Real API should install integration without policy
  • [job] [logs] Fleet Cypress Tests #5 / Add Integration - Real API should install integration without policy
  • [job] [logs] Fleet Cypress Tests #3 / Assets - Real API for integration with ML and transforms should install integration with ML module & transforms
  • [job] [logs] Fleet Cypress Tests #3 / Assets - Real API for integration with ML and transforms should install integration with ML module & transforms
  • [job] [logs] FTR Configs #10 / Cloud Security Posture Test adding Cloud Security Posture Integrations CNVM CNVM AWS On Add Agent modal there should be modal that has Cloud Formation details as well as button that redirects user to Cloud formation page on AWS upon clicking them
  • [job] [logs] FTR Configs #10 / Cloud Security Posture Test adding Cloud Security Posture Integrations CNVM CNVM AWS On Add Agent modal there should be modal that has Cloud Formation details as well as button that redirects user to Cloud formation page on AWS upon clicking them
  • [job] [logs] Fleet Cypress Tests #3 / Install unverified package assets should show force install modal if package is unverified
  • [job] [logs] Fleet Cypress Tests #3 / Install unverified package assets should show force install modal if package is unverified

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1228 1229 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.8MB 1.8MB +130.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
fleet 72 73 +1
Unknown metric groups

API count

id before after diff
fleet 1350 1351 +1

History

cc @nchaulet

@nchaulet
Copy link
Copy Markdown
Member Author

nchaulet commented Jul 19, 2024

/ci

@nchaulet nchaulet marked this pull request as ready for review July 19, 2024 19:02
@nchaulet nchaulet requested a review from a team as a code owner July 19, 2024 19:02
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 19, 2024

Pinging @elastic/fleet (Team:Fleet)

juliaElastic
juliaElastic approved these changes Jul 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nchaulet
Copy link
Copy Markdown
Member Author

nchaulet commented Jul 23, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jul 23, 2024

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1228 1229 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.8MB 1.8MB +133.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
fleet 72 73 +1
Unknown metric groups

API count

id before after diff
fleet 1350 1351 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit f675a8a into elastic:main Jul 23, 2024
@nchaulet nchaulet deleted the fix-uninstall-accros-space branch July 23, 2024 16:42
@kibanamachine kibanamachine added v8.16.0 backport:skip This PR does not require backporting labels Jul 23, 2024
TinLe added a commit to TinLe/kibana that referenced this pull request Jul 30, 2024
@TinLe
Merge branch 'master' into dependabot/npm_and_yarn/express-4.19.2
df656a6 
* master: (3487 commits)
  `BedrockChat` & `GeminiChat` (elastic#186809)
  [ResponseOps] log error when ES Query rules find docs out of time range (elastic#186332)
  skip flaky suite (elastic#188997)
  [Security solution][Alert Details] Enable preview feature flag and cypress tests (elastic#188580)
  [EuiProviders] Warn Developer if EuiProvider is missing (elastic#184608)
  [Security Solution ] Fixes Timeline infinite loading bug (elastic#188943)
  Improve SearchSource SearchRequest type (elastic#186862)
  Deprecate Search Sessions config (elastic#188037)
  [Synthetics] Add missing monitorType and tag info in cards !! (elastic#188824)
  [Console Monaco] Resolve uncaught error from tokenizer (elastic#188746)
  [Data Forge] Add `service.logs` dataset as a  data stream (elastic#188786)
  [Console] Fix failing bulk requests (elastic#188552)
  Update dependency terser to ^5.31.2 (main) (elastic#188528)
  [APM][ECO] Telemetry (elastic#188627)
  [Fleet] Fix uninstall package validation accross space (elastic#188749)
  Update warning on `xpack.fleet.enableExperimental` (elastic#188917)
  [DOCS][Cases] Automate more screenshots for cases (elastic#188697)
  [Fleet] Fix get one agent when feature flag disabled (elastic#188953)
  chore(investigate): Add investigate-app plugin from poc (elastic#188122)
  [Monaco Editor] Add Search functionality (elastic#188337)
  ...
TinLe added a commit to TinLe/kibana that referenced this pull request Jul 30, 2024
@TinLe
Merge branch 'master' into dependabot/npm_and_yarn/pdfjs-dist-4.2.67
8bec40b 
* master: (2400 commits)
  `BedrockChat` & `GeminiChat` (elastic#186809)
  [ResponseOps] log error when ES Query rules find docs out of time range (elastic#186332)
  skip flaky suite (elastic#188997)
  [Security solution][Alert Details] Enable preview feature flag and cypress tests (elastic#188580)
  [EuiProviders] Warn Developer if EuiProvider is missing (elastic#184608)
  [Security Solution ] Fixes Timeline infinite loading bug (elastic#188943)
  Improve SearchSource SearchRequest type (elastic#186862)
  Deprecate Search Sessions config (elastic#188037)
  [Synthetics] Add missing monitorType and tag info in cards !! (elastic#188824)
  [Console Monaco] Resolve uncaught error from tokenizer (elastic#188746)
  [Data Forge] Add `service.logs` dataset as a  data stream (elastic#188786)
  [Console] Fix failing bulk requests (elastic#188552)
  Update dependency terser to ^5.31.2 (main) (elastic#188528)
  [APM][ECO] Telemetry (elastic#188627)
  [Fleet] Fix uninstall package validation accross space (elastic#188749)
  Update warning on `xpack.fleet.enableExperimental` (elastic#188917)
  [DOCS][Cases] Automate more screenshots for cases (elastic#188697)
  [Fleet] Fix get one agent when feature flag disabled (elastic#188953)
  chore(investigate): Add investigate-app plugin from poc (elastic#188122)
  [Monaco Editor] Add Search functionality (elastic#188337)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliaElastic juliaElastic juliaElastic approved these changes

Assignees

@nchaulet nchaulet

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Fleet]: Able to uninstall integration from another space even when assigned to an Agent Policy.

6 participants

@nchaulet @obltmachine @elasticmachine @kibana-ci @juliaElastic @kibanamachine