Skip to content

Upgrade EUI to v35.0.0#105127

Merged
chandlerprall merged 5 commits intoelastic:masterfrom
chandlerprall:eui/36.0
Jul 15, 2021
Merged

Upgrade EUI to v35.0.0#105127
chandlerprall merged 5 commits intoelastic:masterfrom
chandlerprall:eui/36.0

Conversation

@chandlerprall
Copy link
Copy Markdown
Contributor

@chandlerprall chandlerprall commented Jul 9, 2021

Summary

eui@34.5.2 ▶️ eui@35.0.0

  • Added a type definition to euiContextMapping and updated the tokens list

35.0.0

Breaking changes

  • Changed EUI license from Apache v2 to dual-licensed Elastic v2 and Server Side Public License, v 1 (#4930)

34.6.0

  • Updated EuiContextMenuPanelDescriptor's title prop type from string to ReactNode (#4933)
  • Added EuiTokensObject type definition to allow enforcing i18n token coverage in consuming applications (#4927)
  • Added rowHeightsOptions to EuiDataGrid to allow configuring row heights (#4853)

@nickpeihl
Copy link
Copy Markdown
Contributor

nickpeihl commented Jul 10, 2021

Hey @chandlerprall. I wanted to drop in and mention that, in this PR, Kibana's license-checker still thinks @elastic/eui has an Apache license. You can see this by running node scripts/licenses_csv_report > licenses.csv. The CSV file shows the license for @elastic/eui is Apache*.

According to the license-checker module used by Kibana, the * indicates the license is naively "guessed". I did a little digging in the license-checker code to figure out why and I think the culprit is this regex test. It found a mention of Apache License in the LICENSE.txt file and incorrectly assumed the dependency has an Apache license.

I wanted to review this because we had an issue with the ELv2 license for a dependency used by Maps. We're considering replacing SEE LICENSE IN LICENSE.txt in package.json with Elastic License 2.0. Yarn will probably throw a warning about a non-SPDX license, but at least Kibana will report the license accurately.

@elastic elastic deleted a comment from kibanamachine Jul 12, 2021
@chandlerprall
Copy link
Copy Markdown
Contributor Author

chandlerprall commented Jul 13, 2021 •
edited
Loading

Thanks @nickpeihl !! After talking with a few folks and we've decided to include a license override for now to be explicit about licensing and not cause a block for EUI upgrades. I've created a follow-up issue (#105614) to find a better, long-term resolution.

@chandlerprall chandlerprall marked this pull request as ready for review July 13, 2021 17:03
@chandlerprall chandlerprall requested review from a team as code owners July 13, 2021 17:03
@chandlerprall chandlerprall added EUI release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0 labels Jul 13, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 13, 2021

Pinging @elastic/eui-design (EUI)

@chandlerprall chandlerprall mentioned this pull request Jul 14, 2021
Open
@chandlerprall
Copy link
Copy Markdown
Contributor Author

chandlerprall commented Jul 14, 2021

@elasticmachine merge upstream

thompsongl
thompsongl reviewed Jul 14, 2021
View reviewed changes
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 14, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1569 1590 +21

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.4MB +41.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 420.7KB 421.5KB +892.0B
kbnUiSharedDeps-css 520.3KB 520.6KB +340.0B
kbnUiSharedDeps-elastic 2.6MB 2.6MB +4.0KB
kbnUiSharedDeps-js 6.4MB 6.5MB +36.9KB
total +42.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chandlerprall chandlerprall merged commit 3731a30 into elastic:master Jul 15, 2021
@chandlerprall chandlerprall deleted the eui/36.0 branch July 15, 2021 02:15
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 15, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/new…
cec3989 
…-png-pdf-report-type

* 'master' of github.com:elastic/kibana: (75 commits)
  [Search Sessions] Don’t try to delete errored searches (elastic#105434)
  [Search Sessions] fix saved object can be created even if courier:batchSearches is enabled (elastic#105407)
  [Remote Clusters] Fixed remote clusters details flyout for long strings (elastic#105592)
  [ML] Functional tests - re-activate a11y tests (elastic#105198)
  [APM] Typed client-side routing (elastic#104274)
  [Canvas] Expression error (elastic#103048)
  [ML] Fixing job wizard with missing description (elastic#105574)
  [Security Solution][Alerts] - Add alerts subfeature UI (elastic#105505)
  Upgrade EUI to v35.0.0 (elastic#105127)
  [Reporting] Clean up types for internal APIs needed for UI (elastic#105508)
  skip flaky suite (elastic#105087)
  [Workplace Search] Fix Chrome issues with GitHub sources (elastic#105680)
  [Fleet] Add containerized fleet server instructions to Fleet README (elastic#105669)
  [ML] Add api integration test for analytics map endpoint  (elastic#105531)
  Fixes cypress flake across two tests (elastic#105645)
  [Logs&Metrics UI] add owner properties to plugin manifest (elastic#105580)
  chore(NA): introduce preset for jest-integration tests on @kbn/test (elastic#105144)
  [Enterprise Search] Added Thumbnails to Search UI (elastic#104199)
  Translate App Search credentials list (elastic#105619)
  [APM] APM agent config created prior to Fleet migration is not injected into integration policy (elastic#105504)
  ...

# Conflicts:
#	x-pack/plugins/reporting/common/types.ts
#	x-pack/plugins/reporting/public/management/report_listing.test.tsx
@chandlerprall chandlerprall mentioned this pull request Jul 15, 2021
Merged
chandlerprall added a commit that referenced this pull request Jul 15, 2021
@chandlerprall @kibanamachine
Upgrade EUI to v35.0.0 (#105127) (#105783)
2f7d282 
* Bump EUI to v35.0.0, update euiContextMapping to match latest i18n tokens

* Updated i18n_service jest snapshot

* Added license override for EUI

* Attempting to clean up some forced dependency resolutions

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@thompsongl thompsongl mentioned this pull request Jul 15, 2021
Merged
@thompsongl thompsongl mentioned this pull request Jul 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

@jbudz jbudz jbudz approved these changes

+1 more reviewer

@thompsongl thompsongl thompsongl left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

EUI release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@chandlerprall @nickpeihl @elasticmachine @kibanamachine @pgayvallet @thompsongl @jbudz