Define set of i18n tokens via TypeScript#4927
Merged
chandlerprall merged 4 commits intoelastic:masterfrom Jul 6, 2021
Merged
Conversation
a377c03 to
41504ee
Compare
41504ee to
c07b87d
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4927/ |
thompsongl
approved these changes
Jul 6, 2021
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
LGTM!
Compared new eui.d.ts to the token changelog
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4927/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
To allow applications to confirm they define the whole set of our i18n tokens - and are updated when tokens are added or removed - this creates an
EuiTokensObjectdefinition in eui.d.ts that can be used to type the context mapping object.Relevant change in Kibana to opt-in to this typing: https://github.com/elastic/kibana/blob/master/src/core/public/i18n/i18n_eui_mapping.tsx#L18
const euiContextMapping = {becomes
const euiContextMapping: EuiTokensObject = {Tested this by dropping the generated eui.d.ts into Kibana & making the above change. TypeScript then identified 9 tokens that are no longer in use and 15 that are missing from that mapping.
Checklist