[Enterprise Search] Added Thumbnails to Search UI by JasonStoltz · Pull Request #104199 · elastic/kibana

JasonStoltz · 2021-07-01T19:51:47Z

Summary

This PR adds thumbnail support to the Search UI page within App Search.

Testing:

Make sure that the thumbnails work, both when generating a UI and when downloading a ZIP file.
Make sure that when the new Thumbnail dropdown is selected, that the correct portion of the image to the right of the form is highlighted

Release note

Adds a Thumbnail Image option to the Search UI page within App Search.

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

JasonStoltz · 2021-07-06T13:55:22Z

@elasticmachine merge upstream

JasonStoltz · 2021-07-08T15:14:49Z

@elasticmachine merge upstream

cee-chen · 2021-07-09T20:09:19Z

@JasonStoltz since you've added the release_note:enhancement label, you'll need to add a ## Release note section. Check out the Kibana docs for more info:

https://www.elastic.co/guide/en/kibana/master/contributing.html#_create_the_release_notes_text

cee-chen

LGTM, all super optional/minor comments. My only blocking comment is that you need a ## Release note header in your PR description if you want this to have a release note

x-pack/plugins/enterprise_search/public/applications/app_search/components/search_ui/types.ts

x-pack/plugins/enterprise_search/public/applications/app_search/components/search_ui/i18n.ts

...search/public/applications/app_search/components/search_ui/components/search_ui_graphic.scss

cee-chen · 2021-07-09T20:28:25Z

...ise_search/public/applications/app_search/components/search_ui/components/search_ui_form.tsx

+        <EuiSelect
+          disabled={dataLoading}
+          options={optionFields}
+          value={selectedThumbnailOption && selectedThumbnailOption.value}


Just to check, we don't anticipate adding a default value for this the same way we do for title and url right? Might be worth checking with the Crawler folks perhaps to see if they scrape a page thumbnail image?...

I can check with them

Will add defaulting to a future PR.

JasonStoltz · 2021-07-12T14:48:15Z

@elasticmachine merge upstream

…h/components/search_ui/i18n.ts Co-authored-by: Constance <constancecchen@users.noreply.github.com>

…h/components/search_ui/components/search_ui_graphic.scss Co-authored-by: Constance <constancecchen@users.noreply.github.com>

cee-chen · 2021-07-12T16:20:05Z

@JasonStoltz Quick check on the release notes section in your PR - I'm still not seeing that currently on page refresh, did that get added?

JasonStoltz · 2021-07-12T16:26:27Z

@constancecchen

@JasonStoltz Quick check on the release notes section in your PR - I'm still not seeing that currently on page refresh, did that get added?

Done, thank you for the reminder.

cee-chen

🎉

JasonStoltz · 2021-07-13T16:50:50Z

@daveyholler I need a code owner review, do you mind?

daveyholler

LGTM

JasonStoltz · 2021-07-14T17:30:47Z

@elasticmachine merge upstream

kibanamachine · 2021-07-14T19:40:02Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`enterpriseSearch`	2.1MB	2.1MB	+2.7KB

History

💚 Build #137849 succeeded 73f35ec
💚 Build #137269 succeeded 129abad
💚 Build #136566 succeeded 1a61a61
💚 Build #136130 succeeded 76d031b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2021-07-14T19:43:07Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>

…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (75 commits) [Search Sessions] Don’t try to delete errored searches (elastic#105434) [Search Sessions] fix saved object can be created even if courier:batchSearches is enabled (elastic#105407) [Remote Clusters] Fixed remote clusters details flyout for long strings (elastic#105592) [ML] Functional tests - re-activate a11y tests (elastic#105198) [APM] Typed client-side routing (elastic#104274) [Canvas] Expression error (elastic#103048) [ML] Fixing job wizard with missing description (elastic#105574) [Security Solution][Alerts] - Add alerts subfeature UI (elastic#105505) Upgrade EUI to v35.0.0 (elastic#105127) [Reporting] Clean up types for internal APIs needed for UI (elastic#105508) skip flaky suite (elastic#105087) [Workplace Search] Fix Chrome issues with GitHub sources (elastic#105680) [Fleet] Add containerized fleet server instructions to Fleet README (elastic#105669) [ML] Add api integration test for analytics map endpoint (elastic#105531) Fixes cypress flake across two tests (elastic#105645) [Logs&Metrics UI] add owner properties to plugin manifest (elastic#105580) chore(NA): introduce preset for jest-integration tests on @kbn/test (elastic#105144) [Enterprise Search] Added Thumbnails to Search UI (elastic#104199) Translate App Search credentials list (elastic#105619) [APM] APM agent config created prior to Fleet migration is not injected into integration policy (elastic#105504) ... # Conflicts: # x-pack/plugins/reporting/common/types.ts # x-pack/plugins/reporting/public/management/report_listing.test.tsx

elasticmachine · 2021-09-01T15:50:41Z

Pinging @elastic/app-search-frontend (Team:AppSearch)

Added Thumbnails to Search UI

76d031b

JasonStoltz added the v7.15.0 label Jul 1, 2021

JasonStoltz requested a review from a team July 1, 2021 19:51

JasonStoltz added release_note:enhancement auto-backport Deprecated - use backport:version if exact versions are needed labels Jul 1, 2021

Merge branch 'master' into thumbnail-support

1a61a61

Merge branch 'master' into thumbnail-support

129abad

cee-chen reviewed Jul 9, 2021

View reviewed changes

Merge branch 'master' into thumbnail-support

deb740d

kibanamachine requested a review from a team as a code owner July 12, 2021 14:48

JasonStoltz and others added 2 commits July 12, 2021 10:48

Update x-pack/plugins/enterprise_search/public/applications/app_searc…

4152070

…h/components/search_ui/i18n.ts Co-authored-by: Constance <constancecchen@users.noreply.github.com>

Update x-pack/plugins/enterprise_search/public/applications/app_searc…

73f35ec

…h/components/search_ui/components/search_ui_graphic.scss Co-authored-by: Constance <constancecchen@users.noreply.github.com>

JasonStoltz changed the title ~~[App Search] Added Thumbnails to Search UI~~ [Enterprise Search] Added Thumbnails to Search UI Jul 12, 2021

cee-chen approved these changes Jul 12, 2021

View reviewed changes

daveyholler approved these changes Jul 13, 2021

View reviewed changes

Merge branch 'master' into thumbnail-support

4a8284a

JasonStoltz enabled auto-merge (squash) July 14, 2021 17:31

JasonStoltz merged commit 02cd508 into elastic:master Jul 14, 2021

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 14, 2021

[Enterprise Search] Added Thumbnails to Search UI (elastic#104199)

9882047

kibanamachine mentioned this pull request Jul 14, 2021

[7.x] [Enterprise Search] Added Thumbnails to Search UI (#104199) #105663

Merged

kibanamachine added a commit that referenced this pull request Jul 14, 2021

[Enterprise Search] Added Thumbnails to Search UI (#104199) (#105663)

409a0c6

Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>

KOTungseth added the Team:AppSearch label Sep 1, 2021

JasonStoltz deleted the thumbnail-support branch September 8, 2021 12:36

chriscressman added the Team:EnterpriseSearch label Jan 13, 2022

Conversation

JasonStoltz commented Jul 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Release note

Checklist

Uh oh!

JasonStoltz commented Jul 6, 2021

Uh oh!

JasonStoltz commented Jul 8, 2021

Uh oh!

cee-chen commented Jul 9, 2021

Uh oh!

cee-chen left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cee-chen Jul 9, 2021

Choose a reason for hiding this comment

Uh oh!

JasonStoltz Jul 12, 2021

Choose a reason for hiding this comment

Uh oh!

JasonStoltz Jul 12, 2021

Choose a reason for hiding this comment

Uh oh!

JasonStoltz commented Jul 12, 2021

Uh oh!

cee-chen commented Jul 12, 2021

Uh oh!

JasonStoltz commented Jul 12, 2021

Uh oh!

cee-chen left a comment

Choose a reason for hiding this comment

Uh oh!

JasonStoltz commented Jul 13, 2021

Uh oh!

daveyholler left a comment

Choose a reason for hiding this comment

Uh oh!

JasonStoltz commented Jul 14, 2021

Uh oh!

kibanamachine commented Jul 14, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

History

Uh oh!

kibanamachine commented Jul 14, 2021

💚 Backport successful

Uh oh!

elasticmachine commented Sep 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

JasonStoltz commented Jul 1, 2021 •

edited

Loading

cee-chen left a comment •

edited

Loading