[ML] Add api integration test for analytics map endpoint #105531
Merged
alvarezmelissa87 merged 3 commits intoelastic:masterfrom Jul 14, 2021
Merged
[ML] Add api integration test for analytics map endpoint #105531alvarezmelissa87 merged 3 commits intoelastic:masterfrom
alvarezmelissa87 merged 3 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
x-pack/test/api_integration/apis/ml/data_frame_analytics/get_spaces.ts
Outdated
Show resolved
Hide resolved
pheyos
reviewed
Jul 14, 2021
Member
pheyos
left a comment
There was a problem hiding this comment.
Great to see these tests coming 🎉
Left a few suggestions.
x-pack/test/api_integration/apis/ml/data_frame_analytics/get_spaces.ts
Outdated
Show resolved
Hide resolved
x-pack/test/api_integration/apis/ml/data_frame_analytics/get_spaces.ts
Outdated
Show resolved
Hide resolved
x-pack/test/api_integration/apis/ml/data_frame_analytics/get_spaces.ts
Outdated
Show resolved
Hide resolved
x-pack/test/api_integration/apis/ml/data_frame_analytics/get_spaces.ts
Outdated
Show resolved
Hide resolved
This was referenced Jul 14, 2021
Member
|
LGTM 🎉 |
qn895
approved these changes
Jul 14, 2021
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
This was referenced Jul 14, 2021
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Jul 14, 2021
alvarezmelissa87
added a commit
that referenced
this pull request
Jul 14, 2021
alvarezmelissa87
added a commit
that referenced
this pull request
Jul 15, 2021
…105685) * adds api integration test for analytics map endpoint in spaces * wrap request code in function * check error value and add messaging Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jul 15, 2021
…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (75 commits) [Search Sessions] Don’t try to delete errored searches (elastic#105434) [Search Sessions] fix saved object can be created even if courier:batchSearches is enabled (elastic#105407) [Remote Clusters] Fixed remote clusters details flyout for long strings (elastic#105592) [ML] Functional tests - re-activate a11y tests (elastic#105198) [APM] Typed client-side routing (elastic#104274) [Canvas] Expression error (elastic#103048) [ML] Fixing job wizard with missing description (elastic#105574) [Security Solution][Alerts] - Add alerts subfeature UI (elastic#105505) Upgrade EUI to v35.0.0 (elastic#105127) [Reporting] Clean up types for internal APIs needed for UI (elastic#105508) skip flaky suite (elastic#105087) [Workplace Search] Fix Chrome issues with GitHub sources (elastic#105680) [Fleet] Add containerized fleet server instructions to Fleet README (elastic#105669) [ML] Add api integration test for analytics map endpoint (elastic#105531) Fixes cypress flake across two tests (elastic#105645) [Logs&Metrics UI] add owner properties to plugin manifest (elastic#105580) chore(NA): introduce preset for jest-integration tests on @kbn/test (elastic#105144) [Enterprise Search] Added Thumbnails to Search UI (elastic#104199) Translate App Search credentials list (elastic#105619) [APM] APM agent config created prior to Fleet migration is not injected into integration policy (elastic#105504) ... # Conflicts: # x-pack/plugins/reporting/common/types.ts # x-pack/plugins/reporting/public/management/report_listing.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related meta issue: #97982
Adds test for
GET /data_frame/analytics/map/{id}with spacesChecklist
Delete any items that are not applicable to this PR.