[EuiContextMenuPanelDescriptor] title should accept ReactNode rather than string#4933
Merged
gjones merged 4 commits intoelastic:masterfrom Jul 6, 2021
Merged
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4933/ |
elizabetdev
reviewed
Jul 6, 2021
elizabetdev
approved these changes
Jul 6, 2021
Contributor
elizabetdev
left a comment
There was a problem hiding this comment.
Tested in Chrome, Safari, Edge, and, Firefox. LGTM! 🎉
Just added a small suggestion so that consumers know what is the wrapping element.
Responding to feedback. Co-authored-by: Elizabet Oliveira <elizabet.oliveira@elastic.co>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4933/ |
This reverts commit 68c6a11.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4933/ |
thompsongl
approved these changes
Jul 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated EuiContextMenuPanelDescriptor's title prop type from string to ReactNode
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Added documentation- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes