[@elastic/eslint-plugin-eui] added new badge-accessibility-rules rule.#9354
Merged
alexwizp merged 2 commits intoelastic:mainfrom Feb 4, 2026
Merged
[@elastic/eslint-plugin-eui] added new badge-accessibility-rules rule.#9354alexwizp merged 2 commits intoelastic:mainfrom
@elastic/eslint-plugin-eui] added new badge-accessibility-rules rule.#9354alexwizp merged 2 commits intoelastic:mainfrom
Conversation
badge-accessibility-rules rule.@elastic/eslint-plugin-eui] added new badge-accessibility-rules rule.
Collaborator
💚 Build SucceededHistory
|
Collaborator
💚 Build Succeeded
|
weronikaolejniczak
approved these changes
Feb 4, 2026
Contributor
weronikaolejniczak
left a comment
There was a problem hiding this comment.
LGTM! 🟢 Thanks, Aliaksei!
mgadewoll
added a commit
to elastic/kibana
that referenced
this pull request
Feb 10, 2026
## Dependency updates - `@elastic/eui`: v112.2.0 ⏩ v112.3.0 - `@elastic/eslint-plugin-eui`: v2.7.0 ⏩ v2.8.0 --- ## Package updates ### `@elastic/eui` [v112.3.0](https://github.com/elastic/eui/releases/tag/v112.3.0) - Added new `server` icon. ([#9355](elastic/eui#9355)) - Added `className` support to `EuiMarkdownEditor`'s `toolbarProps` for custom toolbar styling ([#9349](elastic/eui#9349)) - Updated `EuiFilePicker` to use the `upload` icon to better indicate uploads. ([#9351](elastic/eui#9351)) - Exported the flyout system store singleton and added an event observer for emitting close session events ([#9347](elastic/eui#9347)) - Updated `EuiIcon` to use standard dynamic imports for icon assets, enabling native support for modern bundlers (Rollup, Parcel) and improving initial load performance ([#9342](elastic/eui#9342)) **Bug fixes** - Fixed a potential crash in the flyout system: due to asynchronous state updates and React's batching behavior, it was possible to experience a crash when closing a managed flyout. ([#9356](elastic/eui#9356)) ### `@elastic/eslint-plugin-eui` v2.8.0 - Added new `icon-accessibility-rules` rule. ([#9357](elastic/eui#9357)) - Added new `badge-accessibility-rules` rule. ([#9354](elastic/eui#9354))
alexwizp
added a commit
to elastic/kibana
that referenced
this pull request
Feb 18, 2026
…ule in Kibana code. (#251665) **PR description** This PR fixes newly reported ESLint violations in Kibana introduced by the new `@elastic/eslint-plugin-eui` rule `@elastic/eui/badge-accessibility-rules`. The updates bring affected badge usages into compliance with the rule’s accessibility requirements, with no intended functional changes beyond a11y/lint conformance. **Why** The violations were surfaced after the rule was added to `@elastic/eslint-plugin-eui`. **References** `@elastic/eui `repo — Add `badge-accessibility-rules` rule: elastic/eui#9354 Closes: #211173 --------- Co-authored-by: Pete Harverson <pete@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Feb 18, 2026
…ule in Kibana code. (elastic#251665) **PR description** This PR fixes newly reported ESLint violations in Kibana introduced by the new `@elastic/eslint-plugin-eui` rule `@elastic/eui/badge-accessibility-rules`. The updates bring affected badge usages into compliance with the rule’s accessibility requirements, with no intended functional changes beyond a11y/lint conformance. **Why** The violations were surfaced after the rule was added to `@elastic/eslint-plugin-eui`. **References** `@elastic/eui `repo — Add `badge-accessibility-rules` rule: elastic/eui#9354 Closes: elastic#211173 --------- Co-authored-by: Pete Harverson <pete@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 3044fa8) # Conflicts: # x-pack/platform/plugins/shared/streams_app/public/components/stream_detail_significant_events_view/significant_events_table.tsx
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Feb 18, 2026
…ule in Kibana code. (elastic#251665) **PR description** This PR fixes newly reported ESLint violations in Kibana introduced by the new `@elastic/eslint-plugin-eui` rule `@elastic/eui/badge-accessibility-rules`. The updates bring affected badge usages into compliance with the rule’s accessibility requirements, with no intended functional changes beyond a11y/lint conformance. **Why** The violations were surfaced after the rule was added to `@elastic/eslint-plugin-eui`. **References** `@elastic/eui `repo — Add `badge-accessibility-rules` rule: elastic/eui#9354 Closes: elastic#211173 --------- Co-authored-by: Pete Harverson <pete@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 3044fa8) # Conflicts: # x-pack/platform/plugins/shared/streams_app/public/components/stream_detail_significant_events_view/significant_events_table.tsx
alexwizp
added a commit
to elastic/kibana
that referenced
this pull request
Feb 19, 2026
…les` rule in Kibana code. (#251665) (#253698) # Backport This will backport the following commits from `main` to `9.2`: - [Fixed EsLint violations of `@elastic/eui/badge-accessibility-rules` rule in Kibana code. (#251665)](#251665) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2026-02-18T10:08:25Z","message":"Fixed EsLint violations of `@elastic/eui/badge-accessibility-rules` rule in Kibana code. (#251665)\n\n**PR description**\nThis PR fixes newly reported ESLint violations in Kibana introduced by\nthe new `@elastic/eslint-plugin-eui` rule\n`@elastic/eui/badge-accessibility-rules`. The updates bring affected\nbadge usages into compliance with the rule’s accessibility requirements,\nwith no intended functional changes beyond a11y/lint conformance.\n\n**Why**\nThe violations were surfaced after the rule was added to\n`@elastic/eslint-plugin-eui`.\n\n**References**\n`@elastic/eui `repo — Add `badge-accessibility-rules` rule:\nhttps://github.com/elastic/eui/pull/9354\n\n\nCloses: https://github.com/elastic/kibana/issues/211173\n\n---------\n\nCo-authored-by: Pete Harverson <pete@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"3044fa8a1c7d7719151378e0cb3acdd843b0cd7a","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","Team:Fleet","backport:version","v9.4.0","Team:obs-presentation","Team:obs-ux-management","v9.3.1","v9.2.6"],"title":"Fixed EsLint violations of `@elastic/eui/badge-accessibility-rules` rule in Kibana code.","number":251665,"url":"https://github.com/elastic/kibana/pull/251665","mergeCommit":{"message":"Fixed EsLint violations of `@elastic/eui/badge-accessibility-rules` rule in Kibana code. (#251665)\n\n**PR description**\nThis PR fixes newly reported ESLint violations in Kibana introduced by\nthe new `@elastic/eslint-plugin-eui` rule\n`@elastic/eui/badge-accessibility-rules`. The updates bring affected\nbadge usages into compliance with the rule’s accessibility requirements,\nwith no intended functional changes beyond a11y/lint conformance.\n\n**Why**\nThe violations were surfaced after the rule was added to\n`@elastic/eslint-plugin-eui`.\n\n**References**\n`@elastic/eui `repo — Add `badge-accessibility-rules` rule:\nhttps://github.com/elastic/eui/pull/9354\n\n\nCloses: https://github.com/elastic/kibana/issues/211173\n\n---------\n\nCo-authored-by: Pete Harverson <pete@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"3044fa8a1c7d7719151378e0cb3acdd843b0cd7a"}},"sourceBranch":"main","suggestedTargetBranches":["9.3","9.2"],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/251665","number":251665,"mergeCommit":{"message":"Fixed EsLint violations of `@elastic/eui/badge-accessibility-rules` rule in Kibana code. (#251665)\n\n**PR description**\nThis PR fixes newly reported ESLint violations in Kibana introduced by\nthe new `@elastic/eslint-plugin-eui` rule\n`@elastic/eui/badge-accessibility-rules`. The updates bring affected\nbadge usages into compliance with the rule’s accessibility requirements,\nwith no intended functional changes beyond a11y/lint conformance.\n\n**Why**\nThe violations were surfaced after the rule was added to\n`@elastic/eslint-plugin-eui`.\n\n**References**\n`@elastic/eui `repo — Add `badge-accessibility-rules` rule:\nhttps://github.com/elastic/eui/pull/9354\n\n\nCloses: https://github.com/elastic/kibana/issues/211173\n\n---------\n\nCo-authored-by: Pete Harverson <pete@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"3044fa8a1c7d7719151378e0cb3acdd843b0cd7a"}},{"branch":"9.3","label":"v9.3.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
alexwizp
added a commit
to elastic/kibana
that referenced
this pull request
Feb 19, 2026
…les` rule in Kibana code. (#251665) (#253696) # Backport This will backport the following commits from `main` to `9.3`: - [Fixed EsLint violations of `@elastic/eui/badge-accessibility-rules` rule in Kibana code. (#251665)](#251665) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2026-02-18T10:08:25Z","message":"Fixed EsLint violations of `@elastic/eui/badge-accessibility-rules` rule in Kibana code. (#251665)\n\n**PR description**\nThis PR fixes newly reported ESLint violations in Kibana introduced by\nthe new `@elastic/eslint-plugin-eui` rule\n`@elastic/eui/badge-accessibility-rules`. The updates bring affected\nbadge usages into compliance with the rule’s accessibility requirements,\nwith no intended functional changes beyond a11y/lint conformance.\n\n**Why**\nThe violations were surfaced after the rule was added to\n`@elastic/eslint-plugin-eui`.\n\n**References**\n`@elastic/eui `repo — Add `badge-accessibility-rules` rule:\nhttps://github.com/elastic/eui/pull/9354\n\n\nCloses: https://github.com/elastic/kibana/issues/211173\n\n---------\n\nCo-authored-by: Pete Harverson <pete@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"3044fa8a1c7d7719151378e0cb3acdd843b0cd7a","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","Team:Fleet","backport:version","v9.4.0","Team:obs-presentation","Team:obs-ux-management","v9.3.1","v9.2.6"],"title":"Fixed EsLint violations of `@elastic/eui/badge-accessibility-rules` rule in Kibana code.","number":251665,"url":"https://github.com/elastic/kibana/pull/251665","mergeCommit":{"message":"Fixed EsLint violations of `@elastic/eui/badge-accessibility-rules` rule in Kibana code. (#251665)\n\n**PR description**\nThis PR fixes newly reported ESLint violations in Kibana introduced by\nthe new `@elastic/eslint-plugin-eui` rule\n`@elastic/eui/badge-accessibility-rules`. The updates bring affected\nbadge usages into compliance with the rule’s accessibility requirements,\nwith no intended functional changes beyond a11y/lint conformance.\n\n**Why**\nThe violations were surfaced after the rule was added to\n`@elastic/eslint-plugin-eui`.\n\n**References**\n`@elastic/eui `repo — Add `badge-accessibility-rules` rule:\nhttps://github.com/elastic/eui/pull/9354\n\n\nCloses: https://github.com/elastic/kibana/issues/211173\n\n---------\n\nCo-authored-by: Pete Harverson <pete@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"3044fa8a1c7d7719151378e0cb3acdd843b0cd7a"}},"sourceBranch":"main","suggestedTargetBranches":["9.3","9.2"],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/251665","number":251665,"mergeCommit":{"message":"Fixed EsLint violations of `@elastic/eui/badge-accessibility-rules` rule in Kibana code. (#251665)\n\n**PR description**\nThis PR fixes newly reported ESLint violations in Kibana introduced by\nthe new `@elastic/eslint-plugin-eui` rule\n`@elastic/eui/badge-accessibility-rules`. The updates bring affected\nbadge usages into compliance with the rule’s accessibility requirements,\nwith no intended functional changes beyond a11y/lint conformance.\n\n**Why**\nThe violations were surfaced after the rule was added to\n`@elastic/eslint-plugin-eui`.\n\n**References**\n`@elastic/eui `repo — Add `badge-accessibility-rules` rule:\nhttps://github.com/elastic/eui/pull/9354\n\n\nCloses: https://github.com/elastic/kibana/issues/211173\n\n---------\n\nCo-authored-by: Pete Harverson <pete@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"3044fa8a1c7d7719151378e0cb3acdd843b0cd7a"}},{"branch":"9.3","label":"v9.3.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
Feb 19, 2026
…ule in Kibana code. (elastic#251665) **PR description** This PR fixes newly reported ESLint violations in Kibana introduced by the new `@elastic/eslint-plugin-eui` rule `@elastic/eui/badge-accessibility-rules`. The updates bring affected badge usages into compliance with the rule’s accessibility requirements, with no intended functional changes beyond a11y/lint conformance. **Why** The violations were surfaced after the rule was added to `@elastic/eslint-plugin-eui`. **References** `@elastic/eui `repo — Add `badge-accessibility-rules` rule: elastic/eui#9354 Closes: elastic#211173 --------- Co-authored-by: Pete Harverson <pete@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
ersin-erdal
pushed a commit
to ersin-erdal/kibana
that referenced
this pull request
Feb 19, 2026
…ule in Kibana code. (elastic#251665) **PR description** This PR fixes newly reported ESLint violations in Kibana introduced by the new `@elastic/eslint-plugin-eui` rule `@elastic/eui/badge-accessibility-rules`. The updates bring affected badge usages into compliance with the rule’s accessibility requirements, with no intended functional changes beyond a11y/lint conformance. **Why** The violations were surfaced after the rule was added to `@elastic/eslint-plugin-eui`. **References** `@elastic/eui `repo — Add `badge-accessibility-rules` rule: elastic/eui#9354 Closes: elastic#211173 --------- Co-authored-by: Pete Harverson <pete@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: elastic/kibana#211173
Summary
Add a new badge-accessibility-rules rule to
@elastic/eslint-plugin-euito enforce accessibility requirements forEuiBadgeusage.Why are we making this change?
For accessibility (a11y) reasons, we need to ensure EuiBadge follows consistent, screen-reader-friendly patterns and avoids common a11y pitfalls. The new
badge-accessibility-rulesESLint rule helps catch issues at review time by enforcing best practices directly in code.Screens
Tests
