Skip to content

Fixed EsLint violations of @elastic/eui/badge-accessibility-rules rule in Kibana code.#251665

Merged
alexwizp merged 16 commits intoelastic:mainfrom
alexwizp:feb-4-1
Feb 18, 2026
Merged

Fixed EsLint violations of @elastic/eui/badge-accessibility-rules rule in Kibana code.#251665
alexwizp merged 16 commits intoelastic:mainfrom
alexwizp:feb-4-1

Conversation

@alexwizp
Copy link
Copy Markdown
Contributor

@alexwizp alexwizp commented Feb 4, 2026 •
edited by kibanamachine
Loading

PR description
This PR fixes newly reported ESLint violations in Kibana introduced by the new @elastic/eslint-plugin-eui rule @elastic/eui/badge-accessibility-rules. The updates bring affected badge usages into compliance with the rule’s accessibility requirements, with no intended functional changes beyond a11y/lint conformance.

Why
The violations were surfaced after the rule was added to @elastic/eslint-plugin-eui.

References
@elastic/eui repo — Add badge-accessibility-rules rule: elastic/eui#9354

Closes: #211173

@alexwizp alexwizp changed the title Fixed EsLint violations of @elastic/eui/badge-accessibility-rules rule in Kibana code. Fixed EsLint violations of @elastic/eui/badge-accessibility-rules rule in Kibana code. Feb 4, 2026
@alexwizp alexwizp added Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.4.0 v9.3.1 v9.2.6 labels Feb 4, 2026
@alexwizp alexwizp marked this pull request as ready for review February 5, 2026 09:12
@alexwizp alexwizp requested review from a team as code owners February 5, 2026 09:12
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 5, 2026

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@alexwizp alexwizp requested review from a team as code owners February 5, 2026 09:12
@alexwizp alexwizp requested a review from dplumlee February 5, 2026 09:12
@botelastic botelastic bot added Team:Fleet Team label for Observability Data Collection Fleet team Team:obs-presentation Focus: APM UI, Infra UI, Hosts UI, Universal Profiling, Obs Overview and left Navigation Team:obs-ux-management labels Feb 5, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 5, 2026

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@alexwizp
Copy link
Copy Markdown
Contributor Author

alexwizp commented Feb 11, 2026

@elastic/actionable-obs-team, @elastic/appex-sharedux, @elastic/obs-onboarding-team, @elastic/obs-sig-events-team, @elastic/response-ops, @elastic/stack-monitoring please review

benakansara
benakansara approved these changes Feb 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@benakansara benakansara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actionable-obs code changes LGTM

bhavyarm
bhavyarm approved these changes Feb 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. LGTM!

@alexwizp
Copy link
Copy Markdown
Contributor Author

alexwizp commented Feb 16, 2026

@elastic/obs-onboarding-team, @elastic/obs-sig-events-team, @elastic/response-ops, @elastic/stack-monitoring please review

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 16, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 524.0KB 523.9KB -84.0B
apm 3.2MB 3.2MB -41.0B
dashboard 819.9KB 819.8KB -70.0B
dataViewManagement 142.2KB 142.2KB -48.0B
fleet 2.2MB 2.2MB -68.0B
infra 1.2MB 1.2MB -141.0B
monitoring 634.7KB 634.6KB -95.0B
securitySolution 11.1MB 11.1MB -37.0B
slo 1.1MB 1.1MB -103.0B
streamsApp 1.7MB 1.7MB -233.0B
triggersActionsUi 1.8MB 1.8MB -158.0B
total -1.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
savedObjectsTagging 20.9KB 20.8KB -43.0B

History

@alexwizp
Copy link
Copy Markdown
Contributor Author

alexwizp commented Feb 17, 2026

@elastic/response-ops, @elastic/stack-monitoring please review

pickypg
pickypg approved these changes Feb 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@pickypg pickypg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGT Stack Monitoring

georgianaonoleata1904
georgianaonoleata1904 approved these changes Feb 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@georgianaonoleata1904 georgianaonoleata1904 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ResponseOps changes lgtm

@alexwizp alexwizp merged commit 3044fa8 into elastic:main Feb 18, 2026
16 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 18, 2026

Starting backport for target branches: 9.2, 9.3

https://github.com/elastic/kibana/actions/runs/22135337799

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 18, 2026

💔 All backports failed

Status Branch Result
❌ 9.2 Backport failed because of merge conflicts
❌ 9.3 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 251665

Questions ?

Please refer to the Backport tool documentation

@alexwizp alexwizp mentioned this pull request Feb 18, 2026
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Feb 18, 2026
@alexwizp
Fixed EsLint violations of @elastic/eui/badge-accessibility-rules r…
546dd04 
…ule in Kibana code. (elastic#251665)

**PR description**
This PR fixes newly reported ESLint violations in Kibana introduced by
the new `@elastic/eslint-plugin-eui` rule
`@elastic/eui/badge-accessibility-rules`. The updates bring affected
badge usages into compliance with the rule’s accessibility requirements,
with no intended functional changes beyond a11y/lint conformance.

**Why**
The violations were surfaced after the rule was added to
`@elastic/eslint-plugin-eui`.

**References**
`@elastic/eui `repo — Add `badge-accessibility-rules` rule:
elastic/eui#9354

Closes:  elastic#211173

---------

Co-authored-by: Pete Harverson <pete@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 3044fa8)

# Conflicts:
#	x-pack/platform/plugins/shared/streams_app/public/components/stream_detail_significant_events_view/significant_events_table.tsx
alexwizp added a commit to alexwizp/kibana that referenced this pull request Feb 18, 2026
@alexwizp
Fixed EsLint violations of @elastic/eui/badge-accessibility-rules r…
9caa924 
…ule in Kibana code. (elastic#251665)

**PR description**
This PR fixes newly reported ESLint violations in Kibana introduced by
the new `@elastic/eslint-plugin-eui` rule
`@elastic/eui/badge-accessibility-rules`. The updates bring affected
badge usages into compliance with the rule’s accessibility requirements,
with no intended functional changes beyond a11y/lint conformance.

**Why**
The violations were surfaced after the rule was added to
`@elastic/eslint-plugin-eui`.

**References**
`@elastic/eui `repo — Add `badge-accessibility-rules` rule:
elastic/eui#9354

Closes:  elastic#211173

---------

Co-authored-by: Pete Harverson <pete@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 3044fa8)

# Conflicts:
#	x-pack/platform/plugins/shared/streams_app/public/components/stream_detail_significant_events_view/significant_events_table.tsx
@alexwizp alexwizp mentioned this pull request Feb 18, 2026
Merged
@alexwizp
Copy link
Copy Markdown
Contributor Author

alexwizp commented Feb 18, 2026

💚 All backports created successfully

Status Branch Result
✅ 9.3
✅ 9.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

This was referenced Feb 18, 2026
Merged
Merged
alexwizp added a commit that referenced this pull request Feb 19, 2026
@alexwizp
[9.2] Fixed EsLint violations of `@elastic/eui/badge-accessibility-ru…
2198b6d 
…les` rule in Kibana code. (#251665) (#253698)

# Backport

This will backport the following commits from `main` to `9.2`:
- [Fixed EsLint violations of `@elastic/eui/badge-accessibility-rules`
rule in Kibana code.
(#251665)](#251665)

<!--- Backport version: 10.2.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2026-02-18T10:08:25Z","message":"Fixed
EsLint violations of `@elastic/eui/badge-accessibility-rules` rule in
Kibana code. (#251665)\n\n**PR description**\nThis PR fixes newly
reported ESLint violations in Kibana introduced by\nthe new
`@elastic/eslint-plugin-eui`
rule\n`@elastic/eui/badge-accessibility-rules`. The updates bring
affected\nbadge usages into compliance with the rule’s accessibility
requirements,\nwith no intended functional changes beyond a11y/lint
conformance.\n\n**Why**\nThe violations were surfaced after the rule was
added to\n`@elastic/eslint-plugin-eui`.\n\n**References**\n`@elastic/eui
`repo — Add `badge-accessibility-rules`
rule:\nhttps://github.com/elastic/eui/pull/9354\n\n\nCloses:
https://github.com/elastic/kibana/issues/211173\n\n---------\n\nCo-authored-by:
Pete Harverson <pete@elastic.co>\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3044fa8a1c7d7719151378e0cb3acdd843b0cd7a","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","Team:Fleet","backport:version","v9.4.0","Team:obs-presentation","Team:obs-ux-management","v9.3.1","v9.2.6"],"title":"Fixed
EsLint violations of `@elastic/eui/badge-accessibility-rules` rule in
Kibana
code.","number":251665,"url":"https://github.com/elastic/kibana/pull/251665","mergeCommit":{"message":"Fixed
EsLint violations of `@elastic/eui/badge-accessibility-rules` rule in
Kibana code. (#251665)\n\n**PR description**\nThis PR fixes newly
reported ESLint violations in Kibana introduced by\nthe new
`@elastic/eslint-plugin-eui`
rule\n`@elastic/eui/badge-accessibility-rules`. The updates bring
affected\nbadge usages into compliance with the rule’s accessibility
requirements,\nwith no intended functional changes beyond a11y/lint
conformance.\n\n**Why**\nThe violations were surfaced after the rule was
added to\n`@elastic/eslint-plugin-eui`.\n\n**References**\n`@elastic/eui
`repo — Add `badge-accessibility-rules`
rule:\nhttps://github.com/elastic/eui/pull/9354\n\n\nCloses:
https://github.com/elastic/kibana/issues/211173\n\n---------\n\nCo-authored-by:
Pete Harverson <pete@elastic.co>\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3044fa8a1c7d7719151378e0cb3acdd843b0cd7a"}},"sourceBranch":"main","suggestedTargetBranches":["9.3","9.2"],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/251665","number":251665,"mergeCommit":{"message":"Fixed
EsLint violations of `@elastic/eui/badge-accessibility-rules` rule in
Kibana code. (#251665)\n\n**PR description**\nThis PR fixes newly
reported ESLint violations in Kibana introduced by\nthe new
`@elastic/eslint-plugin-eui`
rule\n`@elastic/eui/badge-accessibility-rules`. The updates bring
affected\nbadge usages into compliance with the rule’s accessibility
requirements,\nwith no intended functional changes beyond a11y/lint
conformance.\n\n**Why**\nThe violations were surfaced after the rule was
added to\n`@elastic/eslint-plugin-eui`.\n\n**References**\n`@elastic/eui
`repo — Add `badge-accessibility-rules`
rule:\nhttps://github.com/elastic/eui/pull/9354\n\n\nCloses:
https://github.com/elastic/kibana/issues/211173\n\n---------\n\nCo-authored-by:
Pete Harverson <pete@elastic.co>\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3044fa8a1c7d7719151378e0cb3acdd843b0cd7a"}},{"branch":"9.3","label":"v9.3.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
alexwizp added a commit that referenced this pull request Feb 19, 2026
@alexwizp
[9.3] Fixed EsLint violations of `@elastic/eui/badge-accessibility-ru…
21ad08d 
…les` rule in Kibana code. (#251665) (#253696)

# Backport

This will backport the following commits from `main` to `9.3`:
- [Fixed EsLint violations of `@elastic/eui/badge-accessibility-rules`
rule in Kibana code.
(#251665)](#251665)

<!--- Backport version: 10.2.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2026-02-18T10:08:25Z","message":"Fixed
EsLint violations of `@elastic/eui/badge-accessibility-rules` rule in
Kibana code. (#251665)\n\n**PR description**\nThis PR fixes newly
reported ESLint violations in Kibana introduced by\nthe new
`@elastic/eslint-plugin-eui`
rule\n`@elastic/eui/badge-accessibility-rules`. The updates bring
affected\nbadge usages into compliance with the rule’s accessibility
requirements,\nwith no intended functional changes beyond a11y/lint
conformance.\n\n**Why**\nThe violations were surfaced after the rule was
added to\n`@elastic/eslint-plugin-eui`.\n\n**References**\n`@elastic/eui
`repo — Add `badge-accessibility-rules`
rule:\nhttps://github.com/elastic/eui/pull/9354\n\n\nCloses:
https://github.com/elastic/kibana/issues/211173\n\n---------\n\nCo-authored-by:
Pete Harverson <pete@elastic.co>\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3044fa8a1c7d7719151378e0cb3acdd843b0cd7a","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","Team:Fleet","backport:version","v9.4.0","Team:obs-presentation","Team:obs-ux-management","v9.3.1","v9.2.6"],"title":"Fixed
EsLint violations of `@elastic/eui/badge-accessibility-rules` rule in
Kibana
code.","number":251665,"url":"https://github.com/elastic/kibana/pull/251665","mergeCommit":{"message":"Fixed
EsLint violations of `@elastic/eui/badge-accessibility-rules` rule in
Kibana code. (#251665)\n\n**PR description**\nThis PR fixes newly
reported ESLint violations in Kibana introduced by\nthe new
`@elastic/eslint-plugin-eui`
rule\n`@elastic/eui/badge-accessibility-rules`. The updates bring
affected\nbadge usages into compliance with the rule’s accessibility
requirements,\nwith no intended functional changes beyond a11y/lint
conformance.\n\n**Why**\nThe violations were surfaced after the rule was
added to\n`@elastic/eslint-plugin-eui`.\n\n**References**\n`@elastic/eui
`repo — Add `badge-accessibility-rules`
rule:\nhttps://github.com/elastic/eui/pull/9354\n\n\nCloses:
https://github.com/elastic/kibana/issues/211173\n\n---------\n\nCo-authored-by:
Pete Harverson <pete@elastic.co>\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3044fa8a1c7d7719151378e0cb3acdd843b0cd7a"}},"sourceBranch":"main","suggestedTargetBranches":["9.3","9.2"],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/251665","number":251665,"mergeCommit":{"message":"Fixed
EsLint violations of `@elastic/eui/badge-accessibility-rules` rule in
Kibana code. (#251665)\n\n**PR description**\nThis PR fixes newly
reported ESLint violations in Kibana introduced by\nthe new
`@elastic/eslint-plugin-eui`
rule\n`@elastic/eui/badge-accessibility-rules`. The updates bring
affected\nbadge usages into compliance with the rule’s accessibility
requirements,\nwith no intended functional changes beyond a11y/lint
conformance.\n\n**Why**\nThe violations were surfaced after the rule was
added to\n`@elastic/eslint-plugin-eui`.\n\n**References**\n`@elastic/eui
`repo — Add `badge-accessibility-rules`
rule:\nhttps://github.com/elastic/eui/pull/9354\n\n\nCloses:
https://github.com/elastic/kibana/issues/211173\n\n---------\n\nCo-authored-by:
Pete Harverson <pete@elastic.co>\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3044fa8a1c7d7719151378e0cb3acdd843b0cd7a"}},{"branch":"9.3","label":"v9.3.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request Feb 19, 2026
@alexwizp @peteharverson
@kibanamachine @patrykkopycinski
Fixed EsLint violations of @elastic/eui/badge-accessibility-rules r…
e498f5a 
…ule in Kibana code. (elastic#251665)

**PR description**
This PR fixes newly reported ESLint violations in Kibana introduced by
the new `@elastic/eslint-plugin-eui` rule
`@elastic/eui/badge-accessibility-rules`. The updates bring affected
badge usages into compliance with the rule’s accessibility requirements,
with no intended functional changes beyond a11y/lint conformance.

**Why**
The violations were surfaced after the rule was added to
`@elastic/eslint-plugin-eui`.

**References**
`@elastic/eui `repo — Add `badge-accessibility-rules` rule:
elastic/eui#9354


Closes:  elastic#211173

---------

Co-authored-by: Pete Harverson <pete@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
ersin-erdal pushed a commit to ersin-erdal/kibana that referenced this pull request Feb 19, 2026
@alexwizp @peteharverson
@kibanamachine @ersin-erdal
Fixed EsLint violations of @elastic/eui/badge-accessibility-rules r…
8673f35 
…ule in Kibana code. (elastic#251665)

**PR description**
This PR fixes newly reported ESLint violations in Kibana introduced by
the new `@elastic/eslint-plugin-eui` rule
`@elastic/eui/badge-accessibility-rules`. The updates bring affected
badge usages into compliance with the rule’s accessibility requirements,
with no intended functional changes beyond a11y/lint conformance.

**Why**
The violations were surfaced after the rule was added to
`@elastic/eslint-plugin-eui`.

**References**
`@elastic/eui `repo — Add `badge-accessibility-rules` rule:
elastic/eui#9354


Closes:  elastic#211173

---------

Co-authored-by: Pete Harverson <pete@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nreese nreese nreese approved these changes

@Kerry350 Kerry350 Kerry350 approved these changes

@nchaulet nchaulet nchaulet approved these changes

@efegurkan efegurkan efegurkan approved these changes

@pickypg pickypg pickypg approved these changes

@adcoelho adcoelho adcoelho approved these changes

@bhavyarm bhavyarm bhavyarm approved these changes

@peteharverson peteharverson peteharverson approved these changes

@jennypavlova jennypavlova jennypavlova approved these changes

@AlexGPlay AlexGPlay AlexGPlay approved these changes

@dplumlee dplumlee dplumlee approved these changes

@benakansara benakansara benakansara approved these changes

@georgianaonoleata1904 georgianaonoleata1904 georgianaonoleata1904 approved these changes

Assignees

No one assigned

Labels

backport:version Backport to applied version labels Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Team:obs-presentation Focus: APM UI, Infra UI, Hosts UI, Universal Profiling, Obs Overview and left Navigation Team:obs-ux-management v9.2.6 v9.3.1 v9.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Observability:Rules page]Duplicated actions for Enabled