Skip to content

[@elastic/eslint-plugin-eui] added new icon-accessibility-rules rule.#9357

Merged
alexwizp merged 2 commits intoelastic:mainfrom
alexwizp:icon-rules
Feb 6, 2026
Merged

[@elastic/eslint-plugin-eui] added new icon-accessibility-rules rule.#9357
alexwizp merged 2 commits intoelastic:mainfrom
alexwizp:icon-rules

Conversation

@alexwizp
Copy link
Copy Markdown
Contributor

@alexwizp alexwizp commented Feb 5, 2026

Summary
Add a new icon-accessibility-rules rule to @elastic/eslint-plugin-eui to enforce accessibility requirements for EuiIcon usage.

Why are we making this change?
For accessibility (a11y) reasons, we need to ensure EuiIcon follows consistent, screen-reader-friendly patterns and avoids common a11y pitfalls. The new icon-accessibility-rules ESLint rule helps catch issues at review time by enforcing best practices directly in code.

Tests

image

@alexwizp alexwizp marked this pull request as ready for review February 5, 2026 12:38
@alexwizp alexwizp requested a review from a team as a code owner February 5, 2026 12:38
@elasticmachine
Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

@elasticmachine
Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

@weronikaolejniczak weronikaolejniczak self-requested a review February 6, 2026 09:32
Copy link
Copy Markdown
Contributor

@weronikaolejniczak weronikaolejniczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🟢 Thanks, Aliaksei!

@alexwizp alexwizp merged commit 775043d into elastic:main Feb 6, 2026
6 checks passed
mgadewoll added a commit to elastic/kibana that referenced this pull request Feb 10, 2026
## Dependency updates

- `@elastic/eui`: v112.2.0 ⏩ v112.3.0
- `@elastic/eslint-plugin-eui`: v2.7.0 ⏩ v2.8.0

---

## Package updates

### `@elastic/eui`
[v112.3.0](https://github.com/elastic/eui/releases/tag/v112.3.0)

- Added new `server` icon.
([#9355](elastic/eui#9355))
- Added `className` support to `EuiMarkdownEditor`'s `toolbarProps` for
custom toolbar styling
([#9349](elastic/eui#9349))
- Updated `EuiFilePicker` to use the `upload` icon to better indicate
uploads. ([#9351](elastic/eui#9351))
- Exported the flyout system store singleton and added an event observer
for emitting close session events
([#9347](elastic/eui#9347))
- Updated `EuiIcon` to use standard dynamic imports for icon assets,
enabling native support for modern bundlers (Rollup, Parcel) and
improving initial load performance
([#9342](elastic/eui#9342))

**Bug fixes**

- Fixed a potential crash in the flyout system: due to asynchronous
state updates and React's batching behavior, it was possible to
experience a crash when closing a managed flyout.
([#9356](elastic/eui#9356))

### `@elastic/eslint-plugin-eui` v2.8.0

- Added new `icon-accessibility-rules` rule.
([#9357](elastic/eui#9357))
- Added new `badge-accessibility-rules` rule.
([#9354](elastic/eui#9354))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants