Skip to content

Tag Cloud should deal with empty responses correctly#9354

Merged
thomasneirynck merged 1 commit intoelastic:masterfrom
thomasneirynck:tagcloud-fix-backbutton
Dec 5, 2016
Merged

Tag Cloud should deal with empty responses correctly#9354
thomasneirynck merged 1 commit intoelastic:masterfrom
thomasneirynck:tagcloud-fix-backbutton

Conversation

@thomasneirynck
Copy link
Copy Markdown
Contributor

closes #9348.

tag cloud did not work with empty responses correctly. One of the side-effects is that the back button did not work properly. For example, pressing the back button would not empty out the screen and show stale clouds.

This also caused a type-error. Empty configurations meant that we could not access any aggregation-configs to produce a label.
Copy link
Copy Markdown
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalger spalger self-assigned this Dec 3, 2016
@rashmivkulkarni
Copy link
Copy Markdown
Contributor

With the help of Spencer, I actually checked out this PR , and verified that Fatal errors are not seen on the console anymore. LGTM.

@LeeDr
Copy link
Copy Markdown

LeeDr commented Dec 3, 2016

LGTM

@thomasneirynck
Copy link
Copy Markdown
Contributor Author

jenkins, test this

1 similar comment
@thomasneirynck
Copy link
Copy Markdown
Contributor Author

jenkins, test this

@thomasneirynck thomasneirynck merged commit 5b61fc3 into elastic:master Dec 5, 2016
elastic-jasper added a commit that referenced this pull request Dec 5, 2016
Backports PR #9354

**Commit 1:**
Tag Cloud should deal with empty responses correctly

tag cloud did not work with empty responses correctly. One of the side-effects is that the back button did not work properly. For example, pressing the back button would not empty out the screen and show stale clouds.

This also caused a type-error. Empty configurations meant that we could not access any aggregation-configs to produce a label.

* Original sha: 9b52ba4
* Authored by Thomas Neirynck <thomas@elastic.co> on 2016-12-02T22:58:54Z
elastic-jasper added a commit that referenced this pull request Dec 5, 2016
Backports PR #9354

**Commit 1:**
Tag Cloud should deal with empty responses correctly

tag cloud did not work with empty responses correctly. One of the side-effects is that the back button did not work properly. For example, pressing the back button would not empty out the screen and show stale clouds.

This also caused a type-error. Empty configurations meant that we could not access any aggregation-configs to produce a label.

* Original sha: 9b52ba4
* Authored by Thomas Neirynck <thomas@elastic.co> on 2016-12-02T22:58:54Z
@tbragin tbragin added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Dec 7, 2016
mgadewoll added a commit that referenced this pull request Feb 10, 2026
## Dependency updates

- `@elastic/eui`: v112.2.0 ⏩ v112.3.0
- `@elastic/eslint-plugin-eui`: v2.7.0 ⏩ v2.8.0

---

## Package updates

### `@elastic/eui`
[v112.3.0](https://github.com/elastic/eui/releases/tag/v112.3.0)

- Added new `server` icon.
([#9355](elastic/eui#9355))
- Added `className` support to `EuiMarkdownEditor`'s `toolbarProps` for
custom toolbar styling
([#9349](elastic/eui#9349))
- Updated `EuiFilePicker` to use the `upload` icon to better indicate
uploads. ([#9351](elastic/eui#9351))
- Exported the flyout system store singleton and added an event observer
for emitting close session events
([#9347](elastic/eui#9347))
- Updated `EuiIcon` to use standard dynamic imports for icon assets,
enabling native support for modern bundlers (Rollup, Parcel) and
improving initial load performance
([#9342](elastic/eui#9342))

**Bug fixes**

- Fixed a potential crash in the flyout system: due to asynchronous
state updates and React's batching behavior, it was possible to
experience a crash when closing a managed flyout.
([#9356](elastic/eui#9356))

### `@elastic/eslint-plugin-eui` v2.8.0

- Added new `icon-accessibility-rules` rule.
([#9357](elastic/eui#9357))
- Added new `badge-accessibility-rules` rule.
([#9354](elastic/eui#9354))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v5.1.1 v6.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uncaught TypeError: Cannot read property 'makeLabel' of undefined- seen on clicking the back button in the browser when you are on TagCloud Viz

6 participants