Tag Cloud should deal with empty responses correctly#9354
Merged
thomasneirynck merged 1 commit intoelastic:masterfrom Dec 5, 2016
Merged
Tag Cloud should deal with empty responses correctly#9354thomasneirynck merged 1 commit intoelastic:masterfrom
thomasneirynck merged 1 commit intoelastic:masterfrom
Conversation
tag cloud did not work with empty responses correctly. One of the side-effects is that the back button did not work properly. For example, pressing the back button would not empty out the screen and show stale clouds. This also caused a type-error. Empty configurations meant that we could not access any aggregation-configs to produce a label.
Contributor
|
With the help of Spencer, I actually checked out this PR , and verified that |
|
LGTM |
Contributor
Author
|
jenkins, test this |
1 similar comment
Contributor
Author
|
jenkins, test this |
This was referenced Dec 5, 2016
elastic-jasper
added a commit
that referenced
this pull request
Dec 5, 2016
Backports PR #9354 **Commit 1:** Tag Cloud should deal with empty responses correctly tag cloud did not work with empty responses correctly. One of the side-effects is that the back button did not work properly. For example, pressing the back button would not empty out the screen and show stale clouds. This also caused a type-error. Empty configurations meant that we could not access any aggregation-configs to produce a label. * Original sha: 9b52ba4 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-12-02T22:58:54Z
elastic-jasper
added a commit
that referenced
this pull request
Dec 5, 2016
Backports PR #9354 **Commit 1:** Tag Cloud should deal with empty responses correctly tag cloud did not work with empty responses correctly. One of the side-effects is that the back button did not work properly. For example, pressing the back button would not empty out the screen and show stale clouds. This also caused a type-error. Empty configurations meant that we could not access any aggregation-configs to produce a label. * Original sha: 9b52ba4 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-12-02T22:58:54Z
This was referenced Dec 5, 2016
mgadewoll
added a commit
that referenced
this pull request
Feb 10, 2026
## Dependency updates - `@elastic/eui`: v112.2.0 ⏩ v112.3.0 - `@elastic/eslint-plugin-eui`: v2.7.0 ⏩ v2.8.0 --- ## Package updates ### `@elastic/eui` [v112.3.0](https://github.com/elastic/eui/releases/tag/v112.3.0) - Added new `server` icon. ([#9355](elastic/eui#9355)) - Added `className` support to `EuiMarkdownEditor`'s `toolbarProps` for custom toolbar styling ([#9349](elastic/eui#9349)) - Updated `EuiFilePicker` to use the `upload` icon to better indicate uploads. ([#9351](elastic/eui#9351)) - Exported the flyout system store singleton and added an event observer for emitting close session events ([#9347](elastic/eui#9347)) - Updated `EuiIcon` to use standard dynamic imports for icon assets, enabling native support for modern bundlers (Rollup, Parcel) and improving initial load performance ([#9342](elastic/eui#9342)) **Bug fixes** - Fixed a potential crash in the flyout system: due to asynchronous state updates and React's batching behavior, it was possible to experience a crash when closing a managed flyout. ([#9356](elastic/eui#9356)) ### `@elastic/eslint-plugin-eui` v2.8.0 - Added new `icon-accessibility-rules` rule. ([#9357](elastic/eui#9357)) - Added new `badge-accessibility-rules` rule. ([#9354](elastic/eui#9354))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #9348.