Do not deserialize back BytesTransportRequest to clone a request in MockTransportService#89926
Merged
fcofdez merged 3 commits intoelastic:mainfrom Sep 8, 2022
Merged
Conversation
…ockTransportService Some handlers, such as JOIN_VALIDATE_ACTION_NAME, deserialize a BytesTransportRequest into a different class that cannot be serialized. This commit changes that behaviour and directly clones the BytesTransportRequest instead of relying on the transport handler. Closes elastic#88120
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
approved these changes
Sep 8, 2022
Member
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM, a couple of nits. Also should we backport this to 8.4?
test/framework/src/main/java/org/elasticsearch/test/transport/MockTransportService.java
Show resolved
Hide resolved
test/framework/src/main/java/org/elasticsearch/test/transport/MockTransportService.java
Show resolved
Hide resolved
…MockTransportService.java Co-authored-by: David Turner <david.turner@elastic.co>
…MockTransportService.java Co-authored-by: David Turner <david.turner@elastic.co>
Contributor
Author
|
Thanks David! |
Collaborator
💚 Backport successful
|
fcofdez
added a commit
to fcofdez/elasticsearch
that referenced
this pull request
Sep 8, 2022
…ockTransportService (elastic#89926) Some handlers, such as JOIN_VALIDATE_ACTION_NAME, deserialize a BytesTransportRequest into a different class that cannot be serialized. This commit changes that behaviour and directly clones the BytesTransportRequest instead of relying on the transport handler. Closes elastic#88120
fcofdez
added a commit
that referenced
this pull request
Sep 8, 2022
…ockTransportService (#89926) (#89936) Some handlers, such as JOIN_VALIDATE_ACTION_NAME, deserialize a BytesTransportRequest into a different class that cannot be serialized. This commit changes that behaviour and directly clones the BytesTransportRequest instead of relying on the transport handler. Closes #88120
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Sep 9, 2022
* main: (34 commits) Make sure ivy repo directory exists before downloading artifacts Use 'file://' scheme for local repository URL Use DRA artifacts for release build CI jobs Log unsuccessful attempts to get credentials from web identity tokens (elastic#88241) Script: Write Field API path manipulation (elastic#89889) Fetch health info action (elastic#89820) Fix memory leak in TransportDeleteExpiredDataAction (elastic#89935) [ML] Performance improvements for categorization jobs (elastic#89824) [DOCS] Revert changes for ES_JAVA_OPTS (elastic#89931) Fix deadlock bug exposed by a test (elastic#89934) [Downsampling] Remove `FieldValueFetcher` validator (elastic#89497) Fix segment stats in tsdb (elastic#89754) Synthetic _source: support dense_vector (elastic#89840) REST tests fetching fields with synthetic _source (elastic#89888) Do not deserialize back BytesTransportRequest to clone a request in MockTransportService (elastic#89926) Add SDK request logging to debug failures of S3BlobStoreRepositoryTests#testRequestStats (elastic#89912) Fix SnapshotStatusApisIT.testGetSnapshotsWithSnapshotInProgress (elastic#89925) Document synthetic source for text and keyword (elastic#89893) Fix CloneSnapshotIT.testRemoveFailedCloneFromCSWithQueuedSnapshotInProgress (elastic#89914) Add missing index.mapping.total_fields.limit setting to the target index (elastic#89875) ...
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Oct 15, 2024
All request handlers should be able to read `BytesTransportRequest` to a class than can copied by re-serializing. Direct copying was only necessary by the legacy `JOIN_VALIDATE_ACTION_NAME` request handler. See elastic#89926
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Oct 15, 2024
All request handlers should be able to read `BytesTransportRequest` to a class than can copied by re-serializing. Direct copying was only necessary by the legacy `JOIN_VALIDATE_ACTION_NAME` request handler. See elastic#89926
arteam
added a commit
that referenced
this pull request
Oct 23, 2024
All request handlers should be able to read `BytesTransportRequest` to a class than can copied by re-serializing. Direct copying was only necessary by the legacy `JOIN_VALIDATE_ACTION_NAME` request handler. See #89926
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Oct 23, 2024
All request handlers should be able to read `BytesTransportRequest` to a class than can copied by re-serializing. Direct copying was only necessary by the legacy `JOIN_VALIDATE_ACTION_NAME` request handler. See elastic#89926
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Oct 25, 2024
All request handlers should be able to read `BytesTransportRequest` to a class than can copied by re-serializing. Direct copying was only necessary by the legacy `JOIN_VALIDATE_ACTION_NAME` request handler. See elastic#89926
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
All request handlers should be able to read `BytesTransportRequest` to a class than can copied by re-serializing. Direct copying was only necessary by the legacy `JOIN_VALIDATE_ACTION_NAME` request handler. See elastic#89926
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some handlers, such as JOIN_VALIDATE_ACTION_NAME, deserialize a BytesTransportRequest into a different class that cannot be serialized. This commit changes that behaviour and directly clones the BytesTransportRequest instead of relying on the transport handler.
Closes #88120