Add missing index.mapping.total_fields.limit setting to the target index#89875
Merged
salvatore-campagna merged 5 commits intoelastic:mainfrom Sep 8, 2022
Conversation
…et index When the source index has a non-default value for the total number of fields in the mapping we need to copy that value and apply the same setting to the target index.
| .put( | ||
| MapperService.INDEX_MAPPING_TOTAL_FIELDS_LIMIT_SETTING.getKey(), | ||
| sourceIndexMetadata.getSettings().get(MapperService.INDEX_MAPPING_TOTAL_FIELDS_LIMIT_SETTING.getKey()) | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
I will update tests to check for this setting too.
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
nik9000
approved these changes
Sep 7, 2022
Contributor
Author
|
@elasticsearchmachine test this please |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/bwc |
csoulios
approved these changes
Sep 8, 2022
Contributor
csoulios
left a comment
There was a problem hiding this comment.
LGTM!
I only left a comment if we should set the index setting when it's not set in source index.
Comment on lines
+561
to
+564
| .put( | ||
| MapperService.INDEX_MAPPING_TOTAL_FIELDS_LIMIT_SETTING.getKey(), | ||
| sourceIndexMetadata.getSettings().get(MapperService.INDEX_MAPPING_TOTAL_FIELDS_LIMIT_SETTING.getKey()) | ||
| ) |
Contributor
There was a problem hiding this comment.
Will this work if MapperService.INDEX_MAPPING_TOTAL_FIELDS_LIMIT_SETTING is null at the source index?
Do we know what happens in this case?
Contributor
Author
There was a problem hiding this comment.
I can add a test for this maybe?
Contributor
Author
There was a problem hiding this comment.
Or better I can make the value random...
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Sep 9, 2022
* main: (34 commits) Make sure ivy repo directory exists before downloading artifacts Use 'file://' scheme for local repository URL Use DRA artifacts for release build CI jobs Log unsuccessful attempts to get credentials from web identity tokens (elastic#88241) Script: Write Field API path manipulation (elastic#89889) Fetch health info action (elastic#89820) Fix memory leak in TransportDeleteExpiredDataAction (elastic#89935) [ML] Performance improvements for categorization jobs (elastic#89824) [DOCS] Revert changes for ES_JAVA_OPTS (elastic#89931) Fix deadlock bug exposed by a test (elastic#89934) [Downsampling] Remove `FieldValueFetcher` validator (elastic#89497) Fix segment stats in tsdb (elastic#89754) Synthetic _source: support dense_vector (elastic#89840) REST tests fetching fields with synthetic _source (elastic#89888) Do not deserialize back BytesTransportRequest to clone a request in MockTransportService (elastic#89926) Add SDK request logging to debug failures of S3BlobStoreRepositoryTests#testRequestStats (elastic#89912) Fix SnapshotStatusApisIT.testGetSnapshotsWithSnapshotInProgress (elastic#89925) Document synthetic source for text and keyword (elastic#89893) Fix CloneSnapshotIT.testRemoveFailedCloneFromCSWithQueuedSnapshotInProgress (elastic#89914) Add missing index.mapping.total_fields.limit setting to the target index (elastic#89875) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the source index has a non-default value for the total number of fields in the mapping we need to copy that value and apply the same setting to the target index. This is necessary because later we apply the source index mappings to the target index. As a result, if the source index has a non-default limit on the number of fields in the mapping we need that same limit on the target index to avoid errors when applying the mappings.