Synthetic _source: support dense_vector#89840
Merged
elasticsearchmachine merged 8 commits intoelastic:mainfrom Sep 8, 2022
Merged
Synthetic _source: support dense_vector#89840elasticsearchmachine merged 8 commits intoelastic:mainfrom
elasticsearchmachine merged 8 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
Collaborator
|
Hi @nik9000, I've created a changelog YAML for you. |
nik9000
commented
Sep 6, 2022
| } | ||
|
|
||
| private class IndexedSyntheticFieldLoader implements SourceLoader.SyntheticFieldLoader { | ||
| private VectorValues values; |
Member
Author
There was a problem hiding this comment.
We've been using the lucene APIs directly for SyntheticFieldLoader subclasses. I believe it saves allocating a float[] on the doc values version which is nice, but not a huge thing. But I did it just to line up with the other implementations.
|
|
||
| @Override | ||
| public List<SyntheticSourceInvalidExample> invalidExample() throws IOException { | ||
| return List.of(); |
Member
Author
There was a problem hiding this comment.
It looks to me like there is nothing like ignore_above or ignore_malformed or doc_values: false on this field type.
This adds support for synthetic _source to `dense_vector` fields.
romseygeek
approved these changes
Sep 7, 2022
Contributor
romseygeek
left a comment
There was a problem hiding this comment.
One comment, LGTM otherwise
| @Override | ||
| public DocValuesLoader docValuesLoader(LeafReader leafReader, int[] docIdsInLeaf) throws IOException { | ||
| values = DocValues.getBinary(leafReader, name()); | ||
| if (values == null) { |
Contributor
There was a problem hiding this comment.
This needs to be leafReader.getBinary(name()) because DocValues.getBinary() never returns null
mayya-sharipova
approved these changes
Sep 7, 2022
Contributor
mayya-sharipova
left a comment
There was a problem hiding this comment.
@nik9000 Thanks, this LGTM!
Member
Author
|
run |
Member
Author
|
run elasticsearch-ci/part-1 |
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Sep 9, 2022
* main: (34 commits) Make sure ivy repo directory exists before downloading artifacts Use 'file://' scheme for local repository URL Use DRA artifacts for release build CI jobs Log unsuccessful attempts to get credentials from web identity tokens (elastic#88241) Script: Write Field API path manipulation (elastic#89889) Fetch health info action (elastic#89820) Fix memory leak in TransportDeleteExpiredDataAction (elastic#89935) [ML] Performance improvements for categorization jobs (elastic#89824) [DOCS] Revert changes for ES_JAVA_OPTS (elastic#89931) Fix deadlock bug exposed by a test (elastic#89934) [Downsampling] Remove `FieldValueFetcher` validator (elastic#89497) Fix segment stats in tsdb (elastic#89754) Synthetic _source: support dense_vector (elastic#89840) REST tests fetching fields with synthetic _source (elastic#89888) Do not deserialize back BytesTransportRequest to clone a request in MockTransportService (elastic#89926) Add SDK request logging to debug failures of S3BlobStoreRepositoryTests#testRequestStats (elastic#89912) Fix SnapshotStatusApisIT.testGetSnapshotsWithSnapshotInProgress (elastic#89925) Document synthetic source for text and keyword (elastic#89893) Fix CloneSnapshotIT.testRemoveFailedCloneFromCSWithQueuedSnapshotInProgress (elastic#89914) Add missing index.mapping.total_fields.limit setting to the target index (elastic#89875) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for synthetic _source to
dense_vectorfields.