REST tests fetching fields with synthetic _source#89888
Merged
elasticsearchmachine merged 2 commits intoelastic:mainfrom Sep 8, 2022
Merged
REST tests fetching fields with synthetic _source#89888elasticsearchmachine merged 2 commits intoelastic:mainfrom
elasticsearchmachine merged 2 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
This adds some paranoid REST layer tests for fetching field values with synthetic _source. Mostly, everything just works. But there are a few cases that work with regular source and not synthetic. This PR just adds those tests and asserts that those actions fail with a `TODO` that they should pass. We'll fix them in follow up changes. One by one by one. The failures are: * `keyword` fields without doc values try to load from the non-existent stored `_source`. * `text` fields for loaded via the `field` API try to load from the non-existent stored `_source`. * `match_only_text` field access in scripts tries to load from the non-existent stored `_source`. All script access regardless of how.
jdconrad
approved these changes
Sep 7, 2022
Contributor
jdconrad
left a comment
There was a problem hiding this comment.
This looks good to me. Thank you for the additional scripting coverage of synthetic source.
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Sep 9, 2022
* main: (34 commits) Make sure ivy repo directory exists before downloading artifacts Use 'file://' scheme for local repository URL Use DRA artifacts for release build CI jobs Log unsuccessful attempts to get credentials from web identity tokens (elastic#88241) Script: Write Field API path manipulation (elastic#89889) Fetch health info action (elastic#89820) Fix memory leak in TransportDeleteExpiredDataAction (elastic#89935) [ML] Performance improvements for categorization jobs (elastic#89824) [DOCS] Revert changes for ES_JAVA_OPTS (elastic#89931) Fix deadlock bug exposed by a test (elastic#89934) [Downsampling] Remove `FieldValueFetcher` validator (elastic#89497) Fix segment stats in tsdb (elastic#89754) Synthetic _source: support dense_vector (elastic#89840) REST tests fetching fields with synthetic _source (elastic#89888) Do not deserialize back BytesTransportRequest to clone a request in MockTransportService (elastic#89926) Add SDK request logging to debug failures of S3BlobStoreRepositoryTests#testRequestStats (elastic#89912) Fix SnapshotStatusApisIT.testGetSnapshotsWithSnapshotInProgress (elastic#89925) Document synthetic source for text and keyword (elastic#89893) Fix CloneSnapshotIT.testRemoveFailedCloneFromCSWithQueuedSnapshotInProgress (elastic#89914) Add missing index.mapping.total_fields.limit setting to the target index (elastic#89875) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some paranoid REST layer tests for fetching field values with synthetic _source. Mostly, everything just works. But there are a few cases that work with regular source and not synthetic. This PR just adds those tests and asserts that those actions fail with a
TODOthat they should pass. We'll fix them in follow up changes. One by one by one.The failures are:
keywordfields without doc values try to load from the non-existent stored_source.textfields for loaded via thefieldAPI try to load from the non-existent stored_source.match_only_textfield access in scripts tries to load from the non-existent stored_source. All script access regardless of how.