Skip to content

Remove direct cloning of BytesTransportRequests#114808

Merged
arteam merged 1 commit intoelastic:mainfrom
arteam:remove-direct-cloning-of-bytes-transport-request
Oct 23, 2024
Merged

Remove direct cloning of BytesTransportRequests#114808
arteam merged 1 commit intoelastic:mainfrom
arteam:remove-direct-cloning-of-bytes-transport-request

Conversation

@arteam
Copy link
Copy Markdown
Contributor

@arteam arteam commented Oct 15, 2024

All request handlers should be able to read BytesTransportRequest to a class than can copied by re-serializing. Direct copying was only necessary by the legacy JOIN_VALIDATE_ACTION_NAME request handler.

See #89926

All request handlers should be able to read `BytesTransportRequest` to
a class than can copied by re-serializing. Direct copying was only
necessary by the legacy `JOIN_VALIDATE_ACTION_NAME` request handler.

See elastic#89926
@arteam arteam added >non-issue :Distributed/Network Http and internode communication implementations >refactoring labels Oct 15, 2024
@arteam arteam marked this pull request as ready for review October 16, 2024 08:05
@arteam arteam requested review from DaveCTurner and ldematte and removed request for DaveCTurner October 16, 2024 08:05
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team. label Oct 16, 2024
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@ldematte ldematte removed their request for review October 16, 2024 08:25
@arteam arteam requested review from DaveCTurner and fcofdez October 17, 2024 08:17
Copy link
Copy Markdown
Contributor

@nicktindall nicktindall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arteam arteam merged commit 530d150 into elastic:main Oct 23, 2024
smalyshev pushed a commit to smalyshev/elasticsearch that referenced this pull request Oct 23, 2024
All request handlers should be able to read `BytesTransportRequest` to
a class than can copied by re-serializing. Direct copying was only
necessary by the legacy `JOIN_VALIDATE_ACTION_NAME` request handler.

See elastic#89926
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Oct 25, 2024
All request handlers should be able to read `BytesTransportRequest` to
a class than can copied by re-serializing. Direct copying was only
necessary by the legacy `JOIN_VALIDATE_ACTION_NAME` request handler.

See elastic#89926
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Nov 4, 2024
All request handlers should be able to read `BytesTransportRequest` to
a class than can copied by re-serializing. Direct copying was only
necessary by the legacy `JOIN_VALIDATE_ACTION_NAME` request handler.

See elastic#89926
Tim-Brooks added a commit to Tim-Brooks/elasticsearch that referenced this pull request Nov 20, 2024
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Nov 20, 2024
Since 8.3.0 (elastic#85380) we have sent join-validation requests as a
`BytesTransportRequest` to facilitate sharing these large messages (and
the work needed to create them) amongst all nodes that join the cluster
at around the same time. For BwC with versions earlier than 8.3.0 we use
a `ValidateJoinRequest` class to represent the received data, whichever
scheme it uses. We no longer need to maintain this compatibility, so we
can use a bare `BytesTransportRequest` on both sender and receiver, and
therefore drop the `ValidateJoinRequest` adapter and the special-cased
assertion in `MockTransportService`.

Relates elastic#114808 which was reverted in elastic#117200.
Tim-Brooks added a commit that referenced this pull request Nov 20, 2024
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Nov 21, 2024
Since 8.3.0 (elastic#85380) we have sent join-validation requests as a
`BytesTransportRequest` to facilitate sharing these large messages (and
the work needed to create them) amongst all nodes that join the cluster
at around the same time. For BwC with versions earlier than 8.3.0 we use
a `ValidateJoinRequest` class to represent the received data, whichever
scheme it uses. We no longer need to maintain this compatibility, so we
can use a bare `BytesTransportRequest` on both sender and receiver, and
therefore drop the `ValidateJoinRequest` adapter and the special-cased
assertion in `MockTransportService`.

Relates elastic#114808 which was reverted in elastic#117200.
elasticsearchmachine pushed a commit that referenced this pull request Nov 21, 2024
Since 8.3.0 (#85380) we have sent join-validation requests as a
`BytesTransportRequest` to facilitate sharing these large messages (and
the work needed to create them) amongst all nodes that join the cluster
at around the same time. For BwC with versions earlier than 8.3.0 we use
a `ValidateJoinRequest` class to represent the received data, whichever
scheme it uses. We no longer need to maintain this compatibility, so we
can use a bare `BytesTransportRequest` on both sender and receiver, and
therefore drop the `ValidateJoinRequest` adapter and the special-cased
assertion in `MockTransportService`.

Relates #114808 which was reverted in #117200.
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
Since 8.3.0 (elastic#85380) we have sent join-validation requests as a
`BytesTransportRequest` to facilitate sharing these large messages (and
the work needed to create them) amongst all nodes that join the cluster
at around the same time. For BwC with versions earlier than 8.3.0 we use
a `ValidateJoinRequest` class to represent the received data, whichever
scheme it uses. We no longer need to maintain this compatibility, so we
can use a bare `BytesTransportRequest` on both sender and receiver, and
therefore drop the `ValidateJoinRequest` adapter and the special-cased
assertion in `MockTransportService`.

Relates elastic#114808 which was reverted in elastic#117200.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Network Http and internode communication implementations >non-issue >refactoring Team:Distributed Meta label for distributed team. v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants