Remove ValidateJoinRequest#117225
Merged
elasticsearchmachine merged 2 commits intoelastic:mainfrom Nov 21, 2024
Merged
Conversation
Since 8.3.0 (elastic#85380) we have sent join-validation requests as a `BytesTransportRequest` to facilitate sharing these large messages (and the work needed to create them) amongst all nodes that join the cluster at around the same time. For BwC with versions earlier than 8.3.0 we use a `ValidateJoinRequest` class to represent the received data, whichever scheme it uses. We no longer need to maintain this compatibility, so we can use a bare `BytesTransportRequest` on both sender and receiver, and therefore drop the `ValidateJoinRequest` adapter and the special-cased assertion in `MockTransportService`. Relates elastic#114808 which was reverted in elastic#117200.
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
idegtiarenko
approved these changes
Nov 21, 2024
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
Since 8.3.0 (elastic#85380) we have sent join-validation requests as a `BytesTransportRequest` to facilitate sharing these large messages (and the work needed to create them) amongst all nodes that join the cluster at around the same time. For BwC with versions earlier than 8.3.0 we use a `ValidateJoinRequest` class to represent the received data, whichever scheme it uses. We no longer need to maintain this compatibility, so we can use a bare `BytesTransportRequest` on both sender and receiver, and therefore drop the `ValidateJoinRequest` adapter and the special-cased assertion in `MockTransportService`. Relates elastic#114808 which was reverted in elastic#117200.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 8.3.0 (#85380) we have sent join-validation requests as a
BytesTransportRequestto facilitate sharing these large messages (andthe work needed to create them) amongst all nodes that join the cluster
at around the same time. For BwC with versions earlier than 8.3.0 we use
a
ValidateJoinRequestclass to represent the received data, whicheverscheme it uses. We no longer need to maintain this compatibility, so we
can use a bare
BytesTransportRequeston both sender and receiver, andtherefore drop the
ValidateJoinRequestadapter and the special-casedassertion in
MockTransportService.Relates #114808 which was reverted in #117200.