This repository was archived by the owner on Sep 17, 2024. It is now read-only.
fix: incorrect variable name#1046
Merged
mdelapenya merged 1 commit intoelastic:masterfrom Apr 15, 2021
Merged
Conversation
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
v1v
approved these changes
Apr 15, 2021
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Apr 19, 2021
* master: fix: check if kibana version is a commit (elastic#1047) fix: incorrect variable name (elastic#1046) fix: typo in parameters (elastic#1045) chore: add debug info for the payload (elastic#1044) chore: add debug traces for the webhook payload (elastic#1043) fix: wrong interpolation (elastic#1042) Update Elastic Agent to not use Kibana (elastic#1036) fix: apply X version for non-master branches (elastic#1037) fix: add NodeJS to PATH (elastic#1035) fix: use an agent when building kibana (elastic#1030) fix(jjb): use a branch that exists (elastic#1029) remove uninstall step (elastic#1017) fix: delay checking stale agent version until it's used (elastic#1016) fix: use same JJB than in custom kibana (elastic#1010) chore: simplify PR template (elastic#1011) feat: support passing KIBANA_VERSION (elastic#905) [mergify] assign the original author (elastic#1009)
8 tasks
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Apr 20, 2021
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Apr 20, 2021
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Apr 20, 2021
mdelapenya
added a commit
that referenced
this pull request
Apr 20, 2021
…bhook payload (#1043) | chore: add debug info for the payload (#1044) | fix: typo in parameters (#1045) | fix: incorrect variable name (#1046) | fix: do not use GT_REPO va (#1057) * fix: wrong interpolation (#1042) * chore: add debug traces for the webhook payload (#1043) * chore: add debug info for the payload (#1044) * fix: do not use variable names as variable prefix * chore: print payload * fix: perform another API call to fetch PR data We need a second API request, as the issue_comment API does not retrieve data about the pull request. See https://docs.github.com/en/developers/webhooks-and-events/webhook-events-and-payloads#issue_comment * fix: typo in parameters (#1045) * fix: incorrect variable name (#1046) * fix: do not use GT_REPO variable, use fixed repo name instead (#1049) * fix: do not use GT_REPO variable, use fixed repo name Because the repo is always Kibana, let's use it * chore: remove unused echo
mdelapenya
added a commit
that referenced
this pull request
Apr 20, 2021
…bhook payload (#1043) | chore: add debug info for the payload (#1044) | fix: typo in parameters (#1045) | fix: incorrect variable name (#1046) | fix: do not use GT_REPO va (#1058) * fix: wrong interpolation (#1042) * chore: add debug traces for the webhook payload (#1043) * chore: add debug info for the payload (#1044) * fix: do not use variable names as variable prefix * chore: print payload * fix: perform another API call to fetch PR data We need a second API request, as the issue_comment API does not retrieve data about the pull request. See https://docs.github.com/en/developers/webhooks-and-events/webhook-events-and-payloads#issue_comment * fix: typo in parameters (#1045) * fix: incorrect variable name (#1046) * fix: do not use GT_REPO variable, use fixed repo name instead (#1049) * fix: do not use GT_REPO variable, use fixed repo name Because the repo is always Kibana, let's use it * chore: remove unused echo
mdelapenya
added a commit
that referenced
this pull request
Apr 20, 2021
…bhook payload (#1043) | chore: add debug info for the payload (#1044) | fix: typo in parameters (#1045) | fix: incorrect variable name (#1046) | fix: do not use GT_REPO va (#1059) * fix: wrong interpolation (#1042) * chore: add debug traces for the webhook payload (#1043) * chore: add debug info for the payload (#1044) * fix: do not use variable names as variable prefix * chore: print payload * fix: perform another API call to fetch PR data We need a second API request, as the issue_comment API does not retrieve data about the pull request. See https://docs.github.com/en/developers/webhooks-and-events/webhook-events-and-payloads#issue_comment * fix: typo in parameters (#1045) * fix: incorrect variable name (#1046) * fix: do not use GT_REPO variable, use fixed repo name instead (#1049) * fix: do not use GT_REPO variable, use fixed repo name Because the repo is always Kibana, let's use it * chore: remove unused echo
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It removes a
$from a variable name when using it.Why is it important?
The variable is not properly expanded, returning
null, causing an error when using that variable (it's used to query Github API)Checklist
make noticein the proper directory)Related issues