This repository was archived by the owner on Sep 17, 2024. It is now read-only.
fix: check if kibana version is a commit#1047
Merged
adam-stokes merged 1 commit intoelastic:masterfrom Apr 16, 2021
Merged
Conversation
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
adam-stokes
approved these changes
Apr 16, 2021
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Apr 19, 2021
* master: fix: check if kibana version is a commit (elastic#1047) fix: incorrect variable name (elastic#1046) fix: typo in parameters (elastic#1045) chore: add debug info for the payload (elastic#1044) chore: add debug traces for the webhook payload (elastic#1043) fix: wrong interpolation (elastic#1042) Update Elastic Agent to not use Kibana (elastic#1036) fix: apply X version for non-master branches (elastic#1037) fix: add NodeJS to PATH (elastic#1035) fix: use an agent when building kibana (elastic#1030) fix(jjb): use a branch that exists (elastic#1029) remove uninstall step (elastic#1017) fix: delay checking stale agent version until it's used (elastic#1016) fix: use same JJB than in custom kibana (elastic#1010) chore: simplify PR template (elastic#1011) feat: support passing KIBANA_VERSION (elastic#905) [mergify] assign the original author (elastic#1009)
mergify bot
pushed a commit
that referenced
this pull request
Apr 22, 2021
(cherry picked from commit 05ab18f) # Conflicts: # e2e/_suites/fleet/ingest_manager_test.go
mergify bot
pushed a commit
that referenced
this pull request
Apr 22, 2021
(cherry picked from commit 05ab18f)
mergify bot
pushed a commit
that referenced
this pull request
Apr 22, 2021
(cherry picked from commit 05ab18f)
mdelapenya
added a commit
that referenced
this pull request
Apr 22, 2021
mdelapenya
added a commit
that referenced
this pull request
Apr 22, 2021
mdelapenya
added a commit
that referenced
this pull request
Apr 22, 2021
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds a function to verify if a given string matches the commit format, which is driven by the
\b[0-9a-f]{5,40}\bregexp.This new function will be used to determine which docker namespace to use when pulling the docker image for Kibana
Why is it important?
If the version is a sha1, which happens when triggered by a Kibana PR, then uses the
kibananamespace instead of theobservability-ci. See https://beats-ci.elastic.co/blue/organizations/jenkins/e2e-tests%2Fe2e-testing-mbp/detail/master/720/pipeline/#step-401-log-83Checklist
make noticein the proper directory)