Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

chore: simplify PR template#1011

Merged
mdelapenya merged 1 commit intoelastic:masterfrom
mdelapenya:pr-template
Apr 12, 2021
Merged

chore: simplify PR template#1011
mdelapenya merged 1 commit intoelastic:masterfrom
mdelapenya:pr-template

Conversation

@mdelapenya
Copy link
Copy Markdown
Contributor

@mdelapenya mdelapenya commented Apr 12, 2021

What does this PR do?

It comments out the headers that are optional or not required

Why is it important?

Simplify the process of writing the PR description

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests for the CLI, and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

It comments out the headers that are optional or not required
@mdelapenya mdelapenya self-assigned this Apr 12, 2021
@mdelapenya mdelapenya requested a review from a team April 12, 2021 16:16
@mdelapenya mdelapenya marked this pull request as ready for review April 12, 2021 16:17
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1011 opened

  • Start Time: 2021-04-12T16:16:44.762+0000

  • Duration: 7 min 39 sec

  • Commit: 13ab61a

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

@mdelapenya mdelapenya merged commit 7f4cbdc into elastic:master Apr 12, 2021
@mdelapenya mdelapenya deleted the pr-template branch April 13, 2021 05:18
@mdelapenya
Copy link
Copy Markdown
Contributor Author

Adding backport labels so that the template is changed accordingly in the maintenance branches

mergify bot pushed a commit that referenced this pull request Apr 13, 2021
It comments out the headers that are optional or not required

(cherry picked from commit 7f4cbdc)
mergify bot pushed a commit that referenced this pull request Apr 13, 2021
It comments out the headers that are optional or not required

(cherry picked from commit 7f4cbdc)
mergify bot pushed a commit that referenced this pull request Apr 13, 2021
It comments out the headers that are optional or not required

(cherry picked from commit 7f4cbdc)
mdelapenya added a commit that referenced this pull request Apr 13, 2021
It comments out the headers that are optional or not required

(cherry picked from commit 7f4cbdc)

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya added a commit that referenced this pull request Apr 13, 2021
It comments out the headers that are optional or not required

(cherry picked from commit 7f4cbdc)

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya added a commit that referenced this pull request Apr 13, 2021
It comments out the headers that are optional or not required

(cherry picked from commit 7f4cbdc)

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Apr 15, 2021
* master:
  chore: add debug info for the payload (elastic#1044)
  chore: add debug traces for the webhook payload (elastic#1043)
  fix: wrong interpolation (elastic#1042)
  Update Elastic Agent to not use Kibana (elastic#1036)
  fix: apply X version for non-master branches (elastic#1037)
  fix: add NodeJS to PATH (elastic#1035)
  fix: use an agent when building kibana (elastic#1030)
  fix(jjb): use a branch that exists (elastic#1029)
  remove uninstall step (elastic#1017)
  fix: delay checking stale agent version until it's used (elastic#1016)
  fix: use same JJB than in custom kibana (elastic#1010)
  chore: simplify PR template (elastic#1011)
  feat: support passing KIBANA_VERSION (elastic#905)
  [mergify] assign the original author (elastic#1009)
  Remove the agent config file parameters for stand alone (elastic#983)
  Uniquify the stand-alone step for checking agent status (elastic#993)
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Apr 19, 2021
* master:
  fix: check if kibana version is a commit (elastic#1047)
  fix: incorrect variable name (elastic#1046)
  fix: typo in parameters (elastic#1045)
  chore: add debug info for the payload (elastic#1044)
  chore: add debug traces for the webhook payload (elastic#1043)
  fix: wrong interpolation (elastic#1042)
  Update Elastic Agent to not use Kibana (elastic#1036)
  fix: apply X version for non-master branches (elastic#1037)
  fix: add NodeJS to PATH (elastic#1035)
  fix: use an agent when building kibana (elastic#1030)
  fix(jjb): use a branch that exists (elastic#1029)
  remove uninstall step (elastic#1017)
  fix: delay checking stale agent version until it's used (elastic#1016)
  fix: use same JJB than in custom kibana (elastic#1010)
  chore: simplify PR template (elastic#1011)
  feat: support passing KIBANA_VERSION (elastic#905)
  [mergify] assign the original author (elastic#1009)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants