This repository was archived by the owner on Sep 17, 2024. It is now read-only.
Merged
Conversation
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errors
Expand to view the tests failures
|
| Test | Results |
|---|---|
| Failed | 1 |
| Passed | 140 |
| Skipped | 0 |
| Total | 141 |
Genuine test errors 
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
- Name:
Initializing / End-To-End Tests / ubuntu-18.04_fleet_agent_endpoint_integration / Deploying an Endpoint makes policies to appear in the Security App – Agent Endpoint Integration
v1v
approved these changes
Apr 14, 2021
kuisathaverat
approved these changes
Apr 14, 2021
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errors
Expand to view the tests failures
|
| Test | Results |
|---|---|
| Failed | 1 |
| Passed | 140 |
| Skipped | 0 |
| Total | 141 |
Genuine test errors
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
- Name:
Initializing / End-To-End Tests / ubuntu-18.04_fleet_agent_endpoint_integration / Deploying an Endpoint makes policies to appear in the Security App – Agent Endpoint Integration
8 tasks
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Apr 14, 2021
* fix: add NodeJS to PATH * fix: use proper Github API for retrieving the comment by ID * chore: use existing step from the shared library
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Apr 14, 2021
* fix: add NodeJS to PATH * fix: use proper Github API for retrieving the comment by ID * chore: use existing step from the shared library
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Apr 14, 2021
* fix: add NodeJS to PATH * fix: use proper Github API for retrieving the comment by ID * chore: use existing step from the shared library
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Apr 15, 2021
* master: chore: add debug info for the payload (elastic#1044) chore: add debug traces for the webhook payload (elastic#1043) fix: wrong interpolation (elastic#1042) Update Elastic Agent to not use Kibana (elastic#1036) fix: apply X version for non-master branches (elastic#1037) fix: add NodeJS to PATH (elastic#1035) fix: use an agent when building kibana (elastic#1030) fix(jjb): use a branch that exists (elastic#1029) remove uninstall step (elastic#1017) fix: delay checking stale agent version until it's used (elastic#1016) fix: use same JJB than in custom kibana (elastic#1010) chore: simplify PR template (elastic#1011) feat: support passing KIBANA_VERSION (elastic#905) [mergify] assign the original author (elastic#1009) Remove the agent config file parameters for stand alone (elastic#983) Uniquify the stand-alone step for checking agent status (elastic#993)
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Apr 19, 2021
* master: fix: check if kibana version is a commit (elastic#1047) fix: incorrect variable name (elastic#1046) fix: typo in parameters (elastic#1045) chore: add debug info for the payload (elastic#1044) chore: add debug traces for the webhook payload (elastic#1043) fix: wrong interpolation (elastic#1042) Update Elastic Agent to not use Kibana (elastic#1036) fix: apply X version for non-master branches (elastic#1037) fix: add NodeJS to PATH (elastic#1035) fix: use an agent when building kibana (elastic#1030) fix(jjb): use a branch that exists (elastic#1029) remove uninstall step (elastic#1017) fix: delay checking stale agent version until it's used (elastic#1016) fix: use same JJB than in custom kibana (elastic#1010) chore: simplify PR template (elastic#1011) feat: support passing KIBANA_VERSION (elastic#905) [mergify] assign the original author (elastic#1009)
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds Node modules to the PATH on build time. This is a temporary solution meanwhile we release a new version of the shared library.
Besides that, it reuses the existing step to check permissions for who triggered the tests with the comment in Kibana PRs
Why is it important?
It will fix the error for not finding NPM, NODE nor YARN commands on the CI worker when building the Docker image for a kibana PR
Checklist
make noticein the proper directory)Related issues
Follow-ups
We could add exact same code to the shared library step, so any client code will benefit from it