This repository was archived by the owner on Sep 17, 2024. It is now read-only.
fix: do not use GT_REPO variable, use fixed repo name instead#1049
Merged
mdelapenya merged 2 commits intoelastic:masterfrom Apr 19, 2021
Merged
fix: do not use GT_REPO variable, use fixed repo name instead#1049mdelapenya merged 2 commits intoelastic:masterfrom
mdelapenya merged 2 commits intoelastic:masterfrom
Conversation
Because the repo is always Kibana, let's use it
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errors
Expand to view the tests failures
|
| Test | Results |
|---|---|
| Failed | 4 |
| Passed | 118 |
| Skipped | 0 |
| Total | 122 |
Genuine test errors 
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
- Name:
Initializing / End-To-End Tests / ubuntu-18.04_fleet_fleet_mode_agent / [empty] – TEST-fleet.xml - Name:
Initializing / End-To-End Tests / ubuntu-18.04_fleet_backend_processes / [empty] – TEST-fleet.xml - Name:
Initializing / End-To-End Tests / ubuntu-18.04_fleet_agent_endpoint_integration / [empty] – TEST-fleet.xml - Name:
Initializing / End-To-End Tests / ubuntu-18.04_fleet_stand_alone_agent / [empty] – TEST-fleet.xml
v1v
reviewed
Apr 19, 2021
| environment { | ||
| REPO = 'kibana' | ||
| BASE_DIR = "src/github.com/elastic/${env.REPO}" | ||
| ELASTIC_REPO = "elastic/${env.REPO}" |
Member
There was a problem hiding this comment.
If you use the the gitCheckout then ORG_NAME should be there and point to elastic:
- https://github.com/elastic/apm-pipeline-library/blob/8f48394fe31ae516841e25ea45b3faa94d147e96/vars/githubEnv.groovy#L79-L80
In case it helps you to move away from the hardcoded elastic
Contributor
Author
There was a problem hiding this comment.
We are internally using gitCheckout in the buildKibana step, although it could be the case the image is already built and we skip that part
v1v
approved these changes
Apr 19, 2021
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Apr 20, 2021
…c#1049) * fix: do not use GT_REPO variable, use fixed repo name Because the repo is always Kibana, let's use it * chore: remove unused echo
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Apr 20, 2021
…c#1049) * fix: do not use GT_REPO variable, use fixed repo name Because the repo is always Kibana, let's use it * chore: remove unused echo
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Apr 20, 2021
…c#1049) * fix: do not use GT_REPO variable, use fixed repo name Because the repo is always Kibana, let's use it * chore: remove unused echo
mdelapenya
added a commit
that referenced
this pull request
Apr 20, 2021
…bhook payload (#1043) | chore: add debug info for the payload (#1044) | fix: typo in parameters (#1045) | fix: incorrect variable name (#1046) | fix: do not use GT_REPO va (#1057) * fix: wrong interpolation (#1042) * chore: add debug traces for the webhook payload (#1043) * chore: add debug info for the payload (#1044) * fix: do not use variable names as variable prefix * chore: print payload * fix: perform another API call to fetch PR data We need a second API request, as the issue_comment API does not retrieve data about the pull request. See https://docs.github.com/en/developers/webhooks-and-events/webhook-events-and-payloads#issue_comment * fix: typo in parameters (#1045) * fix: incorrect variable name (#1046) * fix: do not use GT_REPO variable, use fixed repo name instead (#1049) * fix: do not use GT_REPO variable, use fixed repo name Because the repo is always Kibana, let's use it * chore: remove unused echo
mdelapenya
added a commit
that referenced
this pull request
Apr 20, 2021
…bhook payload (#1043) | chore: add debug info for the payload (#1044) | fix: typo in parameters (#1045) | fix: incorrect variable name (#1046) | fix: do not use GT_REPO va (#1058) * fix: wrong interpolation (#1042) * chore: add debug traces for the webhook payload (#1043) * chore: add debug info for the payload (#1044) * fix: do not use variable names as variable prefix * chore: print payload * fix: perform another API call to fetch PR data We need a second API request, as the issue_comment API does not retrieve data about the pull request. See https://docs.github.com/en/developers/webhooks-and-events/webhook-events-and-payloads#issue_comment * fix: typo in parameters (#1045) * fix: incorrect variable name (#1046) * fix: do not use GT_REPO variable, use fixed repo name instead (#1049) * fix: do not use GT_REPO variable, use fixed repo name Because the repo is always Kibana, let's use it * chore: remove unused echo
mdelapenya
added a commit
that referenced
this pull request
Apr 20, 2021
…bhook payload (#1043) | chore: add debug info for the payload (#1044) | fix: typo in parameters (#1045) | fix: incorrect variable name (#1046) | fix: do not use GT_REPO va (#1059) * fix: wrong interpolation (#1042) * chore: add debug traces for the webhook payload (#1043) * chore: add debug info for the payload (#1044) * fix: do not use variable names as variable prefix * chore: print payload * fix: perform another API call to fetch PR data We need a second API request, as the issue_comment API does not retrieve data about the pull request. See https://docs.github.com/en/developers/webhooks-and-events/webhook-events-and-payloads#issue_comment * fix: typo in parameters (#1045) * fix: incorrect variable name (#1046) * fix: do not use GT_REPO variable, use fixed repo name instead (#1049) * fix: do not use GT_REPO variable, use fixed repo name Because the repo is always Kibana, let's use it * chore: remove unused echo
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Apr 21, 2021
* master: v2 refactor (elastic#1008) fix: use a version of kibana with the fix for fleet-server validations (elastic#1055) feat: add first scenario for Fleet Server (elastic#900) fix: do not use GT_REPO variable, use fixed repo name instead (elastic#1049)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It creates a global env var for repo name (
elastic/kibana), which will be used instead of the usages of GT_REPO.Why is it important?
We noticed that, although the webhook event was properly captured by
regexpFilterText: '$GT_REPO$GT_BODY', at the moment we used it later in the pipeline, for a manual trigger, theGT_REPOvariable wasnull. I.e.:See https://beats-ci.elastic.co/blue/organizations/jenkins/e2e-tests%2Fe2e-testing-kibana-fleet/detail/e2e-testing-kibana-fleet/19/pipeline/
Checklist
make noticein the proper directory)Related issues