Fix - Template substitution with variable update#944
Merged
rochacbruno merged 6 commits intodynaconf:masterfrom Jun 30, 2023
Merged
Fix - Template substitution with variable update#944rochacbruno merged 6 commits intodynaconf:masterfrom
rochacbruno merged 6 commits intodynaconf:masterfrom
Conversation
…ynaconf#660 dynaconf#690 - add '_safe_get' and '_safe_items' to DynaBox - small indirect refactors
✅ Deploy Preview for dynaconf ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #944 +/- ##
==========================================
- Coverage 99.79% 99.64% -0.15%
==========================================
Files 22 22
Lines 1976 1994 +18
==========================================
+ Hits 1972 1987 +15
- Misses 4 7 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- can't trust telescope live_grep
rochacbruno
approved these changes
Jun 30, 2023
pedro-psb
added a commit
to pedro-psb/dynaconf
that referenced
this pull request
Jul 13, 2023
Shortlog of commits since last release:
Bruno Rocha (4):
Ignore docs build without a tag
Cancel any running CI job when a Push is made to an existing PR or branch (dynaconf#952)
Fix dynaconf#959 cli get will exit code 1 in case of KeyError. (dynaconf#960)
add tech preview note to inspect docs (dynaconf#961)
Pedro Pessoa (9):
Docs - Update envvar.md custom token e.g. to use add_converter (dynaconf#941)
Feature - Inspect and CLI (dynaconf#939)
Fix - Template substitution with variable update (dynaconf#944)
Assert dynaconf#658 works (dynaconf#945)
fix infinite recursions in special case of django app dynaconf#867 (dynaconf#947)
Fix - Django functions with `add_converter` (dynaconf#951)
Fix hooks not re-running on reload dynaconf#850 (dynaconf#953)
update vault and redis warning recommendations. fix dynaconf#950 (dynaconf#954)
Fix - Enable merge equal False (dynaconf#957)
rochacbruno
added a commit
that referenced
this pull request
Aug 11, 2023
Shortlog of commits since last release:
Bruno Rocha (5):
Ignore docs build without a tag
Cancel any running CI job when a Push is made to an existing PR or branch (#952)
Fix #959 cli get will exit code 1 in case of KeyError. (#960)
add tech preview note to inspect docs (#961)
Build docs
Hugo Prudente (1):
Doc advanced usage for cli overrides dynaconf settings fix #967 (#970)
Marian Ganisin (1):
Feat: Support for multidoc yaml files (#825)
Pedro Pessoa (11):
Docs - Update envvar.md custom token e.g. to use add_converter (#941)
Feature - Inspect and CLI (#939)
Fix - Template substitution with variable update (#944)
Assert #658 works (#945)
fix infinite recursions in special case of django app #867 (#947)
Fix - Django functions with `add_converter` (#951)
Fix hooks not re-running on reload #850 (#953)
update vault and redis warning recommendations. fix #950 (#954)
Fix - Enable merge equal False (#957)
CI - Test docker-compose pyyaml issue (#964)
Fix: unexpected _bypass_evaluation in BoxList (#966)
pedro-psb (1):
Release version 3.2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the misbehavior of template substitution when the variable to be substituted gets updated by another source, as described in #575 #603 #666 and #690
Main changes:
Lazyobjects by it's value insideparse_conf_data_safe_getand_safe_itemsmethods toDynaBox.Problem Overview
There were some points where earlier evaluation was called internally. Although those calls were unnecessary, they shouldn't have cause this bug by itself because evaluating a Lazy object means only asking it to return the final value (it doesn't replace itself with the value), so later on it should have used the correct value. Nevertheless,
parse_conf_datawas replacing the Lazy object with its early evaluation value, and that was the main cause of the problem.Additional Notes
Related to this, it would be nice to: