Fix - Order of variables break parsing (#869)#933
Merged
rochacbruno merged 3 commits intodynaconf:masterfrom May 16, 2023
Merged
Fix - Order of variables break parsing (#869)#933rochacbruno merged 3 commits intodynaconf:masterfrom
rochacbruno merged 3 commits intodynaconf:masterfrom
Conversation
✅ Deploy Preview for dynaconf ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #933 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 21 21
Lines 1843 1844 +1
=======================================
+ Hits 1838 1839 +1
Misses 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rochacbruno
approved these changes
May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a workaround for this specific case (it is not exhaustive in assuring any order is allowed).
I think v4 may implement a more explicit dependency manager for variable substitution to assure it evaluates them in the right order and properly identifies/treat cycles (probably with a graph).