Fix - Infinite recursions in django app with lowercase_read=False #867#947
Merged
rochacbruno merged 1 commit intodynaconf:masterfrom Jul 4, 2023
Merged
Conversation
✅ Deploy Preview for dynaconf ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #947 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 22 22
Lines 1994 1994
=======================================
Hits 1987 1987
Misses 7 7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rochacbruno
approved these changes
Jul 4, 2023
pedro-psb
added a commit
to pedro-psb/dynaconf
that referenced
this pull request
Jul 13, 2023
Shortlog of commits since last release:
Bruno Rocha (4):
Ignore docs build without a tag
Cancel any running CI job when a Push is made to an existing PR or branch (dynaconf#952)
Fix dynaconf#959 cli get will exit code 1 in case of KeyError. (dynaconf#960)
add tech preview note to inspect docs (dynaconf#961)
Pedro Pessoa (9):
Docs - Update envvar.md custom token e.g. to use add_converter (dynaconf#941)
Feature - Inspect and CLI (dynaconf#939)
Fix - Template substitution with variable update (dynaconf#944)
Assert dynaconf#658 works (dynaconf#945)
fix infinite recursions in special case of django app dynaconf#867 (dynaconf#947)
Fix - Django functions with `add_converter` (dynaconf#951)
Fix hooks not re-running on reload dynaconf#850 (dynaconf#953)
update vault and redis warning recommendations. fix dynaconf#950 (dynaconf#954)
Fix - Enable merge equal False (dynaconf#957)
rochacbruno
added a commit
that referenced
this pull request
Aug 11, 2023
Shortlog of commits since last release:
Bruno Rocha (5):
Ignore docs build without a tag
Cancel any running CI job when a Push is made to an existing PR or branch (#952)
Fix #959 cli get will exit code 1 in case of KeyError. (#960)
add tech preview note to inspect docs (#961)
Build docs
Hugo Prudente (1):
Doc advanced usage for cli overrides dynaconf settings fix #967 (#970)
Marian Ganisin (1):
Feat: Support for multidoc yaml files (#825)
Pedro Pessoa (11):
Docs - Update envvar.md custom token e.g. to use add_converter (#941)
Feature - Inspect and CLI (#939)
Fix - Template substitution with variable update (#944)
Assert #658 works (#945)
fix infinite recursions in special case of django app #867 (#947)
Fix - Django functions with `add_converter` (#951)
Fix hooks not re-running on reload #850 (#953)
update vault and redis warning recommendations. fix #950 (#954)
Fix - Enable merge equal False (#957)
CI - Test docker-compose pyyaml issue (#964)
Fix: unexpected _bypass_evaluation in BoxList (#966)
pedro-psb (1):
Release version 3.2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the special case that caused infinite recursion with the option
lowercase_read=Falsein #867 .This solution of some months ago was working at the time, but I misinterpreted the expected behavior for
lowercase_read=False, which disallows only all lowercase characters (but permits other cases), as shown in those unit test:dynaconf/tests/test_base.py
Line 47 in c43c29e
The solution consisted in replacing
_store.as_dict()[name]with a more direct access method, which luckly avoided the recursive calls.