Skip to content

CI - Test docker-compose pyyaml issue#964

Merged
rochacbruno merged 4 commits intodynaconf:masterfrom
pedro-psb:fix-ci-pyyaml
Jul 18, 2023
Merged

CI - Test docker-compose pyyaml issue#964
rochacbruno merged 4 commits intodynaconf:masterfrom
pedro-psb:fix-ci-pyyaml

Conversation

@pedro-psb
Copy link
Copy Markdown
Member

@pedro-psb pedro-psb commented Jul 18, 2023

problem: docker-compose from pypi does not seem maintained (the last release is from 2021). The last version from pypi (1.29.2) depends on pyyaml<=6, which has a deprecated config that is causing the CI failure.

  • bump pyyaml to v6 (which doesnt have deprecated config) the last docker-compose requires pyyaml<6
  • replace pip install docker-compose with newer standalone binaries releases. As it will not be installed by pip anymore, devs will need to assure docker-compose is available for local integration tests.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #964 (3bfb673) into master (1b225d6) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #964   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files          22       22           
  Lines        2003     2003           
=======================================
  Hits         1996     1996           
  Misses          7        7           
Impacted Files Coverage Δ
dynaconf/base.py 99.80% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pedro-psb pedro-psb requested a review from rochacbruno July 18, 2023 14:53
@rochacbruno rochacbruno merged commit cebaac1 into dynaconf:master Jul 18, 2023
rochacbruno added a commit that referenced this pull request Aug 11, 2023
Shortlog of commits since last release:

    Bruno Rocha (5):
          Ignore docs build without a tag
          Cancel any running CI job when a Push is made to an existing PR or branch (#952)
          Fix #959 cli get will exit code 1 in case of KeyError. (#960)
          add tech preview note to inspect docs (#961)
          Build docs

    Hugo Prudente (1):
          Doc advanced usage for cli overrides dynaconf settings fix #967 (#970)

    Marian Ganisin (1):
          Feat: Support for multidoc yaml files (#825)

    Pedro Pessoa (11):
          Docs - Update envvar.md custom token e.g. to use add_converter (#941)
          Feature - Inspect and CLI (#939)
          Fix - Template substitution with variable update (#944)
          Assert #658 works (#945)
          fix infinite recursions in special case of django app #867 (#947)
          Fix - Django functions with `add_converter` (#951)
          Fix hooks not re-running on reload #850 (#953)
          update vault and redis warning recommendations. fix #950 (#954)
          Fix - Enable merge equal False (#957)
          CI - Test docker-compose pyyaml issue (#964)
          Fix: unexpected _bypass_evaluation in BoxList (#966)

    pedro-psb (1):
          Release version 3.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants