Merge release/dev16.10 to inheritance margin#52358
Merged
sharwell merged 710 commits intodotnet:features/inheritanceMarginfrom Apr 2, 2021
Merged
Merge release/dev16.10 to inheritance margin#52358sharwell merged 710 commits intodotnet:features/inheritanceMarginfrom
sharwell merged 710 commits intodotnet:features/inheritanceMarginfrom
Conversation
Cache expensive lookup that never changes over life of vs.
* Fix rebuild round trip in unit tests This changes the rebuild unit tests to fully round trip the `Compilation` they are building and verify the output byte for byte matches the input. Issue dotnet#51873 discovered working on the change * Fix My template bug The parse options weren't correctly being hooked up to the `CompilationOptions` and that was breaking round tripping closes dotnet#51873 * PR feedback * Build fix * typo
Remove async method validation
Only update snippet model on explicit selection
Two green PRs had a conflict post merge
…eratorsAndIndexer/UnnamedSymbolCompletionProvider.cs Co-authored-by: Martin Strecker <MaStr11@users.noreply.github.com>
…eratorsAndIndexer/UnnamedSymbolCompletionProvider.cs Co-authored-by: Martin Strecker <MaStr11@users.noreply.github.com>
…/roslyn into intellisenseExplicitCast
…ationServiceRunner_Operators.cs Co-authored-by: Martin Strecker <MaStr11@users.noreply.github.com>
* Clarify some of the language around determinism * Update docs/compilers/Deterministic Inputs.md Co-authored-by: Julien Couvreur <jcouv@users.noreply.github.com> * Respond to PR feedback * Update docs/compilers/Deterministic Inputs.md Co-authored-by: Marius Ungureanu <therzok@gmail.com> Co-authored-by: Julien Couvreur <jcouv@users.noreply.github.com> Co-authored-by: Marius Ungureanu <therzok@gmail.com>
Export option persisters via IOptionPersisterProvider
Add manual package set to publishing which doesn't use arcade
…throws Delete AssertEx.Throws
Fixes the inability to insert a snippet for 'object.Equals'.
Fix caret affinity in GetReferencedSymbolsToLeftOfCaretAsync
…fault Enable Remove Unused References by default
Fixes [AB#1128126](https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1128126) Currently, the global option service only tracks explicitly changed option keys. This means options that have non-default values from option persisters are not part of tracked changed option keys, which leads to GlobalOptionService.SetOptions to ignore these options until an actual new solution snapshot is produced with the non-default option value. Verified customer repro and added unit test failure prior to the fix.
Fix global option service to handle non-default values from persisters
allisonchou
approved these changes
Apr 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to merge inheritance margin feature into release/dev16.10, but there are conflicts, so that why this PR is here