Fix global option service to handle non-default values from persisters#52335
Merged
mavasani merged 1 commit intodotnet:release/dev16.10from Apr 1, 2021
Merged
Conversation
sharwell
approved these changes
Apr 1, 2021
Contributor
|
@jinujoseph I think this should go in 16.10 Preview 2, and #52144 should go in 16.10 Preview 3. |
CyrusNajmabadi
approved these changes
Apr 1, 2021
Fixes [AB#1128126](https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1128126) Currently, the global option service only tracks explicitly changed option keys. This means options that have non-default values from option persisters are not part of tracked changed option keys, which leads to GlobalOptionService.SetOptions to ignore these options until an actual new solution snapshot is produced with the non-default option value. Verified customer repro and added unit test failure prior to the fix.
3dbe483 to
31570ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AB#1128126
Currently, the global option service only tracks explicitly changed option keys. This means options that have non-default values from option persisters are not part of tracked changed option keys, which leads to GlobalOptionService.SetOptions to ignore these options until an actual new solution snapshot is produced with the non-default option value.
Verified customer repro and added unit test failure prior to the fix.