Remove misleading default value for TodoCommentOptions.TokenList#52144
Merged
sharwell merged 3 commits intodotnet:mainfrom Apr 1, 2021
Merged
Remove misleading default value for TodoCommentOptions.TokenList#52144sharwell merged 3 commits intodotnet:mainfrom
sharwell merged 3 commits intodotnet:mainfrom
Conversation
Member
CyrusNajmabadi
approved these changes
Mar 25, 2021
The correct value for this option is sourced from ITaskList. Including a default value hides cases where options fail to load.
6ce7d33 to
05ae9e8
Compare
Contributor
Author
|
@CyrusNajmabadi planning to merge this after we figure out how to make it work properly so we don't wreak the world 😄 |
Contributor
|
Can we merge it asking with a fix to the underlying issue? Do we know why the option here isn't serializing properly to oop? |
Contributor
Author
|
This is ready to merge once #52335 merges. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the default value from
TodoCommentOptions.TokenList. The previous default value was problematic in two ways:A fast path was added to reduce the amount of work performed by the solution crawler if it runs with a defaulted option.