Clarify some of the language around determinism#52113
Merged
Conversation
Member
Author
|
@dotnet/roslyn-compiler can u please review this doc update? |
cston
reviewed
Mar 24, 2021
cston
reviewed
Mar 24, 2021
cston
reviewed
Mar 24, 2021
| - The compiler uses Unicode tables provided by the platform. | ||
| - The version of the zlib library that the CLR uses to implement compression (when `/embed` or `/debug:embedded` is used). | ||
| - The value of `%LIBPATH%`, as it can affect analyzer dependency loading. | ||
| - The value of `%LIBPATH%`, as it can affect reference discovery if not fully qualified and analyzer / generator dependency loading. |
Contributor
There was a problem hiding this comment.
if not fully qualified [](start = 64, length = 23)
This clause makes it difficult to parse the subsequent "and analyzer / generator dependency loading". Perhaps add parentheses: "(if not fully qualified)".
Member
Author
There was a problem hiding this comment.
I clarified the language here. The generator / analyzer dependency isn't about whether or not they're fully qualified but rather how the runtime deals with analyzer / generator dependency loading.
jcouv
reviewed
Mar 26, 2021
Co-authored-by: Julien Couvreur <jcouv@users.noreply.github.com>
Therzok
reviewed
Mar 28, 2021
Co-authored-by: Marius Ungureanu <therzok@gmail.com>
cston
approved these changes
Mar 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.