Merged
Conversation
jasonmalinowski
commented
Mar 27, 2021
Member
Author
There was a problem hiding this comment.
Observe that if this didn't throw, the test might silently pass.
We're not entirely sure why this was added; it might have been due to lack of Assert.ThrowsAsync in whichever version of xUnit we were using, or something else. In any case, it's unnecessary today and was also broken: it would silently succeed if the passed function didn't throw any exceptions at all.
8ec6238 to
87bfc80
Compare
cston
approved these changes
Mar 27, 2021
JoeRobich
approved these changes
Mar 27, 2021
RikkiGibson
approved these changes
Mar 27, 2021
jaredpar
approved these changes
Mar 28, 2021
jasonmalinowski
commented
Mar 29, 2021
Comment on lines
+2540
to
+2543
| using var workspace = CreateMSBuildWorkspace(); | ||
| await workspace.OpenProjectAsync(projectFile); | ||
| var diagnostic = Assert.Single(workspace.Diagnostics); | ||
| Assert.Contains("The process cannot access the file", diagnostic.Message); |
Member
Author
There was a problem hiding this comment.
This is asserting what the code actually does. It didn't throw an exception, and since AssertEx.Throws was bugged, we never saw.
Member
Author
|
@JoeRobich has given me permission to merge even though this breaks his PR. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're not entirely sure why this was added; it might have been due to lack of Assert.ThrowsAsync in whichever version of xUnit we were using, or something else. In any case, it's unnecessary today and was also broken: it would silently succeed if the passed function didn't throw any exceptions at all.