Remove async method validation#51557
Merged
sharwell merged 2 commits intodotnet:mainfrom Mar 18, 2021
Merged
Conversation
This check is responsible for 700MB allocations during a build of dotnet/roslyn-analyzers, and duplicates checks already running in multiple compile-time analyzers.
mavasani
reviewed
Mar 12, 2021
src/Compilers/Core/Portable/DiagnosticAnalyzer/DiagnosticAnalysisContextHelpers.cs
Show resolved
Hide resolved
Youssef1313
reviewed
Mar 12, 2021
| ); | ||
| } | ||
|
|
||
| [Fact, WorkItem(13120, "https://github.com/dotnet/roslyn/issues/13120")] |
Member
There was a problem hiding this comment.
Looking at this issue, it seems that the runtime check was preventing VS crash.
After removing this, if someone ignored the RSxxxx rule that's going to be implemented in roslyn-analyzers - or using a version without this rule -, will that crash VS?
We should make sure VS doesn't crash.
Contributor
Author
There was a problem hiding this comment.
We should make sure VS doesn't crash.
Analyzers run out-of-process now, which mitigates the IDE crash.
Youssef1313
reviewed
Mar 12, 2021
src/Compilers/CSharp/Test/Semantic/Diagnostics/DiagnosticAnalyzerTests.cs
Show resolved
Hide resolved
mavasani
approved these changes
Mar 12, 2021
Contributor
Author
|
@dotnet/roslyn-compiler for reviews |
jaredpar
approved these changes
Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This check is responsible for 700MB allocations during a build of dotnet/roslyn-analyzers (3% of total), and duplicates checks already running in multiple compile-time analyzers (e.g. VSTHRD100, VSTHRD101).