Only update snippet model on explicit selection#51948
Merged
sharwell merged 6 commits intodotnet:features/argument-completionfrom Mar 18, 2021
Merged
Only update snippet model on explicit selection#51948sharwell merged 6 commits intodotnet:features/argument-completionfrom
sharwell merged 6 commits intodotnet:features/argument-completionfrom
Conversation
jasonmalinowski
approved these changes
Mar 18, 2021
Member
jasonmalinowski
left a comment
There was a problem hiding this comment.
That was many fewer lines of code than I expected it to be. 
sharwell
commented
Mar 18, 2021
| } | ||
|
|
||
| [WpfFact] | ||
| public void FullCycle() |
Contributor
Author
There was a problem hiding this comment.
📝 This test covers a fairly obvious behavior, but one known case where it would fail is if the logic in FormatSpan breaks again
sharwell
commented
Mar 18, 2021
| VisualStudio.Editor.Verify.CurrentLineText("Test($$)", assertCaretPosition: true); | ||
|
|
||
| VisualStudio.Editor.SendKeys(VirtualKey.Down); | ||
| VisualStudio.Editor.Verify.CurrentLineText("Test(0$$)", assertCaretPosition: true); |
Contributor
Author
There was a problem hiding this comment.
📝 If FormatSpan is running on argument completion snippets, this line would fail because the test would have transitioned to:
-Test(0$$)
+Test()0$$
CyrusNajmabadi
approved these changes
Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FormatSpaninterfering with SignatureHelp