Merge master to features/static-lambdas#45237
Merged
39 commits merged intofeatures/static-lambdasfrom Jun 17, 2020
Merged
Conversation
The motivation for this change is captured in code comments.
Handle ValidateFormatString edge case
Don't default classifications if colors have been customized
Remove unnecessary caching
Fix MakeMethodAsynchronous on ValueTask without generics.
Handle new CPS analyzer node path format
Add ProjectGuid and SolutionSessionId to API telemetry
Fix LSP duplicate error messages
…614.5 (#45181) Microsoft.Net.Compilers.Toolset From Version 3.7.0-2.20267.1 -> To Version 3.7.0-4.20314.5 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
This is just to prevent tests from not doing what we expected them to do for the reason we thought.
Since we didn't have a moniker for built-in operators, we were confusing LSIF importing tools that weren't sure what to do here. They would make up a moniker based on the first use, but that's not stable across different runs. We _could_ make up a moniker here, but it's not clear if finding references for all uses of + in a project is really terribly useful.
Only send relevant completion resolve parameters
…nces-for-built-in-operators Don't generate references for built-in operators
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into features/static-lambdas.
git fetch --all git checkout merges/master-to-features/static-lambdas git reset --hard upstream/features/static-lambdas git merge upstream/master # Fix merge conflicts git commit git push upstream merges/master-to-features/static-lambdas --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.