Remove unnecessary caching#45116
Merged
CyrusNajmabadi merged 2 commits intodotnet:masterfrom Jun 13, 2020
Merged
Conversation
Contributor
What was this tested on? Roslyn.sln? |
ryzngard
approved these changes
Jun 13, 2020
Contributor
ryzngard
left a comment
There was a problem hiding this comment.
Change is as advertised, code looks fine. Could use more information on the perf testing done since this is caching related.
Contributor
Author
Yup! |
Member
|
Woohoo, thanks @CyrusNajmabadi! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This caching system wasn't buying us anything anymore (and we believe is likely incorrect). Even without the cache we go from .7s on first search, to .003s on the second.