Don't generate references for built-in operators#45125
Merged
3 commits merged intodotnet:masterfrom Jun 15, 2020
Merged
Conversation
sharwell
reviewed
Jun 12, 2020
src/EditorFeatures/TestUtilities/Workspaces/TestWorkspace_XmlConsumption.cs
Outdated
Show resolved
Hide resolved
sharwell
approved these changes
Jun 12, 2020
2b67783 to
444c9d4
Compare
CyrusNajmabadi
approved these changes
Jun 12, 2020
This is just to prevent tests from not doing what we expected them to do for the reason we thought.
Since we didn't have a moniker for built-in operators, we were confusing LSIF importing tools that weren't sure what to do here. They would make up a moniker based on the first use, but that's not stable across different runs. We _could_ make up a moniker here, but it's not clear if finding references for all uses of + in a project is really terribly useful.
444c9d4 to
3917656
Compare
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we didn't have a moniker for built-in operators, we were confusing LSIF importing tools that weren't sure what to do here. They would make up a moniker based on the first use, but that's not stable across different runs.
We could make up a moniker here, but it's not clear if finding references for all uses of + in a project is really terribly useful.