Fix MakeMethodAsynchronous on ValueTask without generics.#45150
Merged
CyrusNajmabadi merged 1 commit intodotnet:masterfrom Jun 14, 2020
Merged
Fix MakeMethodAsynchronous on ValueTask without generics.#45150CyrusNajmabadi merged 1 commit intodotnet:masterfrom
CyrusNajmabadi merged 1 commit intodotnet:masterfrom
Conversation
|
|
Contributor
|
Thanks very much for the contribution! |
CyrusNajmabadi
approved these changes
Jun 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello ~
The MakeMethodAsynchronous code fix does not recognize method return type ValueTask, resulting in a Task.
The fix is straightforward and I added a test for it.