Add ProjectGuid and SolutionSessionId to API telemetry#41443
Merged
JoeRobich merged 5 commits intodotnet:masterfrom Jun 15, 2020
Merged
Add ProjectGuid and SolutionSessionId to API telemetry#41443JoeRobich merged 5 commits intodotnet:masterfrom
JoeRobich merged 5 commits intodotnet:masterfrom
Conversation
jasonmalinowski
approved these changes
Feb 5, 2020
Member
jasonmalinowski
left a comment
There was a problem hiding this comment.
Looks good, just a few random questions.
src/Workspaces/Core/Portable/Workspace/Solution/SolutionInfo.cs
Outdated
Show resolved
Hide resolved
Member
There was a problem hiding this comment.
Do we have some serialization version that we have to bump if we change this?
Member
There was a problem hiding this comment.
IDK what is the versioning guarantees of the serializer API. Is it public? If not then I don't think it is currently necessary to bump the version since we only communicate with OOP that has of the same version of Roslyn.
src/Workspaces/Remote/Core/Telemetry/ApiUsageIncrementalAnalyzerProvider.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/Implementation/ProjectSystem/VisualStudioProjectFactory.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/Implementation/ProjectSystem/VisualStudioProjectFactory.cs
Outdated
Show resolved
Hide resolved
57d729a to
22b08f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.